[{"id":19796,"web_url":"https://patchwork.libcamera.org/comment/19796/","msgid":"<4aef486a0806d3500cfc0e785f77b535136c2659.camel@ndufresne.ca>","date":"2021-09-22T17:37:33","subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Convert\n\tcm_singleton_ptr to static variable","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mercredi 22 septembre 2021 à 22:36 +0530, Vedant Paranjape a écrit :\n> The global pointer pointing to libcamera's CameraManager isn't used\n> outside of the gstlibcamera-utils.cpp compilation unit. Make it static.\n> \n> Signed-off-by: Vedant Paranjape \n\nReviewed-by: Nicolas Dufresne \n\n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 0af91c1acb67..c434bca65174 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -223,7 +223,7 @@ gst_libcamera_resume_task(GstTask *task)\n> }\n> \n> G_LOCK_DEFINE_STATIC(cm_singleton_lock);\n> -std::weak_ptr cm_singleton_ptr;\n> +static std::weak_ptr cm_singleton_ptr;\n> \n> std::shared_ptr\n> gst_libcamera_get_camera_mananger(int &ret)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B755BDC71\n\tfor ;\n\tWed, 22 Sep 2021 17:37:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2F2D6918C;\n\tWed, 22 Sep 2021 19:37:37 +0200 (CEST)","from mail-qt1-x832.google.com (mail-qt1-x832.google.com\n\t[IPv6:2607:f8b0:4864:20::832])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3933D6917F\n\tfor ;\n\tWed, 22 Sep 2021 19:37:36 +0200 (CEST)","by mail-qt1-x832.google.com with SMTP id j13so3455410qtq.6\n\tfor ;\n\tWed, 22 Sep 2021 10:37:36 -0700 (PDT)","from nicolas-tpx395.localdomain (173-246-12-168.qc.cable.ebox.net.\n\t[173.246.12.168]) by smtp.gmail.com with ESMTPSA id\n\tb13sm1724753qtb.13.2021.09.22.10.37.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 22 Sep 2021 10:37:34 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20210112.gappssmtp.com\n\theader.i=@ndufresne-ca.20210112.gappssmtp.com\n\theader.b=\"3+KGAmxV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20210112.gappssmtp.com; s=20210112;\n\th=message-id:subject:from:to:date:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=gU/VSlu18J79ovsVOT4of9AA2Uz5F8j3WVMFT0HGZi4=;\n\tb=3+KGAmxVAb61W9MDBUWIdRw72n7jJ9K+gIofl/icEqaHBOyplg4dzel2hXz5GrwxtR\n\tDfJJmEvU9qaup+pok8U7+ioL4rJQ84ws2N16E9hoESkaewlBB9Hdgtd/76k5ueZQbyiW\n\tBwnbeq4hdYajqfkWL3bu42GZ2A6P1v7E9GDe/1/xt+v1Myj4Vitulr90w5lO5DCTnTe0\n\thAp4ShQ+TE/7/BMZBOnEIQ+4r3UyyhO4LZhKVmukQLraT3mcWQnnyxeG/66IKaBkr0LS\n\tvKsr2XC2rx/TLMovecxPgb0o0H8wj5TNWEZb2KNu9MJPaNhzV/R4V30mK8xY+EMxFDN1\n\t4AMA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:message-id:subject:from:to:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=gU/VSlu18J79ovsVOT4of9AA2Uz5F8j3WVMFT0HGZi4=;\n\tb=DxsECNDIJ28+Q4BC0NmofniXEdWIrgswF5rg/GaWVvRsiwA/nAyTXWziN9PXBklLiU\n\tPbipSzOPgLbpoT5/QnxfMMLwk9ng65Cee60nd5vbOtXrm/tzxj+7ihrAlhpj5AC0NcvG\n\tzmTifHFrg5O/pvlt55iyfhlU5CpWINfvbzfZy3zJmW+51jPsMnb5lMa9183invU5+pJu\n\trkZkh7jsqRRPa9PlLW6vgcJh/K7koWXfVj47H8dQMP9R6+zjt5T1vb6rFzJSndT9fsAE\n\tBXvkl2Ej+OK3lGHtX7Gf9QVuaZa5xHLaWUqzDYA8t7qUWNtb/sbDWI29JjmWmFUGO9T/\n\tpAtg==","X-Gm-Message-State":"AOAM532/IXrCV+1BO8MiWIkqKZ1+me9IRUfrV0JtcCx8y9LXll85JM9Y\n\tyP6OAJUlr9AzHczLYrjgsKPL8g==","X-Google-Smtp-Source":"ABdhPJx460mElCHsAV/YlQXuPEkf8P3NW0pkK5O1Mt2D7Xf5F/jEpvIRfr05tDMoAmQ0vt9psQEErw==","X-Received":"by 2002:ac8:4b41:: with SMTP id e1mr413715qts.383.1632332255039; \n\tWed, 22 Sep 2021 10:37:35 -0700 (PDT)","Message-ID":"<4aef486a0806d3500cfc0e785f77b535136c2659.camel@ndufresne.ca>","From":"Nicolas Dufresne ","To":"Vedant Paranjape , \n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 22 Sep 2021 13:37:33 -0400","In-Reply-To":"<20210922170619.421818-1-vedantparanjape160201@gmail.com>","References":"<20210922170619.421818-1-vedantparanjape160201@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.40.4 (3.40.4-1.fc34) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Convert\n\tcm_singleton_ptr to static variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19797,"web_url":"https://patchwork.libcamera.org/comment/19797/","msgid":"<22f0b0df-d4c8-eaf0-e5f7-fa51ab674226@ideasonboard.com>","date":"2021-09-22T18:26:42","subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Convert\n\tcm_singleton_ptr to static variable","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Vedant,\n\nOn 22/09/2021 19:06, Vedant Paranjape wrote:\n> The global pointer pointing to libcamera's CameraManager isn't used\n> outside of the gstlibcamera-utils.cpp compilation unit. Make it static.\n> \n> Signed-off-by: Vedant Paranjape \n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 0af91c1acb67..c434bca65174 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -223,7 +223,7 @@ gst_libcamera_resume_task(GstTask *task)\n> }\n> \n> G_LOCK_DEFINE_STATIC(cm_singleton_lock);\n> -std::weak_ptr cm_singleton_ptr;\n> +static std::weak_ptr cm_singleton_ptr;\n\nThat's a good catch !\nReviewed-by: Jean-Michel Hautbois \n\n> \n> std::shared_ptr\n> gst_libcamera_get_camera_mananger(int &ret)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DC04BF01C\n\tfor ;\n\tWed, 22 Sep 2021 18:26:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 571396918C;\n\tWed, 22 Sep 2021 20:26:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B70D6917F\n\tfor ;\n\tWed, 22 Sep 2021 20:26:45 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:4e1a:9328:3582:ccf0])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99E77F1;\n\tWed, 22 Sep 2021 20:26:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QYsazfIB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632335204;\n\tbh=z2h9asvRZLFiadMtUTxknaePGjsHpDkToxf4Ye0l7H0=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=QYsazfIB0Iqot6jrXkRxMfeaLh2ttgwUmqo7R0+IfB9HRtUQU0lQYb21GMq7GAYgJ\n\tp0OjFcwsS3MOP9dpo7IRsaHUaM9IMjsDwbXVN329IseG2p4R6wVXjYBh6uN847Sxox\n\teZnUW7xyjp52piwN3JOTY1PL59eC+MPvVlK8yRoo=","To":"Vedant Paranjape ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210922170619.421818-1-vedantparanjape160201@gmail.com>","From":"Jean-Michel Hautbois ","Message-ID":"<22f0b0df-d4c8-eaf0-e5f7-fa51ab674226@ideasonboard.com>","Date":"Wed, 22 Sep 2021 20:26:42 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<20210922170619.421818-1-vedantparanjape160201@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Convert\n\tcm_singleton_ptr to static variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19798,"web_url":"https://patchwork.libcamera.org/comment/19798/","msgid":"","date":"2021-09-22T18:28:11","subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Convert\n\tcm_singleton_ptr to static variable","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Vedant,\n\nThank you for the patch.\n\nOn 9/22/21 10:36 PM, Vedant Paranjape wrote:\n> The global pointer pointing to libcamera's CameraManager isn't used\n> outside of the gstlibcamera-utils.cpp compilation unit. Make it static.\n>\n> Signed-off-by: Vedant Paranjape \n\n\nReviewed-by: Umang Jain \n> ---\n> src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index 0af91c1acb67..c434bca65174 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -223,7 +223,7 @@ gst_libcamera_resume_task(GstTask *task)\n> }\n> \n> G_LOCK_DEFINE_STATIC(cm_singleton_lock);\n> -std::weak_ptr cm_singleton_ptr;\n> +static std::weak_ptr cm_singleton_ptr;\n> \n> std::shared_ptr\n> gst_libcamera_get_camera_mananger(int &ret)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87CCFBF01C\n\tfor ;\n\tWed, 22 Sep 2021 18:28:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BB7A6918C;\n\tWed, 22 Sep 2021 20:28:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E395D6917F\n\tfor ;\n\tWed, 22 Sep 2021 20:28:16 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 229F8F1;\n\tWed, 22 Sep 2021 20:28:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aCVMQNJK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632335296;\n\tbh=VKvj3MuSx8Xe9mvSAOmo4JQjsMBKz37FzZp0c/9RHq8=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=aCVMQNJKnp54BYb2HsDqq3OD3DlSMOwTA2GNunO1tEFSPNsoWPDrSXbSQQDl/Rwjm\n\tBsTbToHoQSKjiljuZ/H1Q1N7epS2pt6FJs5jmc4Q4NkOvICK5EJbyZoHLKOIjtxOrb\n\ts/NACJYqMc8Ass8E655NWWcf1702OVtbXGptelcs=","To":"Vedant Paranjape ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210922170619.421818-1-vedantparanjape160201@gmail.com>","From":"Umang Jain ","Message-ID":"","Date":"Wed, 22 Sep 2021 23:58:11 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210922170619.421818-1-vedantparanjape160201@gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v1] gstreamer: Convert\n\tcm_singleton_ptr to static variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]