{"id":13887,"url":"https://patchwork.libcamera.org/api/patches/13887/?format=json","web_url":"https://patchwork.libcamera.org/patch/13887/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210922170619.421818-1-vedantparanjape160201@gmail.com>","date":"2021-09-22T17:06:19","name":"[libcamera-devel,v1] gstreamer: Convert cm_singleton_ptr to static variable","commit_ref":"8d3d92ea81a1a5e52a27684aee3c4161d7dc96a7","pull_url":null,"state":"accepted","archived":false,"hash":"16402acb7991d8608f22292862ce267d11f81944","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/?format=json","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13887/mbox/","series":[{"id":2546,"url":"https://patchwork.libcamera.org/api/series/2546/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2546","date":"2021-09-22T17:06:19","name":"[libcamera-devel,v1] gstreamer: Convert cm_singleton_ptr to static variable","version":1,"mbox":"https://patchwork.libcamera.org/series/2546/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13887/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13887/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 530ABBF01C\n\tfor ;\n\tWed, 22 Sep 2021 17:06:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F3C46918E;\n\tWed, 22 Sep 2021 19:06:39 +0200 (CEST)","from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com\n\t[IPv6:2607:f8b0:4864:20::1034])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D47426917F\n\tfor ;\n\tWed, 22 Sep 2021 19:06:37 +0200 (CEST)","by mail-pj1-x1034.google.com with SMTP id\n\tlb1-20020a17090b4a4100b001993f863df2so2796263pjb.5\n\tfor ;\n\tWed, 22 Sep 2021 10:06:37 -0700 (PDT)","from localhost.localdomain ([1.186.167.167])\n\tby smtp.googlemail.com with ESMTPSA id\n\tx10sm6218257pjv.57.2021.09.22.10.06.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 22 Sep 2021 10:06:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lDkqqxPV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=m0IOy9xV7ZQ59xAegyYtbmAlKakfY/oio24R7bAtKRc=;\n\tb=lDkqqxPV2ZTJL35dRDWihaL3JtYhTnPbUeFeJUb7CwLeTtK9ZycUDA5ovb2Sm8Z3bu\n\tf+B6b58ptWXM6W5dANwdeWR2EibENWMbbpnaUM7Pf5/QkGx/LRh/SH4v0w/A10XJWjwK\n\t7fvpdfZkN1AmtQEHRaSIZz8v/Qp72qehoCaHCTdQ78i4TvqvDXZ6zvaT19kRPJGV8pay\n\tLK3UuWXTgNJQ9x/YFbGqFA2hBBSW6mU6En/AScRX+0Kksknwmr+ARYy0ULGd+hsCN6Rc\n\tMtIU0GPEKtxrAzVzuud5og5OUhu7o/ts2tYmBNB9yAjnGGJjp4rBfekN8qlbxmXu1eyr\n\tO7fQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=m0IOy9xV7ZQ59xAegyYtbmAlKakfY/oio24R7bAtKRc=;\n\tb=fV/TpEtwEpOGWwO1XU6rMG6TnCa3abu8X1Pd1ZAPmcQltrbgWHZExlqO6UoZQfjq2U\n\tTKOsnpX9xlu2FZeyrD1FbQPVo+NFKS43rhEl6Oub4XnD+rYKCcYCocXFLZrg3CTAobUs\n\t8XJqRo29XIpurWPx1tMHawJ6RZPYdxjDnTK7I+HimYosSuHaEJWwoZJGT30zYLJO9gg9\n\tJDICru2SRndrSDgm5pj2vLgd60/gDEF/JPzAJBZf+Xh+8bhtH+t8nzWg0PlbqfN6eMy1\n\tepHFjU07AEERTsGIiERV/KG1HX7yFLP/rksSdYLoLcQsC+DREAerF3+PyeGkoLxwxXo3\n\tCz2w==","X-Gm-Message-State":"AOAM532v+knrv+0heLStvNTx/nIbtilEU7dYNKyS/Wjs1uxrSxcYqKPn\n\tZaDeOD6/g0dmL+qBJ5sHLIMv+gCrCVZFfw==","X-Google-Smtp-Source":"ABdhPJyGSavAiLXStwwSSd4Xz80U33BP6Lw7/6pOj7n7+wagWs59pXxhlIwLRX2FqROjpWOjSJQ8MQ==","X-Received":"by 2002:a17:902:c942:b0:13c:88f9:1af8 with SMTP id\n\ti2-20020a170902c94200b0013c88f91af8mr619300pla.3.1632330395652; \n\tWed, 22 Sep 2021 10:06:35 -0700 (PDT)","From":"Vedant Paranjape ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 22 Sep 2021 22:36:19 +0530","Message-Id":"<20210922170619.421818-1-vedantparanjape160201@gmail.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1] gstreamer: Convert cm_singleton_ptr to\n\tstatic variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Vedant Paranjape ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The global pointer pointing to libcamera's CameraManager isn't used\noutside of the gstlibcamera-utils.cpp compilation unit. Make it static.\n\nSigned-off-by: Vedant Paranjape \n---\n src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 0af91c1acb67..c434bca65174 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -223,7 +223,7 @@ gst_libcamera_resume_task(GstTask *task)\n }\n \n G_LOCK_DEFINE_STATIC(cm_singleton_lock);\n-std::weak_ptr cm_singleton_ptr;\n+static std::weak_ptr cm_singleton_ptr;\n \n std::shared_ptr\n gst_libcamera_get_camera_mananger(int &ret)\n","prefixes":["libcamera-devel","v1"]}