{"id":1386,"url":"https://patchwork.libcamera.org/api/patches/1386/?format=json","web_url":"https://patchwork.libcamera.org/patch/1386/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190610164052.30741-6-jacopo@jmondi.org>","date":"2019-06-10T16:40:51","name":"[libcamera-devel,v2,5/6] libcamera: ipu3: Set pipe_mode based on stream configuration","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0ffaf0bc60466693f68254a3b5dd34605c5a897a","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1386/mbox/","series":[{"id":344,"url":"https://patchwork.libcamera.org/api/series/344/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=344","date":"2019-06-10T16:40:46","name":"Add support for V4L2 Controls","version":2,"mbox":"https://patchwork.libcamera.org/series/344/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1386/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1386/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF198635E2\n\tfor ;\n\tMon, 10 Jun 2019 18:39:48 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 47BBF240008;\n\tMon, 10 Jun 2019 16:39:48 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 10 Jun 2019 18:40:51 +0200","Message-Id":"<20190610164052.30741-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190610164052.30741-1-jacopo@jmondi.org>","References":"<20190610164052.30741-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 5/6] libcamera: ipu3: Set pipe_mode\n\tbased on stream configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 10 Jun 2019 16:39:49 -0000"},"content":"Set the ImgU pipe_mode control based on the active stream configuration.\nUse 'Video' pipe mode unless the viewfinder stream is not active.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 29 ++++++++++++++++++++++++++++\n 1 file changed, 29 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 05005c42106b..b3e7fb0e9c64 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -22,6 +22,7 @@\n #include \"media_device.h\"\n #include \"pipeline_handler.h\"\n #include \"utils.h\"\n+#include \"v4l2_controls.h\"\n #include \"v4l2_device.h\"\n #include \"v4l2_subdevice.h\"\n \n@@ -29,6 +30,8 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPU3)\n \n+#define IPU3_PIPE_MODE_CTRL\t0x009819c1\n+\n class ImgUDevice\n {\n public:\n@@ -536,6 +539,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t * the configuration of the active one for that purpose (there should\n \t * be at least one active stream in the configuration request).\n \t */\n+\tunsigned int pipeMode = 0;\n \tif (!outStream->active_) {\n \t\tret = imgu->configureOutput(outStream->device_, config->at(0));\n \t\tif (ret)\n@@ -546,6 +550,12 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t\tret = imgu->configureOutput(vfStream->device_, config->at(0));\n \t\tif (ret)\n \t\t\treturn ret;\n+\n+\t\t/*\n+\t\t * \\todo: This works as long as only two concurrent streams\n+\t\t * per pipe are supported.\n+\t\t */\n+\t\tpipeMode = 1;\n \t}\n \n \t/*\n@@ -559,6 +569,25 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret)\n \t\treturn ret;\n \n+\t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n+\tV4L2Controls ctrls;\n+\tctrls.set(IPU3_PIPE_MODE_CTRL, pipeMode);\n+\tret = imgu->imgu_->setControls(ctrls);\n+\tif (ret) {\n+\t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n+\t\treturn ret;\n+\t}\n+\n+\tstd::vector ctrlId = { IPU3_PIPE_MODE_CTRL, };\n+\tret = imgu->imgu_->getControls(ctrlId, &ctrls);\n+\tif (ret) {\n+\t\tLOG(IPU3, Error) << \"Unable to get pipe_mode control value\";\n+\t\treturn ret;\n+\t}\n+\n+\tpipeMode = ctrls.getInt(IPU3_PIPE_MODE_CTRL);\n+\tLOG(IPU3, Debug) << \"ImgU pipe mode set to: \"\n+\t\t\t << (pipeMode ? \"'Still Capture'\" : \"'Video'\");\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","v2","5/6"]}