[{"id":19661,"web_url":"https://patchwork.libcamera.org/comment/19661/","msgid":"<20210914043732.GD1857410@pyrite.rasen.tech>","date":"2021-09-14T04:37:32","subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Report test as\n\tskipped if no compatible driver found","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Sep 14, 2021 at 05:18:19AM +0300, Laurent Pinchart wrote:\n> The V4L2 compatibility layer test includes a list of supported devices,\n> as V4L2 compatibility isn't officially supported with all devices yet.\n> If no supported device is present, the test reports success, while it\n> actually hasn't run. Report it being skipped in that case.\n> \n> Signed-off-by: Laurent Pinchart \n\nLooks good.\n\nReviewed-by: Paul Elder \n\n> ---\n> test/v4l2_compat/v4l2_compat_test.py | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\n> index ae892ced6127..be16af3bc5e6 100755\n> --- a/test/v4l2_compat/v4l2_compat_test.py\n> +++ b/test/v4l2_compat/v4l2_compat_test.py\n> @@ -147,6 +147,10 @@ def main(argv):\n> print('success')\n> drivers_tested[driver] = True\n> \n> + if len(drivers_tested) == 0:\n> + print(f'No compatible drivers found')\n> + return TestSkip\n> +\n> if len(failed) > 0:\n> print(f'Failed {len(failed)} tests:')\n> for device in failed:\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50CC9BDC71\n\tfor ;\n\tTue, 14 Sep 2021 04:37:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C71DB69183;\n\tTue, 14 Sep 2021 06:37:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F18B6916F\n\tfor ;\n\tTue, 14 Sep 2021 06:37:40 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A98192A5;\n\tTue, 14 Sep 2021 06:37:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eGWD7F1t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631594259;\n\tbh=Gw7IidQKkysl2WMHHMmT6Ass+0ZfXDLjFQdn5cErG0o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eGWD7F1tRP16IGawxx/wpqR7BxdaPM8jll8xrwbKVEcRJzILTMNyEqOVG+8GxMtOj\n\tjzWZeUQ51yLdLizjZGeK0UoEXQQQhfjs+zjN9rod4F+oic2fHBNyoSjZpsaklvUxdx\n\tlzuR5ZHPq1X27MNaaYWxYeIAYgt5UxMs0SbE+FFE=","Date":"Tue, 14 Sep 2021 13:37:32 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210914043732.GD1857410@pyrite.rasen.tech>","References":"<20210914021819.10375-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210914021819.10375-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Report test as\n\tskipped if no compatible driver found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]