[{"id":19648,"web_url":"https://patchwork.libcamera.org/comment/19648/","msgid":"","date":"2021-09-14T01:31:29","subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a\n\ttest candidate","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Sep 14, 2021 at 10:04:13AM +0900, Paul Elder wrote:\n> As the vimc scaler prevents us from passing v4l2-compliance, skip it\n> until the fix has been merged. Instead of removing it from the\n> supported_pipelines list, add an extra check, since we will have the\n> same construct later when we check for the kernel version.\n> \n> Signed-off-by: Paul Elder \n> ---\n> test/v4l2_compat/v4l2_compat_test.py | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\n> index ae892ced..6d304b6c 100755\n> --- a/test/v4l2_compat/v4l2_compat_test.py\n> +++ b/test/v4l2_compat/v4l2_compat_test.py\n> @@ -134,6 +134,10 @@ def main(argv):\n> if driver not in supported_pipelines:\n> continue\n> \n> + # TODO: Add kernel version check\n> + if driver == \"vimc\":\n> + continue\n> +\n> if not args.all and driver in drivers_tested:\n> continue\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC8AABDB1D\n\tfor ;\n\tTue, 14 Sep 2021 01:31:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3130569184;\n\tTue, 14 Sep 2021 03:31:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E68FE6917A\n\tfor ;\n\tTue, 14 Sep 2021 03:31:54 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C8172A5;\n\tTue, 14 Sep 2021 03:31:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l1ubuCCM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631583114;\n\tbh=BwvoO9qChfZMqb102nYS9iXiEQtGpaqPgYsQSheXjbM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l1ubuCCMr7fSZx0vja8Oa7qK7eMU+JgKi7oHjL/gK3OED2UjD8hBK5ZQNy6WBkrjv\n\t/N+haQTpDdMmqIqtio+LsY2e93AGKHKH3FcTVTnvqTeGg4sE1L84iZoXWrRSumxzjm\n\tuaD/TBMsRNZzm2IYxhDIRiFisx00PF5RCj/bXT4w=","Date":"Tue, 14 Sep 2021 04:31:29 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210914010413.925842-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210914010413.925842-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a\n\ttest candidate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19660,"web_url":"https://patchwork.libcamera.org/comment/19660/","msgid":"<20210914043350.GC1857410@pyrite.rasen.tech>","date":"2021-09-14T04:33:50","subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a\n\ttest candidate","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Tue, Sep 14, 2021 at 04:31:29AM +0300, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n\n...and? :p\n\n\nPaul\n\n> \n> On Tue, Sep 14, 2021 at 10:04:13AM +0900, Paul Elder wrote:\n> > As the vimc scaler prevents us from passing v4l2-compliance, skip it\n> > until the fix has been merged. Instead of removing it from the\n> > supported_pipelines list, add an extra check, since we will have the\n> > same construct later when we check for the kernel version.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > test/v4l2_compat/v4l2_compat_test.py | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> > \n> > diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\n> > index ae892ced..6d304b6c 100755\n> > --- a/test/v4l2_compat/v4l2_compat_test.py\n> > +++ b/test/v4l2_compat/v4l2_compat_test.py\n> > @@ -134,6 +134,10 @@ def main(argv):\n> > if driver not in supported_pipelines:\n> > continue\n> > \n> > + # TODO: Add kernel version check\n> > + if driver == \"vimc\":\n> > + continue\n> > +\n> > if not args.all and driver in drivers_tested:\n> > continue\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76667BDB1D\n\tfor ;\n\tTue, 14 Sep 2021 04:34:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D940369187;\n\tTue, 14 Sep 2021 06:33:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B4056916F\n\tfor ;\n\tTue, 14 Sep 2021 06:33:58 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B971D2A5;\n\tTue, 14 Sep 2021 06:33:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fPvbMdJ9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631594037;\n\tbh=ZtJaqEpFtHnd62ATpFFi0PesWvoB8G74WDBLtgeRK9E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fPvbMdJ9/KSKJxEZ5NR0+3LE14aDCZZC5hzghYOM6MJ+M9C0UIkeFLjBkVhDs07Qc\n\tjGuFw7wHQJlxsTVXK7LrnKMq/X1nsOTfRW90Pt0I5NEpimqzdSwoUKP/hkR07XiPoq\n\tyHgDTauBrGOtcgjxeYmXIIvjwaAGyYnmgf+B68Ts=","Date":"Tue, 14 Sep 2021 13:33:50 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210914043350.GC1857410@pyrite.rasen.tech>","References":"<20210914010413.925842-1-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a\n\ttest candidate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19663,"web_url":"https://patchwork.libcamera.org/comment/19663/","msgid":"","date":"2021-09-14T04:56:56","subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a\n\ttest candidate","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Sep 14, 2021 at 01:33:50PM +0900, paul.elder@ideasonboard.com wrote:\n> On Tue, Sep 14, 2021 at 04:31:29AM +0300, Laurent Pinchart wrote:\n> > Hi Paul,\n> > \n> > Thank you for the patch.\n> \n> ...and? :p\n\nWhat ? I wanted to thank you, did you expect more ? So greedy... ;-)\n\nOK, if you insist,\n\nReviewed-by: Laurent Pinchart \n\n> > On Tue, Sep 14, 2021 at 10:04:13AM +0900, Paul Elder wrote:\n> > > As the vimc scaler prevents us from passing v4l2-compliance, skip it\n> > > until the fix has been merged. Instead of removing it from the\n> > > supported_pipelines list, add an extra check, since we will have the\n> > > same construct later when we check for the kernel version.\n> > > \n> > > Signed-off-by: Paul Elder \n> > > ---\n> > > test/v4l2_compat/v4l2_compat_test.py | 4 ++++\n> > > 1 file changed, 4 insertions(+)\n> > > \n> > > diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\n> > > index ae892ced..6d304b6c 100755\n> > > --- a/test/v4l2_compat/v4l2_compat_test.py\n> > > +++ b/test/v4l2_compat/v4l2_compat_test.py\n> > > @@ -134,6 +134,10 @@ def main(argv):\n> > > if driver not in supported_pipelines:\n> > > continue\n> > > \n> > > + # TODO: Add kernel version check\n> > > + if driver == \"vimc\":\n> > > + continue\n> > > +\n> > > if not args.all and driver in drivers_tested:\n> > > continue\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7552CBDB1D\n\tfor ;\n\tTue, 14 Sep 2021 04:57:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42A3969187;\n\tTue, 14 Sep 2021 06:57:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FD706916F\n\tfor ;\n\tTue, 14 Sep 2021 06:57:21 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED6E32A5;\n\tTue, 14 Sep 2021 06:57:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ht4hKqgo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631595441;\n\tbh=AwJS28rbU5N36GY2Q1VAe66jaG9b4xTWenSzzcrZuv4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ht4hKqgo114G0da7SjmNcA9RbbTDRSuqpfF0K5cb6j762KexEZTMSM48aEwgmu9g+\n\tGWf3uI0dLAvNCWgl2CnGBblD190c1EaQEKuGoUkPbBO3tv77oM3BL1UxNZFiPfPU+G\n\tf8bKE7Wx1IfY2Qjf2Of/KTmjxIlZfdUVbflT3cuA=","Date":"Tue, 14 Sep 2021 07:56:56 +0300","From":"Laurent Pinchart ","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20210914010413.925842-1-paul.elder@ideasonboard.com>\n\t\n\t<20210914043350.GC1857410@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210914043350.GC1857410@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a\n\ttest candidate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19723,"web_url":"https://patchwork.libcamera.org/comment/19723/","msgid":"<5d03c707-d772-27a6-b0f9-8cf32a5bf7f4@ideasonboard.com>","date":"2021-09-21T08:15:11","subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a\n\ttest candidate","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Paul,\n\nOn 14/09/2021 02:04, Paul Elder wrote:\n> As the vimc scaler prevents us from passing v4l2-compliance, skip it\n> until the fix has been merged. Instead of removing it from the\n> supported_pipelines list, add an extra check, since we will have the\n> same construct later when we check for the kernel version.\n> \n> Signed-off-by: Paul Elder \n> ---\n> test/v4l2_compat/v4l2_compat_test.py | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\n> index ae892ced..6d304b6c 100755\n> --- a/test/v4l2_compat/v4l2_compat_test.py\n> +++ b/test/v4l2_compat/v4l2_compat_test.py\n> @@ -134,6 +134,10 @@ def main(argv):\n> if driver not in supported_pipelines:\n> continue\n> \n> + # TODO: Add kernel version check\n\nAdd a kernel version check when ... vimc supports scaling ?\n\nEither way,\n\nReviewed-by: Kieran Bingham \n\n> + if driver == \"vimc\":\n> + continue\n> +\n> if not args.all and driver in drivers_tested:\n> continue\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 188B1BDC71\n\tfor ;\n\tTue, 21 Sep 2021 08:15:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5BB6F6918A;\n\tTue, 21 Sep 2021 10:15:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A27F69181\n\tfor ;\n\tTue, 21 Sep 2021 10:15:16 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B37B62BA;\n\tTue, 21 Sep 2021 10:15:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HrJdGdTV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632212115;\n\tbh=DRWAh2/FJNvBp8yL9sagL9gH4WhTnRatTvIaYEIjC+M=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=HrJdGdTV5suOi4on/M/xjmc//R7tHSYPWVevZRTzJLdMJ7/o5lWPTrGYX89f70gNY\n\tQ9JoCLZh6JLhEsrk2tXUKZLchJawAPB+xuYyvheTgH1uv7b7oLEDwp5GumYAPDHNVp\n\t5C9jwhzqkCzxmSuWSWO1KYvXQeXa0HiAXDd+BgkU=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210914010413.925842-1-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<5d03c707-d772-27a6-b0f9-8cf32a5bf7f4@ideasonboard.com>","Date":"Tue, 21 Sep 2021 09:15:11 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210914010413.925842-1-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] test: v4l2_compat: Skip vimc as a\n\ttest candidate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]