[{"id":19655,"web_url":"https://patchwork.libcamera.org/comment/19655/","msgid":"","date":"2021-09-14T03:40:18","subject":"Re: [libcamera-devel] [PATCH 08/11] ipa: ipu3: agc: Remove unused\n\tvariable count","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Mon, Sep 13, 2021 at 04:58:07PM +0200, Jean-Michel Hautbois wrote:\n> When processing brightness, a local variable is incremented at each\n> loop. There is no need for it, so remove it.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/algorithms/agc.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index e085599a..2ef998b7 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -84,7 +84,6 @@ void Agc::processBrightness(const ipu3_uapi_stats_3a *stats,\n> \tuint32_t startY = topleftY * grid.width << grid.block_width_log2;\n> \tuint32_t endX = (startX + (aeRegion.size().width >> grid.block_width_log2)) << grid.block_width_log2;\n> \tuint32_t i, j;\n> -\tuint32_t count = 0;\n> \n> \tuint32_t hist[knumHistogramBins] = { 0 };\n> \tfor (j = topleftY;\n> @@ -101,7 +100,6 @@ void Agc::processBrightness(const ipu3_uapi_stats_3a *stats,\n> \t\t\t\tuint8_t Gr = currentCell->Gr_avg;\n> \t\t\t\tuint8_t Gb = currentCell->Gb_avg;\n> \t\t\t\thist[(Gr + Gb) / 2]++;\n> -\t\t\t\tcount++;\n> \t\t\t}\n> \t\t}\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FF13BDC71\n\tfor ;\n\tTue, 14 Sep 2021 03:40:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAA6D69189;\n\tTue, 14 Sep 2021 05:40:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6EFD69181\n\tfor ;\n\tTue, 14 Sep 2021 05:40:42 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 865E12A5;\n\tTue, 14 Sep 2021 05:40:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EWe1cS72\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631590842;\n\tbh=p+/3lw8Gcm7cFwKSECU+hI2vmz9GJOTEzSNoKPd3jG0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EWe1cS729PZvT8L9TynV51SVHDyydFRriQXPOqQBfjcNclV25FVpfsVDUgufw/iIH\n\tAkRjWV+19B13ZLklRJM1r9M0saYDwQWpM9kiixmRfST6ElmdzkpDYdr4s4a8SEt3M9\n\tVkAduJFr8O861marXfhqQPFWfDoySNjlhQQUk6FE=","Date":"Tue, 14 Sep 2021 06:40:18 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210913145810.66515-9-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210913145810.66515-9-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 08/11] ipa: ipu3: agc: Remove unused\n\tvariable count","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]