[{"id":19658,"web_url":"https://patchwork.libcamera.org/comment/19658/","msgid":"","date":"2021-09-14T04:08:13","subject":"Re: [libcamera-devel] [PATCH 07/11] ipu3: ipa: agc: Determine cell\n\tsize from ipu3_uapi_awb_set_item","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Mon, Sep 13, 2021 at 04:58:06PM +0200, Jean-Michel Hautbois wrote:\n> The kCellSize was hardcoded from the size determined by examining the\n> statistics from the ImgU. The cell definition is now described as a\n> struct. Utilise the struct size to express the cell size.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/algorithms/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index 8740dcdf..e085599a 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -48,7 +48,7 @@ static constexpr uint32_t knumHistogramBins = 256;\n> static constexpr double kEvGainTarget = 0.5;\n> \n> /* A cell is 8 bytes and contains averages for RGB values and saturation ratio */\n> -static constexpr uint8_t kCellSize = 8;\n> +static constexpr uint8_t kCellSize = sizeof(ipu3_uapi_awb_set_item);\n\nAnd now I'm horrified that I've reviewed commit\n4d57a806422a46038ee3d0896162d15f931ef109 without noticing how badly it\nbroke AGC :-(\n\n> \n> Agc::Agc()\n> \t: frameCount_(0), lastFrame_(0), iqMean_(0.0), lineDuration_(0s),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FCB4BDB1D\n\tfor ;\n\tTue, 14 Sep 2021 04:08:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 858B169188;\n\tTue, 14 Sep 2021 06:08:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C9CA6916F\n\tfor ;\n\tTue, 14 Sep 2021 06:08:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AEC42A5;\n\tTue, 14 Sep 2021 06:08:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EhJ8D36b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631592517;\n\tbh=klwnRByxId9zUFk45dHeStk+44lDcm+HTx8IW7j6v/8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EhJ8D36bl8ZWo2NavU/jLL4tY6Dl3dBtJfZg4fqYHx9DoK2ezTTiCQnsocogTervq\n\toZGdjMiS3rKRk1d+fNdglgpZs8XQAFCcQMgPkE0s6iA/BdatYa2e0aBvIWDyA9hEdS\n\ticdrisR8Rb5cSU8KU6acPTVhJtQ29gN8rCPSZ41I=","Date":"Tue, 14 Sep 2021 07:08:13 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210913145810.66515-8-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210913145810.66515-8-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 07/11] ipu3: ipa: agc: Determine cell\n\tsize from ipu3_uapi_awb_set_item","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]