[{"id":19654,"web_url":"https://patchwork.libcamera.org/comment/19654/","msgid":"","date":"2021-09-14T03:39:45","subject":"Re: [libcamera-devel] [PATCH 05/11] ipa: ipu3: Explicitly use the\n\tstatistics parameter","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Mon, Sep 13, 2021 at 04:58:04PM +0200, Jean-Michel Hautbois wrote:\n> The stats pointer is marked as [[maybe_unused]]. This is a leftover from\n> a previous commit which was here to keep the compatibility while\n> transitioning to the new iterative algorithms.\n> \n> Remove this attribute to make it explicit that stats are really used to\n> feed the algorithms.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Signed-off-by: Kieran Bingham \n\nI wish there was an [[unused]] attribute that would cause a warning if\nthe variable is used :-S\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index df64b0f1..5b487dcd 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -597,7 +597,7 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n> */\n> void IPAIPU3::parseStatistics(unsigned int frame,\n> \t\t\t [[maybe_unused]] int64_t frameTimestamp,\n> -\t\t\t [[maybe_unused]] const ipu3_uapi_stats_3a *stats)\n> +\t\t\t const ipu3_uapi_stats_3a *stats)\n> {\n> \tControlList ctrls(controls::controls);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 048C3BDB1D\n\tfor ;\n\tTue, 14 Sep 2021 03:40:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7FB4D69187;\n\tTue, 14 Sep 2021 05:40:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF8AF6916F\n\tfor ;\n\tTue, 14 Sep 2021 05:40:09 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60FD12A5;\n\tTue, 14 Sep 2021 05:40:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DETQlm43\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631590809;\n\tbh=7mxssTgqsYTrRFVctnAtzLPEEv4PoH1PhggYwERPJYI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DETQlm43qS8bdFyjwJyKJCDVSY3TAE4hxRM/AVI5wJc4JkK6NHK4oKIs1YYrfR8wa\n\tOlyXlvj0cFSX5di8hDWU0dCmIaUgwzRnjr8w/al3MIvzb6IkurC8830Cm1kiD3VDtB\n\tmFtElWZBYALVv1WKeaXZdEunTN7CCfrax2iNyFe0=","Date":"Tue, 14 Sep 2021 06:39:45 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210913145810.66515-6-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210913145810.66515-6-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 05/11] ipa: ipu3: Explicitly use the\n\tstatistics parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]