[{"id":19652,"web_url":"https://patchwork.libcamera.org/comment/19652/","msgid":"","date":"2021-09-14T03:09:16","subject":"Re: [libcamera-devel] [PATCH 03/11] ipa: ipu3: Document\n\tIPAIPU3::configure","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Mon, Sep 13, 2021 at 04:58:02PM +0200, Jean-Michel Hautbois wrote:\n> Further extend the documentation for the IPAIPU3::configure operation.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/ipu3/ipu3.cpp | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index c71f2a6c..c0004ea6 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -409,6 +409,18 @@ void IPAIPU3::calculateBdsGrid(const Size &bdsOutputSize)\n> \t\t\t << (int)bdsGrid.height << \" << \" << (int)bdsGrid.block_height_log2 << \")\";\n> }\n> \n> +/**\n> + * \\brief Configure the IPU3 IPA.\n\ns/.$//\n\n> + * \\param[in] configInfo The IPA configuration data, received from the pipeline\n> + * handler\n> + *\n> + * Calculate the best grid for the statistics based on the Pipeline Handler BDS\n> + * output, and parse the minimum and maximum exposure and analogue gain control\n> + * values.\n\nMaybe that's part of a later patch in the series, but it would be useful\nto document somewhere what the BDS is, ideally in a block diagram of the\nImgU. This can be done on top of this series too.\n\n> + *\n> + * All algorithm modules are called to allow them to prepare the\n> + * \\a IPASessionConfiguration structure for the \\a IPAContext.\n> + */\n> int IPAIPU3::configure(const IPAConfigInfo &configInfo)\n> {\n> \tif (configInfo.entityControls.empty()) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1660ABDC71\n\tfor ;\n\tTue, 14 Sep 2021 03:09:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5EF0C69187;\n\tTue, 14 Sep 2021 05:09:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E96266916F\n\tfor ;\n\tTue, 14 Sep 2021 05:09:40 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F4372A5;\n\tTue, 14 Sep 2021 05:09:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OZ7TFISh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631588980;\n\tbh=ki0ECNjx9MbkFtSb/NahsOOSP2W98FzDGPDzzfHw4lg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OZ7TFIShQdBd0IXRdAwK4biJEaXpqNrESN1CVxrP1PeAlFPIken45Bsz2xLzZP8wm\n\tynldD14lXAPDuZM9G4tAAip383/xg8b81PqdQRUXuqdkKzg4U7ghCJmUU50hnMYnAd\n\t0lqcbczmrdUu1aWXkmuwTVqdqu98UgqcBBlaF5zI=","Date":"Tue, 14 Sep 2021 06:09:16 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210913145810.66515-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210913145810.66515-4-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210913145810.66515-4-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 03/11] ipa: ipu3: Document\n\tIPAIPU3::configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]