[{"id":19639,"web_url":"https://patchwork.libcamera.org/comment/19639/","msgid":"<20210913135535.7yceu3gogb6piqdj@uno.localdomain>","date":"2021-09-13T13:55:35","subject":"Re: [libcamera-devel] [PATCH v2 1/2] android: jpeg: Rectify\n\tvariable naming style.","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Umang,\n\nOn Mon, Sep 13, 2021 at 09:31:09AM +0530, Umang Jain wrote:\n> Rectify variable renaming style for YPlaneSize, UVPlaneSize.\n> libcamera uses camelCase where first letter should be in lower case.\n>\n> Fixes: e355ca0087cd9(\"android: jpeg: Split and pass the thumbnail planes to encoder\")\n> Signed-off-by: Umang Jain \n> Reviewed-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/jpeg/post_processor_jpeg.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index ef2d98cc..f6d47f63 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -82,10 +82,10 @@ void PostProcessorJpeg::generateThumbnail(const FrameBuffer &source,\n> \t\t */\n> \t\tstd::vector> thumbnailPlanes;\n> \t\tconst PixelFormatInfo &formatNV12 = PixelFormatInfo::info(formats::NV12);\n> -\t\tsize_t YPlaneSize = formatNV12.planeSize(targetSize, 0);\n> -\t\tsize_t UVPlaneSize = formatNV12.planeSize(targetSize, 1);\n> -\t\tthumbnailPlanes.push_back({ rawThumbnail.data(), YPlaneSize });\n> -\t\tthumbnailPlanes.push_back({ rawThumbnail.data() + YPlaneSize, UVPlaneSize });\n> +\t\tsize_t yPlaneSize = formatNV12.planeSize(targetSize, 0);\n> +\t\tsize_t uvPlaneSize = formatNV12.planeSize(targetSize, 1);\n> +\t\tthumbnailPlanes.push_back({ rawThumbnail.data(), yPlaneSize });\n> +\t\tthumbnailPlanes.push_back({ rawThumbnail.data() + yPlaneSize, uvPlaneSize });\n>\n> \t\tint jpeg_size = thumbnailEncoder_.encode(thumbnailPlanes,\n> \t\t\t\t\t\t\t *thumbnail, {}, quality);\n> --\n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 477F9BDB1D\n\tfor ;\n\tMon, 13 Sep 2021 13:54:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF6956916F;\n\tMon, 13 Sep 2021 15:54:50 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7D3B6024C\n\tfor ;\n\tMon, 13 Sep 2021 15:54:48 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 61D29C000D;\n\tMon, 13 Sep 2021 13:54:48 +0000 (UTC)"],"Date":"Mon, 13 Sep 2021 15:55:35 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20210913135535.7yceu3gogb6piqdj@uno.localdomain>","References":"<20210913040110.13789-1-umang.jain@ideasonboard.com>\n\t<20210913040110.13789-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210913040110.13789-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] android: jpeg: Rectify\n\tvariable naming style.","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]