[{"id":194,"web_url":"https://patchwork.libcamera.org/comment/194/","msgid":"<20190103212139.GF22790@bigcity.dyn.berto.se>","date":"2019-01-03T21:21:39","subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: device_enumerator:\n\tDowngrade skipped device errors to warnings","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-03 03:31:05 +0200, Laurent Pinchart wrote:\n> When a device is skipped by the udev-based enumerator a message is\n> logged. Downgrade its severity to warning as the error isn't fatal.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/device_enumerator.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 7eef450e0c65..bc55a12f2a4e 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -302,8 +302,8 @@ int DeviceEnumeratorUdev::enumerate()\n> \n> \t\tdev = udev_device_new_from_syspath(udev_, syspath);\n> \t\tif (!dev) {\n> -\t\t\tLOG(Error) << \"Failed to get device for '\" <<\n> -\t\t\t\t syspath << \"', skipping\";\n> +\t\t\tLOG(Warning) << \"Failed to get device for '\" <<\n> +\t\t\t\tsyspath << \"', skipping\";\n> \t\t\tcontinue;\n> \t\t}\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 889F060B21\n\tfor ;\n\tThu, 3 Jan 2019 22:21:41 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id p86so24108239lfg.5\n\tfor ;\n\tThu, 03 Jan 2019 13:21:41 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tc5-v6sm11822168lja.62.2019.01.03.13.21.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 03 Jan 2019 13:21:40 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=u6aMrAKbETXmwLRmPyOm9UJkiuEeM0On0d2qNQP/dUk=;\n\tb=TrzKUgCWk/+321SljacjWFUGR7LvM/YqplYQlLxD1fermYJYIRqTkqMr6piUQ+16XK\n\tqJ48RAgj2VwOJzIZtA4YfBZgGjiYsbs+etQZHFPb7thmQxgtyTOd+PiYzmQ87sMWDcr7\n\tRp+0De5YeKzfot5empH3vucN0/9p75W7AxwHqe1bkGYV70spV8yqeWhahOdo+v75B11S\n\trHPElQYZ0rSLEK3Hd5yWwlcNWxQzFIyXCkuI62hWo3kNLWSJjBYMpbWeccbB+txrpF9k\n\tSW5sFDoF+zdmhrrcurxYny0WCPRvFeFX9FRtckd2LgsQTVt1kgxcikKHh1ZJIPUHQU6u\n\tdYDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=u6aMrAKbETXmwLRmPyOm9UJkiuEeM0On0d2qNQP/dUk=;\n\tb=VZ+JuXjZ8AqGwkALBWRb4YJ0M+GcKVhapA2nUZyWvHwbfPdoy5G7wH+9cIkTk8ThpC\n\tV81mUHInI4bcJT6d0RrgODyEb5RvPDDMfQWMi3kSDLBItFMaa50jn35MNubYkLFg0bx9\n\t0q1MgLDkpWqm1nXQQPYxriRsmn7/FEi2LRiFqfiZCz9xWlmKIKZLkFd1BuKZIvE+1DKL\n\tRbpnmWTMI+xfUS6/SNu6uySLgU7HrjIODIVjBpkrQwwfE8jEMLQ5FGNAcSDp3UBesyWI\n\ttaxsUwMuK5nyOipe3lWS6R5y46sC8BhqJHyCI2pHDLOPPpBJeSudjwxCeF8LNAusaKIn\n\t7CKg==","X-Gm-Message-State":"AA+aEWYJQAjm6hNQZysMtC70y5SYedK1WiPLQRHP4iwrgAiit2heHolx\n\tj3EtnSSrLE8G6aXbyHhRadM22w==","X-Google-Smtp-Source":"AFSGD/VxaerMH+QGNBEdRc/rRxLqhJ4cZTJ0G3jb+d5RMehDaETUA8uOogTL/XCkeBDX5jBXLEtiNA==","X-Received":"by 2002:a19:59c2:: with SMTP id\n\tn185mr22742162lfb.118.1546550500931; \n\tThu, 03 Jan 2019 13:21:40 -0800 (PST)","Date":"Thu, 3 Jan 2019 22:21:39 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190103212139.GF22790@bigcity.dyn.berto.se>","References":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>\n\t<20190103013110.6849-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190103013110.6849-4-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: device_enumerator:\n\tDowngrade skipped device errors to warnings","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Jan 2019 21:21:41 -0000"}}]