[{"id":19589,"web_url":"https://patchwork.libcamera.org/comment/19589/","msgid":"<20210910004617.GC4137293@pyrite.rasen.tech>","date":"2021-09-10T00:46:17","subject":"Re: [libcamera-devel] [PATCH] android: yuv: Remove CameraDevice\n\tforward-declare","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Umang,\n\nOn Thu, Sep 09, 2021 at 08:48:26PM +0530, Umang Jain wrote:\n> YUV post-processor doesn't need any instance reference from CameraDevice\n> class. Remove it.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/yuv/post_processor_yuv.h | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/android/yuv/post_processor_yuv.h b/src/android/yuv/post_processor_yuv.h\n> index f8b1ba23..12f7af07 100644\n> --- a/src/android/yuv/post_processor_yuv.h\n> +++ b/src/android/yuv/post_processor_yuv.h\n> @@ -11,8 +11,6 @@\n> \n> #include \n> \n> -class CameraDevice;\n> -\n> class PostProcessorYuv : public PostProcessor\n> {\n> public:\n> -- \n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3995BBDB1D\n\tfor ;\n\tFri, 10 Sep 2021 00:46:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66A056916E;\n\tFri, 10 Sep 2021 02:46:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D696760503\n\tfor ;\n\tFri, 10 Sep 2021 02:46:24 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C3E7883;\n\tFri, 10 Sep 2021 02:46:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PU662ORH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631234784;\n\tbh=EMxbUrQ8X+QmvI114utShcEEAsFzjqx0P+6iLuDdoIQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PU662ORHwAcPr86d+3WCFjrn7XqKhIFA8OVjkpiDJqHkNsCpxp/Fyq4twLa/Tn8MN\n\twrZdozQQtZxin1mUmc3X6LY/5C3RZQnMVCoDKk81udVVDDyPR3b03qmBTSf0ITi3CG\n\tbJJRkaFltnUtNePtQmiNg6v0XQOnqq1YESGXAUxw=","Date":"Fri, 10 Sep 2021 09:46:17 +0900","From":"paul.elder@ideasonboard.com","To":"Umang Jain ","Message-ID":"<20210910004617.GC4137293@pyrite.rasen.tech>","References":"<20210909151826.270243-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210909151826.270243-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: yuv: Remove CameraDevice\n\tforward-declare","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19596,"web_url":"https://patchwork.libcamera.org/comment/19596/","msgid":"<20210910063702.ivmies4zty2fqxbq@uno.localdomain>","date":"2021-09-10T06:37:02","subject":"Re: [libcamera-devel] [PATCH] android: yuv: Remove CameraDevice\n\tforward-declare","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Umang,\n\nOn Thu, Sep 09, 2021 at 08:48:26PM +0530, Umang Jain wrote:\n> YUV post-processor doesn't need any instance reference from CameraDevice\n> class. Remove it.\n>\n> Signed-off-by: Umang Jain \n\nindeed it seems unused!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/yuv/post_processor_yuv.h | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/src/android/yuv/post_processor_yuv.h b/src/android/yuv/post_processor_yuv.h\n> index f8b1ba23..12f7af07 100644\n> --- a/src/android/yuv/post_processor_yuv.h\n> +++ b/src/android/yuv/post_processor_yuv.h\n> @@ -11,8 +11,6 @@\n>\n> #include \n>\n> -class CameraDevice;\n> -\n> class PostProcessorYuv : public PostProcessor\n> {\n> public:\n> --\n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D9CDBDC71\n\tfor ;\n\tFri, 10 Sep 2021 06:36:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2ABCB6916E;\n\tFri, 10 Sep 2021 08:36:19 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72B8360249\n\tfor ;\n\tFri, 10 Sep 2021 08:36:17 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id C5DEB24000A;\n\tFri, 10 Sep 2021 06:36:16 +0000 (UTC)"],"Date":"Fri, 10 Sep 2021 08:37:02 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Message-ID":"<20210910063702.ivmies4zty2fqxbq@uno.localdomain>","References":"<20210909151826.270243-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210909151826.270243-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: yuv: Remove CameraDevice\n\tforward-declare","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19598,"web_url":"https://patchwork.libcamera.org/comment/19598/","msgid":"","date":"2021-09-10T08:26:57","subject":"Re: [libcamera-devel] [PATCH] android: yuv: Remove CameraDevice\n\tforward-declare","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Umang, thank you for the patch.\n\nOn Fri, Sep 10, 2021 at 3:36 PM Jacopo Mondi wrote:\n>\n> Hi Umang,\n>\n> On Thu, Sep 09, 2021 at 08:48:26PM +0530, Umang Jain wrote:\n> > YUV post-processor doesn't need any instance reference from CameraDevice\n> > class. Remove it.\n> >\n> > Signed-off-by: Umang Jain \n>\n> indeed it seems unused!\n>\n> Reviewed-by: Jacopo Mondi \n>\n\nReviewed-by: Hirokazu Honda \n\n-Hiro\n\n> Thanks\n> j\n>\n> > ---\n> > src/android/yuv/post_processor_yuv.h | 2 --\n> > 1 file changed, 2 deletions(-)\n> >\n> > diff --git a/src/android/yuv/post_processor_yuv.h b/src/android/yuv/post_processor_yuv.h\n> > index f8b1ba23..12f7af07 100644\n> > --- a/src/android/yuv/post_processor_yuv.h\n> > +++ b/src/android/yuv/post_processor_yuv.h\n> > @@ -11,8 +11,6 @@\n> >\n> > #include \n> >\n> > -class CameraDevice;\n> > -\n> > class PostProcessorYuv : public PostProcessor\n> > {\n> > public:\n> > --\n> > 2.31.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3C6ABDB1D\n\tfor ;\n\tFri, 10 Sep 2021 08:27:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0B8A6917B;\n\tFri, 10 Sep 2021 10:27:09 +0200 (CEST)","from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com\n\t[IPv6:2a00:1450:4864:20::62d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A81156024A\n\tfor ;\n\tFri, 10 Sep 2021 10:27:08 +0200 (CEST)","by mail-ej1-x62d.google.com with SMTP id h9so2663946ejs.4\n\tfor ;\n\tFri, 10 Sep 2021 01:27:08 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"k+ZthoeF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=kQec+XCKwWafzEV53Q8FhGXmGmtk+uebjdQ3KGSiPOg=;\n\tb=k+ZthoeFx68BSOzG3ZcwLR3qb6PG9joPev4gSD4C6r/TC0K68tq2y+varLb2hE5MXG\n\tnVOVwFEhwdF6pFtimp3UrOLP+mGKqjS2d8Jz0+4yph+PHAYdLNvCkRuyYF5WXhTD+Yko\n\tlHYN8pcvmDIWa8FLc8PONeUPmxOHlIUFh4mJE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=kQec+XCKwWafzEV53Q8FhGXmGmtk+uebjdQ3KGSiPOg=;\n\tb=e9YhRjdLBWkNhVQVXkN5y+vLexeGT8qrS2Danh36WBIbQg7H6SwOGbAeRNgeQ2EBPg\n\tGsebLdG0ujZl6gV3we/75vCnV/VMKzgM5kaLz6xLW3R5yvunPoLB53AE8IlDx7jliPEQ\n\tRVp3nb1tts5ZAwJclVHxWfuvAOfCf4c6ZIQ8ghKuXjEgY8VIvjxyAj+q350/sSXoh7h/\n\tgmMF5A31wZ1J94mudMXBhWEjQXaURNZ6xWrZ6K4eP+HSbzJEkfk62A7Xyum/pRne0vH/\n\tUlSpd+D7LTqLAwheuKh2zFyErch1+L1Bd3+mP2JYSRoKyctPxnXTP9B7mg926fOGC4Cs\n\tKF6w==","X-Gm-Message-State":"AOAM530N7IT5TmRYfGbAr4IrG1hsKeDz81eszCQRTeK/14Y6QAJzVrgq\n\tQcIAqGX6bCF3AC44uGZcrajB79koXff8oqxEuedmoQ==","X-Google-Smtp-Source":"ABdhPJzjJdDlcE/FtUq+ZJvKTAm6JukckX82d/X7JQc8z+ihSOi26TnBfmHrI74Gxko7Zl6GKxIUD3eO1fAIO1IB9l4=","X-Received":"by 2002:a17:906:2691:: with SMTP id\n\tt17mr3162195ejc.522.1631262428352; \n\tFri, 10 Sep 2021 01:27:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20210909151826.270243-1-umang.jain@ideasonboard.com>\n\t<20210910063702.ivmies4zty2fqxbq@uno.localdomain>","In-Reply-To":"<20210910063702.ivmies4zty2fqxbq@uno.localdomain>","From":"Hirokazu Honda ","Date":"Fri, 10 Sep 2021 17:26:57 +0900","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] android: yuv: Remove CameraDevice\n\tforward-declare","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]