[{"id":1829,"web_url":"https://patchwork.libcamera.org/comment/1829/","msgid":"<3db905d3-7d23-c52b-22fd-f5d5b4f1e197@ideasonboard.com>","date":"2019-06-10T12:14:25","subject":"Re: [libcamera-devel] [PATCH] cam: Fix cam --help crash","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nThanks for picking this up.\n\nOn 10/06/2019 12:49, Niklas Söderlund wrote:\n> The cam utility do not terminate correctly if invoked with only --help.\n\n'does not'\n\n> It prints the help information and then segfaults as the application is\n> not terminated correctly. Fix this by moving the return code check of\n\n\"segfaults due to the application incorrectly handling the return value.\" ?\n\n> the option parsing to main().\n> \n> Reported-by: Emmanuel Arias <eamanu@eamanu.com>\n> Suggested-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> ---\n>  src/cam/main.cpp | 8 +++++---\n>  1 file changed, 5 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index dbf04917bcc5aa38..f03a9faf87fac865 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -61,7 +61,7 @@ int CamApp::init(int argc, char **argv)\n>  \n>  \tret = parseOptions(argc, argv);\n>  \tif (ret < 0)\n> -\t\treturn ret == -EINTR ? 0 : ret;\n> +\t\treturn ret;\n>  \n>  \tcm_ = CameraManager::instance();\n>  \n> @@ -193,9 +193,11 @@ void signalHandler(int signal)\n>  int main(int argc, char **argv)\n>  {\n>  \tCamApp app;\n> +\tint ret;\n>  \n> -\tif (app.init(argc, argv))\n> -\t\treturn EXIT_FAILURE;\n> +\tret = app.init(argc, argv);\n> +\tif (ret)\n> +\t\treturn ret == -EINTR ? 0 : EXIT_FAILURE;\n>  \n>  \tstruct sigaction sa = {};\n>  \tsa.sa_handler = &signalHandler;\n>","headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED049636B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2019 14:14:27 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76F2E9CB;\n\tMon, 10 Jun 2019 14:14:27 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560168867;\n\tbh=7+Vo7M4KjNd/kyy79KHz4sLqEjLmMJPuSIhOYsJll1s=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=omXK/Te7xTcE7lLqWvZ6CjihIgslO+eYvnTn8mAyXarYqoPi0WZpufdGj8RGg/aDn\n\tWyre6wZ9kDM+tIXx7QyCEJDLlhz0qtLaLvGTYJDxUcs4Y9kvpA/wPN8Vbg3e7h16qw\n\tiQ4G9AmgtnY/aXRjMvv8/A6EituFZEbuzIOXC9hM=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190610114936.30175-1-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<3db905d3-7d23-c52b-22fd-f5d5b4f1e197@ideasonboard.com>","Date":"Mon, 10 Jun 2019 13:14:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.0","MIME-Version":"1.0","In-Reply-To":"<20190610114936.30175-1-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] cam: Fix cam --help crash","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 10 Jun 2019 12:14:28 -0000"}},{"id":1830,"web_url":"https://patchwork.libcamera.org/comment/1830/","msgid":"<20190610142714.GA11078@pendragon.ideasonboard.com>","date":"2019-06-10T14:27:14","subject":"Re: [libcamera-devel] [PATCH] cam: Fix cam --help crash","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Mon, Jun 10, 2019 at 01:14:25PM +0100, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> Thanks for picking this up.\n> \n> On 10/06/2019 12:49, Niklas Söderlund wrote:\n> > The cam utility do not terminate correctly if invoked with only --help.\n> \n> 'does not'\n> \n> > It prints the help information and then segfaults as the application is\n> > not terminated correctly. Fix this by moving the return code check of\n> \n> \"segfaults due to the application incorrectly handling the return value.\" ?\n> \n> > the option parsing to main().\n> > \n> > Reported-by: Emmanuel Arias <eamanu@eamanu.com>\n> > Suggested-by: Jacopo Mondi <jacopo@jmondi.org>\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> > ---\n> >  src/cam/main.cpp | 8 +++++---\n> >  1 file changed, 5 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> > index dbf04917bcc5aa38..f03a9faf87fac865 100644\n> > --- a/src/cam/main.cpp\n> > +++ b/src/cam/main.cpp\n> > @@ -61,7 +61,7 @@ int CamApp::init(int argc, char **argv)\n> >  \n> >  \tret = parseOptions(argc, argv);\n> >  \tif (ret < 0)\n> > -\t\treturn ret == -EINTR ? 0 : ret;\n> > +\t\treturn ret;\n> >  \n> >  \tcm_ = CameraManager::instance();\n> >  \n> > @@ -193,9 +193,11 @@ void signalHandler(int signal)\n> >  int main(int argc, char **argv)\n> >  {\n> >  \tCamApp app;\n> > +\tint ret;\n> >  \n> > -\tif (app.init(argc, argv))\n> > -\t\treturn EXIT_FAILURE;\n> > +\tret = app.init(argc, argv);\n> > +\tif (ret)\n> > +\t\treturn ret == -EINTR ? 0 : EXIT_FAILURE;\n> >  \n> >  \tstruct sigaction sa = {};\n> >  \tsa.sa_handler = &signalHandler;","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D8CE6365D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2019 16:27:30 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D301C9CB;\n\tMon, 10 Jun 2019 16:27:29 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560176850;\n\tbh=VoFoZOiCXaj4vYTI4V0IELG677a6F8iPIXU3MifBDcs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rW1H3WeilIOPpaoWvpWgGtjib7O8UJHRilV2WY5oEUrUcxiRSpFSEYah9oqeccRLb\n\te3K0+wAxZdb3tCgwjM8XdK+RgGmmEAdINejqs6Ga7GjP9JdJ7DB6HLgbFpOMgELOmh\n\t1tU4PNVB6F0vaxP1l+gNqwAhNFp3RaXgxR78rc5k=","Date":"Mon, 10 Jun 2019 17:27:14 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20190610142714.GA11078@pendragon.ideasonboard.com>","References":"<20190610114936.30175-1-niklas.soderlund@ragnatech.se>\n\t<3db905d3-7d23-c52b-22fd-f5d5b4f1e197@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<3db905d3-7d23-c52b-22fd-f5d5b4f1e197@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] cam: Fix cam --help crash","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 10 Jun 2019 14:27:30 -0000"}},{"id":1832,"web_url":"https://patchwork.libcamera.org/comment/1832/","msgid":"<20190610210839.GF1362@bigcity.dyn.berto.se>","date":"2019-06-10T21:08:39","subject":"Re: [libcamera-devel] [PATCH] cam: Fix cam --help crash","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nThanks for reviewing this, I have pushed this to master with Kieran's \nspelling improvements to the commit message.\n\nOn 2019-06-10 17:27:14 +0300, Laurent Pinchart wrote:\n> Hello,\n> \n> On Mon, Jun 10, 2019 at 01:14:25PM +0100, Kieran Bingham wrote:\n> > Hi Niklas,\n> > \n> > Thanks for picking this up.\n> > \n> > On 10/06/2019 12:49, Niklas Söderlund wrote:\n> > > The cam utility do not terminate correctly if invoked with only --help.\n> > \n> > 'does not'\n> > \n> > > It prints the help information and then segfaults as the application is\n> > > not terminated correctly. Fix this by moving the return code check of\n> > \n> > \"segfaults due to the application incorrectly handling the return value.\" ?\n> > \n> > > the option parsing to main().\n> > > \n> > > Reported-by: Emmanuel Arias <eamanu@eamanu.com>\n> > > Suggested-by: Jacopo Mondi <jacopo@jmondi.org>\n> > \n> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > \n> > > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> > > ---\n> > >  src/cam/main.cpp | 8 +++++---\n> > >  1 file changed, 5 insertions(+), 3 deletions(-)\n> > > \n> > > diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> > > index dbf04917bcc5aa38..f03a9faf87fac865 100644\n> > > --- a/src/cam/main.cpp\n> > > +++ b/src/cam/main.cpp\n> > > @@ -61,7 +61,7 @@ int CamApp::init(int argc, char **argv)\n> > >  \n> > >  \tret = parseOptions(argc, argv);\n> > >  \tif (ret < 0)\n> > > -\t\treturn ret == -EINTR ? 0 : ret;\n> > > +\t\treturn ret;\n> > >  \n> > >  \tcm_ = CameraManager::instance();\n> > >  \n> > > @@ -193,9 +193,11 @@ void signalHandler(int signal)\n> > >  int main(int argc, char **argv)\n> > >  {\n> > >  \tCamApp app;\n> > > +\tint ret;\n> > >  \n> > > -\tif (app.init(argc, argv))\n> > > -\t\treturn EXIT_FAILURE;\n> > > +\tret = app.init(argc, argv);\n> > > +\tif (ret)\n> > > +\t\treturn ret == -EINTR ? 0 : EXIT_FAILURE;\n> > >  \n> > >  \tstruct sigaction sa = {};\n> > >  \tsa.sa_handler = &signalHandler;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97CB261911\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2019 23:08:41 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id s21so9378823lji.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2019 14:08:41 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tc8sm2186930ljk.77.2019.06.10.14.08.39\n\tfor <libcamera-devel@lists.libcamera.org>\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 10 Jun 2019 14:08:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=ylcKfmqvSRVrjbC2wvLY/PN0k/rlzzm83wku1jlDqss=;\n\tb=GaW8XMRIHla6KXzDxH/XSGovu/PtgmyJGHpRSt9Gy+yHtwtK87iQt4wacwDCRmtfeC\n\tEY2Voc6NEgT3+a49KwUe0hOVuPO8Y07hSvw3P2Dyk2lgGqmS5d7rNfDu1UruMZKt80Cx\n\tZxHYPkVxCI/RTZydGKzzeiQrva1tvNTRWagX8jBlRef8HC+Ft9mBBmf7FRFYggFXwaAS\n\tFUoO5DgSXYpTI1s1X1/YYsb1V/s1ssnrQ2Yi+zVIYOxC2UgFayXWCTdI5cOI+Rx+RRPw\n\t3/78R4AcafR9vmXrqw5y9dlySJUOU+/oQWxS2TVH1ucOYOe84Mmc0yypRpPs8trrIoMb\n\tSwiA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=ylcKfmqvSRVrjbC2wvLY/PN0k/rlzzm83wku1jlDqss=;\n\tb=Xl68rQBduE3F8PBtiY5wybmRgtnvpxRQKRGDeEo6HkFJhmP/NzI+KfxAtaZBJs4k05\n\tM9RatsO3+lhyzv5Jo3doZCCr49Yghbisped95Z6Ys/VR35Swm4fcQ0nXrShbAIBMrHjJ\n\t2wBJnSKtgXV9DOnKzA1ISw+uNYT2oHukjjMxtpSXH1T9p6XonV/e/FRVDqzLXrJp1gsr\n\t7xDSoJzfQJeqAh58BSQ3VVM5IAyp4Kkr0TYYdFqNzub5kbyndbkzpxMzcghrYFhNxt5G\n\twEsbyk0n2bBaDzfBUPKmKVAxMfZkGstzmHZT9jYgqeXnS9aBr9yKDbshWn+DG7T7Dd1h\n\tEqFA==","X-Gm-Message-State":"APjAAAVfx9A/Y6UN8iAdqU+wMbXTrGY+q8UZixKmLPunAxJrALoVZri1\n\tbgQC1p0vC3bLVerMcpG8eUOnkWU3EvY=","X-Google-Smtp-Source":"APXvYqyLY1zGLUst9Zh3znuepEd7aPLJDwqmxATPfpb/VZMl+djM4DuDCmxDSxdEng9J++kGeeI4+A==","X-Received":"by 2002:a2e:9cc3:: with SMTP id\n\tg3mr22023175ljj.117.1560200920594; \n\tMon, 10 Jun 2019 14:08:40 -0700 (PDT)","Date":"Mon, 10 Jun 2019 23:08:39 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190610210839.GF1362@bigcity.dyn.berto.se>","References":"<20190610114936.30175-1-niklas.soderlund@ragnatech.se>\n\t<3db905d3-7d23-c52b-22fd-f5d5b4f1e197@ideasonboard.com>\n\t<20190610142714.GA11078@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190610142714.GA11078@pendragon.ideasonboard.com>","User-Agent":"Mutt/1.11.4 (2019-03-13)","Subject":"Re: [libcamera-devel] [PATCH] cam: Fix cam --help crash","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 10 Jun 2019 21:08:41 -0000"}}]