[{"id":19607,"web_url":"https://patchwork.libcamera.org/comment/19607/","msgid":"","date":"2021-09-10T15:01:27","subject":"Re: [libcamera-devel] [PATCH v6 1/5] ipa: ipu3: Move the AWB stats\n\tstructures","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Thu, Sep 09, 2021 at 03:54:45PM +0200, Jean-Michel Hautbois wrote:\n> The structure Ipu3AwbCell describes the AWB stats layout on the kernel\n> side. We will need it to be used by the AGC algorithm to be introduced\n> later, so let's make it visible from ipa::ipu3::algorithms and not only\n> for the AWB class.\n> \n> The IspStatsRegion will be needed by AGC too, so let's move it in the\n> same namespace too.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/algorithms/awb.h | 37 ++++++++++++++++++-----------------\n> 1 file changed, 19 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h\n> index a16dd68d..cc848060 100644\n> --- a/src/ipa/ipu3/algorithms/awb.h\n> +++ b/src/ipa/ipu3/algorithms/awb.h\n> @@ -23,6 +23,24 @@ namespace ipa::ipu3::algorithms {\n> static constexpr uint32_t kAwbStatsSizeX = 16;\n> static constexpr uint32_t kAwbStatsSizeY = 12;\n> \n> +/* \\todo Move the cell layout into intel-ipu3.h kernel header */\n> +struct Ipu3AwbCell {\n> +\tunsigned char greenRedAvg;\n> +\tunsigned char redAvg;\n> +\tunsigned char blueAvg;\n> +\tunsigned char greenBlueAvg;\n> +\tunsigned char satRatio;\n> +\tunsigned char padding[3];\n> +} __attribute__((packed));\n> +\n> +struct IspStatsRegion {\n> +\tunsigned int counted;\n> +\tunsigned int uncounted;\n> +\tunsigned long long rSum;\n> +\tunsigned long long gSum;\n> +\tunsigned long long bSum;\n> +};\n> +\n> class Awb : public Algorithm\n> {\n> public:\n> @@ -32,16 +50,7 @@ public:\n> \tvoid prepare(IPAContext &context, ipu3_uapi_params *params) override;\n> \tvoid process(IPAContext &context, const ipu3_uapi_stats_3a *stats) override;\n> \n> -\tstruct Ipu3AwbCell {\n> -\t\tunsigned char greenRedAvg;\n> -\t\tunsigned char redAvg;\n> -\t\tunsigned char blueAvg;\n> -\t\tunsigned char greenBlueAvg;\n> -\t\tunsigned char satRatio;\n> -\t\tunsigned char padding[3];\n> -\t} __attribute__((packed));\n> -\n> -\t/* \\todo Make these three structs available to all the ISPs ? */\n> +\t/* \\todo Make these structs available to all the ISPs ? */\n> \tstruct RGB {\n> \t\tRGB(double _R = 0, double _G = 0, double _B = 0)\n> \t\t\t: R(_R), G(_G), B(_B)\n> @@ -55,14 +64,6 @@ public:\n> \t\t}\n> \t};\n> \n> -\tstruct IspStatsRegion {\n> -\t\tunsigned int counted;\n> -\t\tunsigned int uncounted;\n> -\t\tunsigned long long rSum;\n> -\t\tunsigned long long gSum;\n> -\t\tunsigned long long bSum;\n> -\t};\n> -\n> \tstruct AwbStatus {\n> \t\tdouble temperatureK;\n> \t\tdouble redGain;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F20FBDB1D\n\tfor ;\n\tFri, 10 Sep 2021 15:01:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43C3669170;\n\tFri, 10 Sep 2021 17:01:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C37369169\n\tfor ;\n\tFri, 10 Sep 2021 17:01:50 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F6BDDD;\n\tFri, 10 Sep 2021 17:01:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k9lbEoY/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631286109;\n\tbh=JdlLfXlq+tHx/S99RJ84FTDD8EWqD6YkqLW2moVsg+Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k9lbEoY/flxlE/+ojvkdiKXvccSrbmduAp6CVsNnJhkfXI4WWccCG1sYKwbovuKhP\n\tZc5Boy25axLDOsWfJnZ9aL+BIDdozDSlyuO5TVEmmys1Z0WRq1HtYGmO4muXDjVlyH\n\t0e2RNoyfqxZN2IGDpigsL0FYdfyuhX/glEgUmZNo=","Date":"Fri, 10 Sep 2021 18:01:27 +0300","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210909135449.68017-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210909135449.68017-2-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210909135449.68017-2-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v6 1/5] ipa: ipu3: Move the AWB stats\n\tstructures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]