{"id":13778,"url":"https://patchwork.libcamera.org/api/patches/13778/?format=json","web_url":"https://patchwork.libcamera.org/patch/13778/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210909080902.239533-8-paul.elder@ideasonboard.com>","date":"2021-09-09T08:09:02","name":"[libcamera-devel,v3,7/7] test: v4l2_compat_test: Fix v4l2-compliance version parsing","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"99a7132a6da19f8542f867cbc56549ba96ff8884","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13778/mbox/","series":[{"id":2502,"url":"https://patchwork.libcamera.org/api/series/2502/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2502","date":"2021-09-09T08:08:55","name":"v4l2-compat fixes","version":3,"mbox":"https://patchwork.libcamera.org/series/2502/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13778/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13778/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4745DBDC71\n\tfor ;\n\tThu, 9 Sep 2021 08:09:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F232E6916F;\n\tThu, 9 Sep 2021 10:09:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 243D46916A\n\tfor ;\n\tThu, 9 Sep 2021 10:09:28 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 69A2B24F;\n\tThu, 9 Sep 2021 10:09:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vzt/JEJY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631174966;\n\tbh=h1yQazzvczXDSFiptddBzYZaEVPm0ehcDiNNS8tiw58=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vzt/JEJYq4ACKomLn6WvrN2gU8XdDiwq9I/II+0O5pHgeAdna0lqxdQo+UmtHRqyo\n\tebE0HaEeLr7EoreKf3ljEsh4YqlB9QwN1YndimqOId8jIZvCtqTJ3bDRpURrlJJZdD\n\tVcPAm6njoyhlyHmCOodM8NIHh+gQiB6dRe9Lin04=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Sep 2021 17:09:02 +0900","Message-Id":"<20210909080902.239533-8-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210909080902.239533-1-paul.elder@ideasonboard.com>","References":"<20210909080902.239533-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 7/7] test: v4l2_compat_test: Fix\n\tv4l2-compliance version parsing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"v4l2-compliance changed their version string:\n\nv4l2-compliance 1.21.0-4618\nv4l2-compliance SHA: cc211b76476aca2c072ffa83a9b003957d5f3909, 64 bits, 64-bit time_t\n\nv4l2-compliance 1.21.0-4838, 64 bits, 64-bit time_t\n\nThe current parsing takes the last result of split, which works for the\nformer, but not the latter. Take the second result of split instead, and\nstrip away any commas.\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nTested-by: Laurent Pinchart \n---\n test/v4l2_compat/v4l2_compat_test.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/test/v4l2_compat/v4l2_compat_test.py b/test/v4l2_compat/v4l2_compat_test.py\nindex 51bfa952..ae892ced 100755\n--- a/test/v4l2_compat/v4l2_compat_test.py\n+++ b/test/v4l2_compat/v4l2_compat_test.py\n@@ -94,7 +94,7 @@ def main(argv):\n return TestSkip\n \n ret, out = run_with_stdout(v4l2_compliance, '--version')\n- if ret != 0 or version.parse(out[0].split()[-1]) < MIN_V4L_UTILS_VERSION:\n+ if ret != 0 or version.parse(out[0].split()[1].replace(',', '')) < MIN_V4L_UTILS_VERSION:\n print('v4l2-compliance version >= 1.21.0 required')\n return TestSkip\n \n","prefixes":["libcamera-devel","v3","7/7"]}