[{"id":19570,"web_url":"https://patchwork.libcamera.org/comment/19570/","msgid":"","date":"2021-09-09T08:35:43","subject":"Re: [libcamera-devel] [PATCH v3 5/7] v4l2: v4l2_camera_proxy:\n\tReport the proper format name in enum_fmt","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"On 09/09/2021 10:09, Paul Elder wrote:\n> Now that libcamera has the V4L2 format names, retrive and report those\ns/retrive/retrieve\n\n> names in ENUM_FMT. While at it, refactor the code slightly with\n> PixelFormatInfo.\n> \n> This fixes the test failures on v4l2-compliance with the v4l2\n> compatilibity layer that were observed in version v4l2-compliance\n> version 1.21.0-4838.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \nReviewed-by: Jean-Michel Hautbois \n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index aeffef26..abb30820 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -274,13 +274,13 @@ int V4L2CameraProxy::vidioc_enum_fmt(V4L2CameraFile *file, struct v4l2_fmtdesc *\n> \t\treturn -EINVAL;\n> \n> \tPixelFormat format = streamConfig_.formats().pixelformats()[arg->index];\n> +\tV4L2PixelFormat v4l2Format = V4L2PixelFormat::fromPixelFormat(format);\n> \n> \t/* \\todo Set V4L2_FMT_FLAG_COMPRESSED for compressed formats. */\n> \targ->flags = 0;\n> -\t/* \\todo Add map from format to description. */\n> \tutils::strlcpy(reinterpret_cast(arg->description),\n> -\t\t \"Video Format Description\", sizeof(arg->description));\n> -\targ->pixelformat = V4L2PixelFormat::fromPixelFormat(format);\n> +\t\t v4l2Format.description(), sizeof(arg->description));\n> +\targ->pixelformat = v4l2Format;\n> \n> \tmemset(arg->reserved, 0, sizeof(arg->reserved));\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34B70BDB1D\n\tfor ;\n\tThu, 9 Sep 2021 08:35:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04FCC6916E;\n\tThu, 9 Sep 2021 10:35:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 505066024E\n\tfor ;\n\tThu, 9 Sep 2021 10:35:46 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ab35:be36:579e:39cf])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10A82466;\n\tThu, 9 Sep 2021 10:35:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Qd5a3TOD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631176546;\n\tbh=sKZt+vXo4uDMcabFW+qMI5bp+RCcexn8pPPK4xgaOic=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Qd5a3TODeD3XyJYq2gxgokxfYe7Z38ycON+7Nzw95wxuyS5CqMDqb/BME10JfVGqg\n\tYxVFj8zxpr6831gTN61oXnIiV+vWLxchUWfDYCs8v31himsoAtbc9m5//zpjYmuUd4\n\t+QVG5cA5jTXC9BD7mQJa1I8lzsGMEd2H5SMYB8Lo=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210909080902.239533-1-paul.elder@ideasonboard.com>\n\t<20210909080902.239533-6-paul.elder@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Thu, 9 Sep 2021 10:35:43 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<20210909080902.239533-6-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 5/7] v4l2: v4l2_camera_proxy:\n\tReport the proper format name in enum_fmt","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]