{"id":13776,"url":"https://patchwork.libcamera.org/api/patches/13776/?format=json","web_url":"https://patchwork.libcamera.org/patch/13776/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210909080902.239533-6-paul.elder@ideasonboard.com>","date":"2021-09-09T08:09:00","name":"[libcamera-devel,v3,5/7] v4l2: v4l2_camera_proxy: Report the proper format name in enum_fmt","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c3c2cdf1e59878a916fad7c3dcceeaf02ff6f1c4","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13776/mbox/","series":[{"id":2502,"url":"https://patchwork.libcamera.org/api/series/2502/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2502","date":"2021-09-09T08:08:55","name":"v4l2-compat fixes","version":3,"mbox":"https://patchwork.libcamera.org/series/2502/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13776/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13776/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8025CBDC71\n\tfor ;\n\tThu, 9 Sep 2021 08:09:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F23869177;\n\tThu, 9 Sep 2021 10:09:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B9506916A\n\tfor ;\n\tThu, 9 Sep 2021 10:09:23 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C905D883;\n\tThu, 9 Sep 2021 10:09:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DAs6J6So\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631174963;\n\tbh=QysgIK5Sl6jafgrOuXAafwucD89COeuu3iCcGYtJ2kM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DAs6J6SozbNQgeDKPpOwTPLPdaOFd7iXvyFnAkCipluunRJ748HGS+FWAXJD6ztTY\n\tUWFiIQDpWZHRUMjudSGgK8E0XKD2Kw2s8MxAQQzTjoLooYnt4+8teV9k3wunSNPs31\n\tpNsx/K5TnqJxpN5vx46P+WMKQ19F+o6wkdVGdSWA=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Sep 2021 17:09:00 +0900","Message-Id":"<20210909080902.239533-6-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210909080902.239533-1-paul.elder@ideasonboard.com>","References":"<20210909080902.239533-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 5/7] v4l2: v4l2_camera_proxy: Report\n\tthe proper format name in enum_fmt","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that libcamera has the V4L2 format names, retrive and report those\nnames in ENUM_FMT. While at it, refactor the code slightly with\nPixelFormatInfo.\n\nThis fixes the test failures on v4l2-compliance with the v4l2\ncompatilibity layer that were observed in version v4l2-compliance\nversion 1.21.0-4838.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n---\n src/v4l2/v4l2_camera_proxy.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex aeffef26..abb30820 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -274,13 +274,13 @@ int V4L2CameraProxy::vidioc_enum_fmt(V4L2CameraFile *file, struct v4l2_fmtdesc *\n \t\treturn -EINVAL;\n \n \tPixelFormat format = streamConfig_.formats().pixelformats()[arg->index];\n+\tV4L2PixelFormat v4l2Format = V4L2PixelFormat::fromPixelFormat(format);\n \n \t/* \\todo Set V4L2_FMT_FLAG_COMPRESSED for compressed formats. */\n \targ->flags = 0;\n-\t/* \\todo Add map from format to description. */\n \tutils::strlcpy(reinterpret_cast(arg->description),\n-\t\t \"Video Format Description\", sizeof(arg->description));\n-\targ->pixelformat = V4L2PixelFormat::fromPixelFormat(format);\n+\t\t v4l2Format.description(), sizeof(arg->description));\n+\targ->pixelformat = v4l2Format;\n \n \tmemset(arg->reserved, 0, sizeof(arg->reserved));\n \n","prefixes":["libcamera-devel","v3","5/7"]}