[{"id":19568,"web_url":"https://patchwork.libcamera.org/comment/19568/","msgid":"","date":"2021-09-09T08:33:05","subject":"Re: [libcamera-devel] [PATCH v3 3/7] libcamera: v4l2_pixelformat:\n\tAdd entries for NV24 and NV42","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Paul,\n\nOn 09/09/2021 10:08, Paul Elder wrote:\n> The entries for NV24 and NV42 were missing from the V4L2PixelFormat map.\n> Add them.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> src/libcamera/v4l2_pixelformat.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 795da771..2c8167a7 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -97,6 +97,10 @@ const std::map vpf2pf{\n> \t\t{ formats::NV21, \"Y/CrCb 4:2:0\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_NV21M),\n> \t\t{ formats::NV21, \"Y/CrCb 4:2:0 (N-C)\" } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_NV24),\n> +\t\t{ formats::NV24, \"Y/CbCr 4:4:4\" } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_NV42),\n> +\t\t{ formats::NV42, \"Y/CrCb 4:4:4\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV420),\n> \t\t{ formats::YUV420, \"Planar YUV 4:2:0\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV420M),\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23EFDBDC71\n\tfor ;\n\tThu, 9 Sep 2021 08:33:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E88DC6916E;\n\tThu, 9 Sep 2021 10:33:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 774606024E\n\tfor ;\n\tThu, 9 Sep 2021 10:33:08 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ab35:be36:579e:39cf])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 30D24466;\n\tThu, 9 Sep 2021 10:33:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"G4z4QzhN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631176388;\n\tbh=BkCNDFHU1Hb7MahI17yoctCwBbgWPqfBnru12Fnli4g=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=G4z4QzhNnzbGhCS8PddC99JRDIHyCX4n2BMbnf0gsQpqchsM8mfi8Sfrer74Rgp8O\n\tF6OataNpmQTGw2kyXbCVmHEmVyfOylWEA1J3MXtDJzkToR+JmzbT6BhQfGKgExUyT5\n\tZaLZM+Z/kaJmA3328UBzOYyfy1F3Y15stQxX0XTE=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210909080902.239533-1-paul.elder@ideasonboard.com>\n\t<20210909080902.239533-4-paul.elder@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Thu, 9 Sep 2021 10:33:05 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<20210909080902.239533-4-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 3/7] libcamera: v4l2_pixelformat:\n\tAdd entries for NV24 and NV42","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]