{"id":13772,"url":"https://patchwork.libcamera.org/api/patches/13772/?format=json","web_url":"https://patchwork.libcamera.org/patch/13772/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210909080902.239533-2-paul.elder@ideasonboard.com>","date":"2021-09-09T08:08:56","name":"[libcamera-devel,v3,1/7] v4l2: v4l2_compat_manager: Don't print \"camera not found\" on openat()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9ecb60fefe56d4f4a229e415b0f400827d2db82e","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13772/mbox/","series":[{"id":2502,"url":"https://patchwork.libcamera.org/api/series/2502/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2502","date":"2021-09-09T08:08:55","name":"v4l2-compat fixes","version":3,"mbox":"https://patchwork.libcamera.org/series/2502/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13772/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13772/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1646BDC71\n\tfor ;\n\tThu, 9 Sep 2021 08:09:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89CAD69171;\n\tThu, 9 Sep 2021 10:09:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C81CD6916D\n\tfor ;\n\tThu, 9 Sep 2021 10:09:15 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EEBA24F;\n\tThu, 9 Sep 2021 10:09:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YZ2XX2Gv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631174955;\n\tbh=DW9K8R8YTP+/gWwo8ixKVrgrVReTM+8xpTr5DL/4DIA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YZ2XX2Gv7jRmGntY3ba1hE9/JqbhMs+3TvV1zCHfY8R0dlAPM72Wix08iRX1UjQrV\n\tyJt0UWfe7iAPmF69hKogP8nPbi5ADyCFHnT20N1NBdbaNmKlnL1dlKD2hyCWDsgDur\n\thWCtsvJbknB/Gs2eED2iwtYJUi7kLqUL5PWl6joI=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 9 Sep 2021 17:08:56 +0900","Message-Id":"<20210909080902.239533-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210909080902.239533-1-paul.elder@ideasonboard.com>","References":"<20210909080902.239533-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/7] v4l2: v4l2_compat_manager: Don't\n\tprint \"camera not found\" on openat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Some applications (like Firefox) run open() many times on video device\nnodes. This may lead to user confusion when they see \"INFO V4L2Compat\nv4l2_compat_manager.cpp:146 No camera found for /dev/videoX\" over and\nover again.\n\nLower the log level to debug so that we can still get this information\non debug, and so users won't see it all the time.\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/v4l2/v4l2_compat_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\nindex e566125a..690a191f 100644\n--- a/src/v4l2/v4l2_compat_manager.cpp\n+++ b/src/v4l2/v4l2_compat_manager.cpp\n@@ -143,7 +143,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod\n \n \tret = getCameraIndex(fd);\n \tif (ret < 0) {\n-\t\tLOG(V4L2Compat, Info) << \"No camera found for \" << path;\n+\t\tLOG(V4L2Compat, Debug) << \"No camera found for \" << path;\n \t\treturn fd;\n \t}\n \n","prefixes":["libcamera-devel","v3","1/7"]}