[{"id":19540,"web_url":"https://patchwork.libcamera.org/comment/19540/","msgid":"","date":"2021-09-08T09:24:07","subject":"Re: [libcamera-devel] [PATCH v2 6/7] v4l2: v4l2_camera_proxy: Set\n\tthe compressed flag in enum_fmt","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Sep 08, 2021 at 05:14:36PM +0900, Paul Elder wrote:\n> Set the compressed flag in ENUM_FMT if the format is MJPEG. As the only\n> compressed format that libcamera currently supports is MJPEG, this\n> should be sufficient.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 5fbfcdd7..9de94fa1 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -276,8 +276,7 @@ int V4L2CameraProxy::vidioc_enum_fmt(V4L2CameraFile *file, struct v4l2_fmtdesc *\n> \tPixelFormat format = streamConfig_.formats().pixelformats()[arg->index];\n> \tconst V4L2PixelFormat &v4l2Format = V4L2PixelFormat::fromPixelFormat(format);\n> \n> -\t/* \\todo Set V4L2_FMT_FLAG_COMPRESSED for compressed formats. */\n> -\targ->flags = 0;\n> +\targ->flags = format == formats::MJPEG ? V4L2_FMT_FLAG_COMPRESSED : 0;\n> \tutils::strlcpy(reinterpret_cast(arg->description),\n> \t\t v4l2Format.toDescription(), sizeof(arg->description));\n> \targ->pixelformat = v4l2Format;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A52DBDB1D\n\tfor ;\n\tWed, 8 Sep 2021 09:24:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E63F76916E;\n\tWed, 8 Sep 2021 11:24:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB6036024D\n\tfor ;\n\tWed, 8 Sep 2021 11:24:27 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D615993;\n\tWed, 8 Sep 2021 11:24:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Wk0X25Et\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631093067;\n\tbh=09irf9W4J+UkGCBKPqPPK9b9nk8TzRpNLpQcOdBFPOM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Wk0X25EtsOKPe0qAMZikRoAUWGEcm/HxqQUa73PaMQIFuo1ERbGpcRMBPEneDQBc3\n\tfUaLZ5hbL4kWTrO2TP7NCBMRIL+X+YXjFEPaY3Sz7R1Pjf83AiQUrc9EARo+jmmLNH\n\tS2yP84q8bpq4wIv5f7kuX1AF4X0XdwY8oTUmblu8=","Date":"Wed, 8 Sep 2021 12:24:07 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210908081437.4022697-1-paul.elder@ideasonboard.com>\n\t<20210908081437.4022697-7-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210908081437.4022697-7-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 6/7] v4l2: v4l2_camera_proxy: Set\n\tthe compressed flag in enum_fmt","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]