[{"id":19542,"web_url":"https://patchwork.libcamera.org/comment/19542/","msgid":"","date":"2021-09-08T09:26:18","subject":"Re: [libcamera-devel] [PATCH v2 3/7] libcamera: v4l2_pixelformat:\n\tAdd entries for NV24 and NV42","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Sep 08, 2021 at 05:14:33PM +0900, Paul Elder wrote:\n> The entries for NV24 and NV42 were missing from the V4L2PixelFormat map.\n> Add them.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_pixelformat.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index e0956442..0a8312c4 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -97,6 +97,10 @@ const std::map vpf2pf{\n> \t\t{ formats::NV21, \"Y/CrCb 4:2:0\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_NV21M),\n> \t\t{ formats::NV21, \"Y/CrCb 4:2:0 (N-C)\" } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_NV24),\n> +\t\t{ formats::NV24, \"Y/CbCr 4:4:4\" } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_NV42),\n> +\t\t{ formats::NV42, \"Y/CrCb 4:4:4\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV420),\n> \t\t{ formats::YUV420, \"Planar YUV 4:2:0\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV420M),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9078BBDB1D\n\tfor ;\n\tWed, 8 Sep 2021 09:26:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5075D69170;\n\tWed, 8 Sep 2021 11:26:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67A7F60250\n\tfor ;\n\tWed, 8 Sep 2021 11:26:38 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F236E993;\n\tWed, 8 Sep 2021 11:26:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e9CREN4P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631093198;\n\tbh=bggjLDmJCO/wilN2ngsKlsV0KFeo9Ml4FZk2d/I3bGY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e9CREN4PSi6ysQ8G8tRXPbZYljvxg2Zer6jt+4CllV8J23l/unNNXod8JhZP+86DR\n\tND+a1fPkupIaZTUlHrOvAyJZTaGC3zX0UAHtEYuiUNWUxAXA6tSZowq9g1IaAc8NdW\n\tHeWCyrTHYQGftX++lVNKc5GHRjeVP/4K18m4Fois=","Date":"Wed, 8 Sep 2021 12:26:18 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210908081437.4022697-1-paul.elder@ideasonboard.com>\n\t<20210908081437.4022697-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210908081437.4022697-4-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/7] libcamera: v4l2_pixelformat:\n\tAdd entries for NV24 and NV42","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]