[{"id":1786,"web_url":"https://patchwork.libcamera.org/comment/1786/","msgid":"<20190607160514.GR7593@pendragon.ideasonboard.com>","date":"2019-06-07T16:05:14","subject":"Re: [libcamera-devel] [RFC PATCH 4/5] QCam: Set a read control on\n\teach request to get Gain value","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Jun 06, 2019 at 09:56:53PM +0100, Kieran Bingham wrote:\n> ---\n> src/qcam/main_window.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index c0ab865b46ff..8dbe597e7aa2 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -210,6 +210,10 @@ int MainWindow::startCapture()\n> \t}\n> \n> \tfor (Request *request : requests) {\n> +\n> +\t\t/* Add a read request for ManualGain */\n> +\t\trequest->controls().emplace(ManualBrightness);\n> +\n\nI had envisioned that libcamera would report all control values\nunconditionally. I'd like to discuss the pros and cons of specifying\nthem explicitly. I wonder in particular if applications won't just end\nup adding all possible controls, which would defeat the purpose.\n\n> \t\tret = camera_->queueRequest(request);\n> \t\tif (ret < 0) {\n> \t\t\tstd::cerr << \"Can't queue request\" << std::endl;\n> @@ -266,12 +270,18 @@ void MainWindow::requestComplete(Request *request,\n> \n> \tdisplay(buffer);\n> \n> +\t/* Parse completed controls */\n> +\tfor (Control c : request->controls())\n> +\t\tstd::cout << c << std::endl;\n> +\n> +\t/* Create a new request */\n> \trequest = camera_->createRequest();\n> \tif (!request) {\n> \t\tstd::cerr << \"Can't create request\" << std::endl;\n> \t\treturn;\n> \t}\n> \n> +\n> \trequest->setBuffers(buffers);\n> \tcamera_->queueRequest(request);\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A347269F92\n\tfor ;\n\tFri, 7 Jun 2019 18:05:29 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a02:a03f:44f0:8500:ca05:8177:199c:fed4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23DBD334;\n\tFri, 7 Jun 2019 18:05:29 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559923529;\n\tbh=f7qyNdv3cERq1Vd7m3jCbgtNSoX8GGO6Gn8gp2l9cus=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=waC5jz+VxMe0zUSuA+W76jeKNJNWkjEL9NwFfHbum4kRGYfkbR0XVnLRZaum4iIU8\n\tOMXQXUbonHVCFTuVhfMUE8Kbev06rbIkyYH5Aox6pVUqzg5jTizLFYxgBG0tqyN66a\n\tT1dI6mDo9CFJYgad5nCTQD78WZZ83RzWIg+TweJQ=","Date":"Fri, 7 Jun 2019 19:05:14 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190607160514.GR7593@pendragon.ideasonboard.com>","References":"<20190606205654.9311-1-kieran.bingham@ideasonboard.com>\n\t<20190606205654.9311-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190606205654.9311-5-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC PATCH 4/5] QCam: Set a read control on\n\teach request to get Gain value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 07 Jun 2019 16:05:29 -0000"}}]