[{"id":19543,"web_url":"https://patchwork.libcamera.org/comment/19543/","msgid":"<44e10706-70f6-9aa1-1db4-767acdb62c49@ideasonboard.com>","date":"2021-09-08T09:27:38","subject":"Re: [libcamera-devel] [PATCH v2 16/17] Revert \"android:\n\tcapabilities: Cap frame rate to 30 FPS\"","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 07/09/2021 21:41, Jacopo Mondi wrote:\n> This reverts commit 257df463ad0e0862c211b03742140a99dd8cc0ef.\n\nIs it intended ? Looks like you missed a squash ?\n\n> ---\n> src/android/camera_capabilities.cpp | 23 -----------------------\n> 1 file changed, 23 deletions(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index cff1e30a9567..deaec3282fd7 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -632,29 +632,6 @@ int CameraCapabilities::initializeStreamConfigurations()\n> \n> \t\t\tint64_t minFrameDuration = frameDurations->second.min().get() * 1000;\n> \t\t\tint64_t maxFrameDuration = frameDurations->second.max().get() * 1000;\n> -\n> -\t\t\t/*\n> -\t\t\t * Cap min frame duration to 30 FPS.\n> -\t\t\t *\n> -\t\t\t * 30 frames per second has been validated as the most\n> -\t\t\t * opportune frame rate for quality tuning, and power\n> -\t\t\t * vs performances budget on Intel IPU3.\n> -\t\t\t *\n> -\t\t\t * \\todo This is a platform-specific decision that needs\n> -\t\t\t * to be abstracted and delegated to the configuration\n> -\t\t\t * file.\n> -\t\t\t *\n> -\t\t\t * \\todo libcamera only allows to control frame duration\n> -\t\t\t * through the per-request controls::FrameDuration\n> -\t\t\t * control. If we cap the durations here, we should be\n> -\t\t\t * capable of configuring the camera to operate at such\n> -\t\t\t * duration without requiring to have the FrameDuration\n> -\t\t\t * control to be specified for each Request. Defer this\n> -\t\t\t * to the in-development configuration API rework.\n> -\t\t\t */\n> -\t\t\tif (minFrameDuration < 1e9 / 30.0)\n> -\t\t\t\tminFrameDuration = 1e9 / 30.0;\n> -\n> \t\t\tstreamConfigurations_.push_back({\n> \t\t\t\tres, androidFormat, minFrameDuration, maxFrameDuration,\n> \t\t\t});\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CBDBBDB1D\n\tfor ;\n\tWed, 8 Sep 2021 09:27:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1C0969170;\n\tWed, 8 Sep 2021 11:27:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 068F76024D\n\tfor ;\n\tWed, 8 Sep 2021 11:27:41 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:1ff4:3000:cbce:eabb])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ABAC2993;\n\tWed, 8 Sep 2021 11:27:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sOrViT/E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631093260;\n\tbh=ihxL+yYiTFyTRG1/m/droW8fDWoX/3FyMhJCq7txY28=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=sOrViT/Ef0LbEe+2U6JhHp9wpHjTKzl75BsTeYCtS+hcQEq8PTkJodNi0jRPlIueE\n\t4PKvxYsrg7a+CyEumhalpzHtQSWhOy6c7hio18S92g9LXCGlfjaN3V6mnzUY3n5n+K\n\t8PaPrtYGLPYqCz3OO+rhqb48s3Vr8hwChRl67xE0=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210907194107.803730-1-jacopo@jmondi.org>\n\t<20210907194107.803730-17-jacopo@jmondi.org>","From":"Jean-Michel Hautbois ","Message-ID":"<44e10706-70f6-9aa1-1db4-767acdb62c49@ideasonboard.com>","Date":"Wed, 8 Sep 2021 11:27:38 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<20210907194107.803730-17-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 16/17] Revert \"android:\n\tcapabilities: Cap frame rate to 30 FPS\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19548,"web_url":"https://patchwork.libcamera.org/comment/19548/","msgid":"<20210908100550.3su5bn6p2nm3dpbq@uno.localdomain>","date":"2021-09-08T10:05:50","subject":"Re: [libcamera-devel] [PATCH v2 16/17] Revert \"android:\n\tcapabilities: Cap frame rate to 30 FPS\"","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Jean-Michel\n\nOn Wed, Sep 08, 2021 at 11:27:38AM +0200, Jean-Michel Hautbois wrote:\n> Hi Jacopo,\n>\n> On 07/09/2021 21:41, Jacopo Mondi wrote:\n> > This reverts commit 257df463ad0e0862c211b03742140a99dd8cc0ef.\n>\n> Is it intended ? Looks like you missed a squash ?\n\nYes :) it's intended, see the cover letter!\n>\n> > ---\n> > src/android/camera_capabilities.cpp | 23 -----------------------\n> > 1 file changed, 23 deletions(-)\n> >\n> > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > index cff1e30a9567..deaec3282fd7 100644\n> > --- a/src/android/camera_capabilities.cpp\n> > +++ b/src/android/camera_capabilities.cpp\n> > @@ -632,29 +632,6 @@ int CameraCapabilities::initializeStreamConfigurations()\n> >\n> > \t\t\tint64_t minFrameDuration = frameDurations->second.min().get() * 1000;\n> > \t\t\tint64_t maxFrameDuration = frameDurations->second.max().get() * 1000;\n> > -\n> > -\t\t\t/*\n> > -\t\t\t * Cap min frame duration to 30 FPS.\n> > -\t\t\t *\n> > -\t\t\t * 30 frames per second has been validated as the most\n> > -\t\t\t * opportune frame rate for quality tuning, and power\n> > -\t\t\t * vs performances budget on Intel IPU3.\n> > -\t\t\t *\n> > -\t\t\t * \\todo This is a platform-specific decision that needs\n> > -\t\t\t * to be abstracted and delegated to the configuration\n> > -\t\t\t * file.\n> > -\t\t\t *\n> > -\t\t\t * \\todo libcamera only allows to control frame duration\n> > -\t\t\t * through the per-request controls::FrameDuration\n> > -\t\t\t * control. If we cap the durations here, we should be\n> > -\t\t\t * capable of configuring the camera to operate at such\n> > -\t\t\t * duration without requiring to have the FrameDuration\n> > -\t\t\t * control to be specified for each Request. Defer this\n> > -\t\t\t * to the in-development configuration API rework.\n> > -\t\t\t */\n> > -\t\t\tif (minFrameDuration < 1e9 / 30.0)\n> > -\t\t\t\tminFrameDuration = 1e9 / 30.0;\n> > -\n> > \t\t\tstreamConfigurations_.push_back({\n> > \t\t\t\tres, androidFormat, minFrameDuration, maxFrameDuration,\n> > \t\t\t});\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13A8CBDB1D\n\tfor ;\n\tWed, 8 Sep 2021 10:05:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 934BD6916E;\n\tWed, 8 Sep 2021 12:05:06 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 482C560503\n\tfor ;\n\tWed, 8 Sep 2021 12:05:05 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id AEA8420011;\n\tWed, 8 Sep 2021 10:05:04 +0000 (UTC)"],"Date":"Wed, 8 Sep 2021 12:05:50 +0200","From":"Jacopo Mondi ","To":"Jean-Michel Hautbois ","Message-ID":"<20210908100550.3su5bn6p2nm3dpbq@uno.localdomain>","References":"<20210907194107.803730-1-jacopo@jmondi.org>\n\t<20210907194107.803730-17-jacopo@jmondi.org>\n\t<44e10706-70f6-9aa1-1db4-767acdb62c49@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<44e10706-70f6-9aa1-1db4-767acdb62c49@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 16/17] Revert \"android:\n\tcapabilities: Cap frame rate to 30 FPS\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]