[{"id":20084,"web_url":"https://patchwork.libcamera.org/comment/20084/","msgid":"","date":"2021-10-06T01:48:18","subject":"Re: [libcamera-devel] [PATCH v2 13/17] android: Populate streams\n\tand duration in the same loop","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Sep 07, 2021 at 09:41:03PM +0200, Jacopo Mondi wrote:\n> The ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS and\n> ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS static metadata are\n\ns/ / /\n\n> populated by looping on the streamConfigurations_ vector.\n> \n> Unify them in a single loop to avoid repeating it.\n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Paul Elder \n> Reviewed-by: Umang Jain \n> ---\n> src/android/camera_capabilities.cpp | 23 ++++++++++-------------\n> 1 file changed, 10 insertions(+), 13 deletions(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index ba800b545b9d..194ede866806 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1257,7 +1257,9 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t\t\t\t maxZoom);\n> \n> \tstd::vector availableStreamConfigurations;\n> +\tstd::vector minFrameDurations;\n> \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> +\tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> \t\t/*\n> \t\t * Filter out YUV streams not capable of running at 30 FPS.\n> @@ -1274,12 +1276,19 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> \t\t\tcontinue;\n> \n> +\t\t/* Stream configuration map. */\n> \t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> \t\tavailableStreamConfigurations.push_back(\n> \t\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT);\n> \n> +\t\t/* Per-stream durations. */\n> +\t\tminFrameDurations.push_back(entry.androidFormat);\n> +\t\tminFrameDurations.push_back(entry.resolution.width);\n> +\t\tminFrameDurations.push_back(entry.resolution.height);\n> +\t\tminFrameDurations.push_back(entry.minFrameDurationNsec);\n> +\n> \t\tLOG(HAL, Debug)\n> \t\t\t<< \"Output Stream: \" << utils::hex(entry.androidFormat)\n> \t\t\t<< \" (\" << entry.resolution.width << \"x\"\n> @@ -1287,22 +1296,10 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t\t\t<< entry.minFrameDurationNsec << \"]\"\n> \t\t\t<< \"@\" << fps;\n> \t}\n> +\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> \t\t\t\t availableStreamConfigurations);\n> \n\nI would have dropped this blank line.\n\nReviewed-by: Laurent Pinchart \n\n> -\tstd::vector minFrameDurations;\n> -\tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> -\tfor (const auto &entry : streamConfigurations_) {\n> -\t\tunsigned int fps = static_cast\n> -\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n> -\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> -\t\t\tcontinue;\n> -\n> -\t\tminFrameDurations.push_back(entry.androidFormat);\n> -\t\tminFrameDurations.push_back(entry.resolution.width);\n> -\t\tminFrameDurations.push_back(entry.resolution.height);\n> -\t\tminFrameDurations.push_back(entry.minFrameDurationNsec);\n> -\t}\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n> \t\t\t\t minFrameDurations);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CA1DBDC71\n\tfor ;\n\tWed, 6 Oct 2021 01:48:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 512A1691BC;\n\tWed, 6 Oct 2021 03:48:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96A4E6012B\n\tfor ;\n\tWed, 6 Oct 2021 03:48:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E6AB581;\n\tWed, 6 Oct 2021 03:48:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HyXePHwd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633484906;\n\tbh=EiauFtaW6cK3JE+7VJIb8G2CMACI6ZdHXFAp2wnvPCQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HyXePHwd8cz1gnKMuow3EMnyvlA8IRMcUPQuoBKWk7l/v2ARx9eIDdjYxugEHjsWe\n\tvVgIIRPERa4AVaZBvCYAOx8CCRRNEJflsiTKGFrymecxRfy/HYiGaXhprrbajAMLfL\n\twsAToCqQo/onasi5/2k6JpLqYBqDgiqKbgMnsn9w=","Date":"Wed, 6 Oct 2021 04:48:18 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210907194107.803730-1-jacopo@jmondi.org>\n\t<20210907194107.803730-14-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210907194107.803730-14-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 13/17] android: Populate streams\n\tand duration in the same loop","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]