[{"id":20083,"web_url":"https://patchwork.libcamera.org/comment/20083/","msgid":"","date":"2021-10-06T01:46:49","subject":"Re: [libcamera-devel] [PATCH v2 12/17] android: capabilities: Print\n\toutput stream list","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Sep 07, 2021 at 09:41:02PM +0200, Jacopo Mondi wrote:\n> Add a debug statement to print out the list of collected output stream\n> and their characteristics.\n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Paul Elder \n> Reviewed-by: Umang Jain \n> ---\n> src/android/camera_capabilities.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index e5cfe67f9b73..ba800b545b9d 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1279,6 +1279,13 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> \t\tavailableStreamConfigurations.push_back(\n> \t\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT);\n> +\n> +\t\tLOG(HAL, Debug)\n> +\t\t\t<< \"Output Stream: \" << utils::hex(entry.androidFormat)\n> +\t\t\t<< \" (\" << entry.resolution.width << \"x\"\n> +\t\t\t<< entry.resolution.height << \")[\"\n\nYou can use entry.resolution.toString() instead of open-coding it.\n\nReviewed-by: Laurent Pinchart \n\n> +\t\t\t<< entry.minFrameDurationNsec << \"]\"\n> +\t\t\t<< \"@\" << fps;\n> \t}\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> \t\t\t\t availableStreamConfigurations);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E34E9C3243\n\tfor ;\n\tWed, 6 Oct 2021 01:46:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4B12691B6;\n\tWed, 6 Oct 2021 03:46:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FE30602DC\n\tfor ;\n\tWed, 6 Oct 2021 03:46:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E8D6F581;\n\tWed, 6 Oct 2021 03:46:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q6hsDWLq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633484817;\n\tbh=dLMyA3VZ9v41p/DFn5MB4QsjsF52RJXqHeBln54fbzQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q6hsDWLq5gjJLZpBktTX63Nk46O2nUI5oJndcdk+3ryVT4+CcaB4U93uGp63VFAzG\n\t3TyoAW4dqhXJLV1Q1UzxZNpkDj+h2dL69fyI+k49jIkttZk1UiQ4l3oY4ovB2MMa6Q\n\tI7eFOHvmo+H+Obaw2XOM7pJ5nCFN6jw5+45FJt9M=","Date":"Wed, 6 Oct 2021 04:46:49 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210907194107.803730-1-jacopo@jmondi.org>\n\t<20210907194107.803730-13-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210907194107.803730-13-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 12/17] android: capabilities: Print\n\toutput stream list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]