[{"id":20082,"web_url":"https://patchwork.libcamera.org/comment/20082/","msgid":"","date":"2021-10-06T01:45:25","subject":"Re: [libcamera-devel] [PATCH v2 11/17] android: Filter preview\n\tstreams on FPS","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Sep 07, 2021 at 09:41:01PM +0200, Jacopo Mondi wrote:\n> Register as preview streams only streams capable of producing at least\n> 30 FPS.\n> \n> This requirement comes from inspecting the existing HAL implementation\n> on Intel IPU3 platform.\n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Paul Elder \n> Reviewed-by: Umang Jain \n> ---\n> src/android/camera_capabilities.cpp | 20 ++++++++++++++++++++\n> 1 file changed, 20 insertions(+)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index c6791b9d6238..e5cfe67f9b73 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1259,6 +1259,21 @@ int CameraCapabilities::initializeStaticMetadata()\n> \tstd::vector availableStreamConfigurations;\n> \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> +\t\t/*\n> +\t\t * Filter out YUV streams not capable of running at 30 FPS.\n> +\t\t *\n> +\t\t * This requirement comes from inspecting the Intel IPU3\n> +\t\t * HAL implementation but no reference has been found in the\n> +\t\t * metadata documentation.\n\nDoes the requirement also come from CTS ? If so, could you please point\nto the corresponding test(s) ? If not, why do we need this ?\n\n> +\t\t *\n> +\t\t * Calculate FPS as CTS does: see\n> +\t\t * Camera2SurfaceViewTestCase.java:getSuitableFpsRangeForDuration()\n> +\t\t */\n> +\t\tunsigned int fps = static_cast\n> +\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n> +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> +\t\t\tcontinue;\n> +\n> \t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> @@ -1271,6 +1286,11 @@ int CameraCapabilities::initializeStaticMetadata()\n> \tstd::vector minFrameDurations;\n> \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> +\t\tunsigned int fps = static_cast\n> +\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n> +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> +\t\t\tcontinue;\n> +\n> \t\tminFrameDurations.push_back(entry.androidFormat);\n> \t\tminFrameDurations.push_back(entry.resolution.width);\n> \t\tminFrameDurations.push_back(entry.resolution.height);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 874B6C3243\n\tfor ;\n\tWed, 6 Oct 2021 01:45:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B23AD691BC;\n\tWed, 6 Oct 2021 03:45:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3078F602DC\n\tfor ;\n\tWed, 6 Oct 2021 03:45:33 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9CB41581;\n\tWed, 6 Oct 2021 03:45:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Mbguj9Jm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633484732;\n\tbh=TI/xyyIr7TnkHIRf4TBpIYOv+cH6AbUgG5QwUobP5nU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Mbguj9Jm/u+u95FGqdEgFTb8dIVu/luKkVBb24K2sdFNZkqABBbS1zyi9vgN62wE0\n\tIyoQbLtw8PXk3SyvgWtOZSWtrOddKM9iFTwbjHSOzr2bzNazhKRJeznBtfAVHnf+t+\n\tLtauQRNLiM9OgKhitOH99W7YXSSMC3UWWVLwMJXg=","Date":"Wed, 6 Oct 2021 04:45:25 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210907194107.803730-1-jacopo@jmondi.org>\n\t<20210907194107.803730-12-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210907194107.803730-12-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 11/17] android: Filter preview\n\tstreams on FPS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20091,"web_url":"https://patchwork.libcamera.org/comment/20091/","msgid":"<20211006082300.5ffhwkxnzero6fbc@uno.localdomain>","date":"2021-10-06T08:23:00","subject":"Re: [libcamera-devel] [PATCH v2 11/17] android: Filter preview\n\tstreams on FPS","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Oct 06, 2021 at 04:45:25AM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Tue, Sep 07, 2021 at 09:41:01PM +0200, Jacopo Mondi wrote:\n> > Register as preview streams only streams capable of producing at least\n> > 30 FPS.\n> >\n> > This requirement comes from inspecting the existing HAL implementation\n> > on Intel IPU3 platform.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > Reviewed-by: Paul Elder \n> > Reviewed-by: Umang Jain \n> > ---\n> > src/android/camera_capabilities.cpp | 20 ++++++++++++++++++++\n> > 1 file changed, 20 insertions(+)\n> >\n> > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > index c6791b9d6238..e5cfe67f9b73 100644\n> > --- a/src/android/camera_capabilities.cpp\n> > +++ b/src/android/camera_capabilities.cpp\n> > @@ -1259,6 +1259,21 @@ int CameraCapabilities::initializeStaticMetadata()\n> > \tstd::vector availableStreamConfigurations;\n> > \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> > \tfor (const auto &entry : streamConfigurations_) {\n> > +\t\t/*\n> > +\t\t * Filter out YUV streams not capable of running at 30 FPS.\n> > +\t\t *\n> > +\t\t * This requirement comes from inspecting the Intel IPU3\n> > +\t\t * HAL implementation but no reference has been found in the\n> > +\t\t * metadata documentation.\n>\n> Does the requirement also come from CTS ? If so, could you please point\n> to the corresponding test(s) ? If not, why do we need this ?\n>\n\nI keep failing to find any reference to this requirement in\ndocumentation, and the way we populate the YUV stream combinations has\nan impact on the AE_AVAILABLE_TARGET_FPS_RANGE content as\n\nandroid.control.aeAvailableTargetFpsRanges:\nFor devices at the LIMITED level or above:\nFor YUV_420_888 burst capture use case, this list will always include\n(min, max) and (max, max) where min <= 15 and max = the maximum output\nframe rate of the maximum YUV_420_888 output size.\n\nI think I do now populate AE_AVAILABLE_TARGET_FPS_RANGE correctly\nsince \"android: capabilties: Fix ANDROID_CONTROL_AE_AVAILABLE_TARGET_FPS_RANGES\"\nin this series.\n\nI'll try to revert this patch and add here a reference to which tests\nis not pleased\n\nThanks\n j\n\n> > +\t\t *\n> > +\t\t * Calculate FPS as CTS does: see\n> > +\t\t * Camera2SurfaceViewTestCase.java:getSuitableFpsRangeForDuration()\n> > +\t\t */\n> > +\t\tunsigned int fps = static_cast\n> > +\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n> > +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> > +\t\t\tcontinue;\n> > +\n> > \t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n> > \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n> > \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> > @@ -1271,6 +1286,11 @@ int CameraCapabilities::initializeStaticMetadata()\n> > \tstd::vector minFrameDurations;\n> > \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> > \tfor (const auto &entry : streamConfigurations_) {\n> > +\t\tunsigned int fps = static_cast\n> > +\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n> > +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> > +\t\t\tcontinue;\n> > +\n> > \t\tminFrameDurations.push_back(entry.androidFormat);\n> > \t\tminFrameDurations.push_back(entry.resolution.width);\n> > \t\tminFrameDurations.push_back(entry.resolution.height);\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D347FC323E\n\tfor ;\n\tWed, 6 Oct 2021 08:22:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E419691B6;\n\tWed, 6 Oct 2021 10:22:15 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4601691AB\n\tfor ;\n\tWed, 6 Oct 2021 10:22:13 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 56B82240006;\n\tWed, 6 Oct 2021 08:22:13 +0000 (UTC)"],"Date":"Wed, 6 Oct 2021 10:23:00 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20211006082300.5ffhwkxnzero6fbc@uno.localdomain>","References":"<20210907194107.803730-1-jacopo@jmondi.org>\n\t<20210907194107.803730-12-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 11/17] android: Filter preview\n\tstreams on FPS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20113,"web_url":"https://patchwork.libcamera.org/comment/20113/","msgid":"<20211011134934.ula6zn2m7b66rxox@uno.localdomain>","date":"2021-10-11T13:49:34","subject":"Re: [libcamera-devel] [PATCH v2 11/17] android: Filter preview\n\tstreams on FPS","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Oct 06, 2021 at 10:23:00AM +0200, Jacopo Mondi wrote:\n> Hi Laurent,\n>\n> On Wed, Oct 06, 2021 at 04:45:25AM +0300, Laurent Pinchart wrote:\n> > Hi Jacopo,\n> >\n> > Thank you for the patch.\n> >\n> > On Tue, Sep 07, 2021 at 09:41:01PM +0200, Jacopo Mondi wrote:\n> > > Register as preview streams only streams capable of producing at least\n> > > 30 FPS.\n> > >\n> > > This requirement comes from inspecting the existing HAL implementation\n> > > on Intel IPU3 platform.\n> > >\n> > > Signed-off-by: Jacopo Mondi \n> > > Reviewed-by: Paul Elder \n> > > Reviewed-by: Umang Jain \n> > > ---\n> > > src/android/camera_capabilities.cpp | 20 ++++++++++++++++++++\n> > > 1 file changed, 20 insertions(+)\n> > >\n> > > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > > index c6791b9d6238..e5cfe67f9b73 100644\n> > > --- a/src/android/camera_capabilities.cpp\n> > > +++ b/src/android/camera_capabilities.cpp\n> > > @@ -1259,6 +1259,21 @@ int CameraCapabilities::initializeStaticMetadata()\n> > > \tstd::vector availableStreamConfigurations;\n> > > \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> > > \tfor (const auto &entry : streamConfigurations_) {\n> > > +\t\t/*\n> > > +\t\t * Filter out YUV streams not capable of running at 30 FPS.\n> > > +\t\t *\n> > > +\t\t * This requirement comes from inspecting the Intel IPU3\n> > > +\t\t * HAL implementation but no reference has been found in the\n> > > +\t\t * metadata documentation.\n> >\n> > Does the requirement also come from CTS ? If so, could you please point\n> > to the corresponding test(s) ? If not, why do we need this ?\n> >\n>\n> I keep failing to find any reference to this requirement in\n> documentation, and the way we populate the YUV stream combinations has\n> an impact on the AE_AVAILABLE_TARGET_FPS_RANGE content as\n>\n> android.control.aeAvailableTargetFpsRanges:\n> For devices at the LIMITED level or above:\n> For YUV_420_888 burst capture use case, this list will always include\n> (min, max) and (max, max) where min <= 15 and max = the maximum output\n> frame rate of the maximum YUV_420_888 output size.\n>\n> I think I do now populate AE_AVAILABLE_TARGET_FPS_RANGE correctly\n> since \"android: capabilties: Fix ANDROID_CONTROL_AE_AVAILABLE_TARGET_FPS_RANGES\"\n> in this series.\n>\n> I'll try to revert this patch and add here a reference to which tests\n> is not pleased\n\n10-11 15:29:33 I/ModuleListener: [75/231] android.hardware.camera2.cts.RecordingTest#testBasicRecording fail:\njunit.framework.AssertionFailedError: Frame rate range [30, 30] (for profile ID 1) must be one of the camera device available FPS range!\n\n10-11 15:30:16 I/ModuleListener: [81/231] android.hardware.camera2.cts.RecordingTest#testRecordingFramerateLowToHigh fail:\njunit.framework.AssertionFailedError: Frame rate range [30, 30] (for profile ID 1) must be one of the camera device available FPS range!\n\n10-11 15:30:18 I/ModuleListener: [82/231] android.hardware.camera2.cts.RecordingTest#testRecordingFromPersistentSurface fail:\njunit.framework.AssertionFailedError: Frame rate range [30, 30] (for profile ID 1) must be one of the camera device available FPS range!\n\n10-11 15:44:27 I/ConsoleReporter: [118/231 x86_64 CtsCameraTestCases 192.168.1.141:22] android.hardware.camera2.cts.RecordingTest#testRecordingFramerateLowToHigh fail: junit.framework.AssertionFailedError: Frame rate range [30, 30] (for profile ID 1) must be one of the camera device available FPS range!\n\n10-11 15:44:27 I/ConsoleReporter: [129/231 x86_64 CtsCameraTestCases 192.168.1.141:22] android.hardware.camera2.cts.RecordingTest#testRecordingFromPersistentSurface fail: junit.framework.AssertionFailedError: Frame rate range [30, 30] (for profile ID 1) must be one of the camera device available FPS range!\n\n10-11 15:44:27 I/ConsoleReporter: [162/231 x86_64 CtsCameraTestCases 192.168.1.141:22] android.hardware.camera2.cts.RecordingTest#testBasicRecording fail: junit.framework.AssertionFailedError: Frame rate range [30, 30] (for profile ID 1) must be one of the camera device available FPS range!\n\nSo it's basically all the recording tests ? This might be related to\nthe requirement specified in the camcoder profile (which I read about\nbut I'm not sure how is it defined in Android).\n\nI'll add that \"android.hardware.camera2.cts.RecordingTest#*\" requires\nviewfinder streams to be at 30FPS.\n\nThanks\n j\n\n>\n> Thanks\n> j\n>\n> > > +\t\t *\n> > > +\t\t * Calculate FPS as CTS does: see\n> > > +\t\t * Camera2SurfaceViewTestCase.java:getSuitableFpsRangeForDuration()\n> > > +\t\t */\n> > > +\t\tunsigned int fps = static_cast\n> > > +\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n> > > +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> > > +\t\t\tcontinue;\n> > > +\n> > > \t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n> > > \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n> > > \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> > > @@ -1271,6 +1286,11 @@ int CameraCapabilities::initializeStaticMetadata()\n> > > \tstd::vector minFrameDurations;\n> > > \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> > > \tfor (const auto &entry : streamConfigurations_) {\n> > > +\t\tunsigned int fps = static_cast\n> > > +\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n> > > +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n> > > +\t\t\tcontinue;\n> > > +\n> > > \t\tminFrameDurations.push_back(entry.androidFormat);\n> > > \t\tminFrameDurations.push_back(entry.resolution.width);\n> > > \t\tminFrameDurations.push_back(entry.resolution.height);\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A61A7C323E\n\tfor ;\n\tMon, 11 Oct 2021 13:48:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1746A68F4C;\n\tMon, 11 Oct 2021 15:48:47 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62EC96012B\n\tfor ;\n\tMon, 11 Oct 2021 15:48:45 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id BA92E100017;\n\tMon, 11 Oct 2021 13:48:44 +0000 (UTC)"],"Date":"Mon, 11 Oct 2021 15:49:34 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20211011134934.ula6zn2m7b66rxox@uno.localdomain>","References":"<20210907194107.803730-1-jacopo@jmondi.org>\n\t<20210907194107.803730-12-jacopo@jmondi.org>\n\t\n\t<20211006082300.5ffhwkxnzero6fbc@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211006082300.5ffhwkxnzero6fbc@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 11/17] android: Filter preview\n\tstreams on FPS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]