{"id":13742,"url":"https://patchwork.libcamera.org/api/patches/13742/?format=json","web_url":"https://patchwork.libcamera.org/patch/13742/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210907194107.803730-12-jacopo@jmondi.org>","date":"2021-09-07T19:41:01","name":"[libcamera-devel,v2,11/17] android: Filter preview streams on FPS","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5150519cfab667d160a1c4ecc7e1e5c912e58198","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13742/mbox/","series":[{"id":2492,"url":"https://patchwork.libcamera.org/api/series/2492/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2492","date":"2021-09-07T19:40:50","name":"IPU3 control info update and HAL frame durations","version":2,"mbox":"https://patchwork.libcamera.org/series/2492/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13742/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13742/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9DD1BDB1D\n\tfor ;\n\tTue, 7 Sep 2021 19:40:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACDD56917C;\n\tTue, 7 Sep 2021 21:40:41 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D382F6917C\n\tfor ;\n\tTue, 7 Sep 2021 21:40:37 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 17402240002;\n\tTue, 7 Sep 2021 19:40:36 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 7 Sep 2021 21:41:01 +0200","Message-Id":"<20210907194107.803730-12-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210907194107.803730-1-jacopo@jmondi.org>","References":"<20210907194107.803730-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 11/17] android: Filter preview streams\n\ton FPS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Register as preview streams only streams capable of producing at least\n30 FPS.\n\nThis requirement comes from inspecting the existing HAL implementation\non Intel IPU3 platform.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Paul Elder \nReviewed-by: Umang Jain \n---\n src/android/camera_capabilities.cpp | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex c6791b9d6238..e5cfe67f9b73 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1259,6 +1259,21 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstd::vector availableStreamConfigurations;\n \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n \tfor (const auto &entry : streamConfigurations_) {\n+\t\t/*\n+\t\t * Filter out YUV streams not capable of running at 30 FPS.\n+\t\t *\n+\t\t * This requirement comes from inspecting the Intel IPU3\n+\t\t * HAL implementation but no reference has been found in the\n+\t\t * metadata documentation.\n+\t\t *\n+\t\t * Calculate FPS as CTS does: see\n+\t\t * Camera2SurfaceViewTestCase.java:getSuitableFpsRangeForDuration()\n+\t\t */\n+\t\tunsigned int fps = static_cast\n+\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n+\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n+\t\t\tcontinue;\n+\n \t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n@@ -1271,6 +1286,11 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstd::vector minFrameDurations;\n \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n \tfor (const auto &entry : streamConfigurations_) {\n+\t\tunsigned int fps = static_cast\n+\t\t\t\t (floor(1e9 / entry.minFrameDurationNsec + 0.05f));\n+\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB && fps < 30)\n+\t\t\tcontinue;\n+\n \t\tminFrameDurations.push_back(entry.androidFormat);\n \t\tminFrameDurations.push_back(entry.resolution.width);\n \t\tminFrameDurations.push_back(entry.resolution.height);\n","prefixes":["libcamera-devel","v2","11/17"]}