[{"id":20081,"web_url":"https://patchwork.libcamera.org/comment/20081/","msgid":"","date":"2021-10-06T01:43:26","subject":"Re: [libcamera-devel] [PATCH v2 10/17] android: capabilities:\n\tCollect absolute max frame durations","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Sep 07, 2021 at 09:41:00PM +0200, Jacopo Mondi wrote:\n> While building the list of supported stream configurations also collect\n> the absolute max frame durations to be used to populate the sensor\n> maximum frame duration.\n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Paul Elder \n> Reviewed-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_capabilities.cpp | 9 ++++++---\n> src/android/camera_capabilities.h | 1 +\n> 2 files changed, 7 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 526127176678..c6791b9d6238 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -385,6 +385,7 @@ int CameraCapabilities::initialize(std::shared_ptr camera,\n> \torientation_ = orientation;\n> \tfacing_ = facing;\n> \trawStreamAvailable_ = false;\n> +\tmaxFrameDuration_ = 0;\n> \n> \t/* Acquire the camera and initialize available stream configurations. */\n> \tint ret = camera_->acquire();\n> @@ -659,6 +660,9 @@ int CameraCapabilities::initializeStreamConfigurations()\n> \t\t\t\t});\n> \t\t\t\tmaxJpegSize = std::max(maxJpegSize, res);\n> \t\t\t}\n> +\n> +\t\t\tmaxFrameDuration_ = std::max(maxFrameDuration_,\n> +\t\t\t\t\t\t maxFrameDuration);\n> \t\t}\n> \n> \t\t/*\n> @@ -1134,9 +1138,8 @@ int CameraCapabilities::initializeStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n> \t\t\t\t timestampSource);\n> \n> -\tif (maxFrameDurationNsec > 0)\n> -\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n> -\t\t\t\t\t maxFrameDurationNsec);\n> +\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n> +\t\t\t\t maxFrameDuration_);\n> \n> \t/* Statistics static metadata. */\n> \tuint8_t faceDetectMode = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;\n> diff --git a/src/android/camera_capabilities.h b/src/android/camera_capabilities.h\n> index 6e55ddab445e..2cf97ae80095 100644\n> --- a/src/android/camera_capabilities.h\n> +++ b/src/android/camera_capabilities.h\n> @@ -71,6 +71,7 @@ private:\n> \tint facing_;\n> \tint orientation_;\n> \tbool rawStreamAvailable_;\n> +\tint64_t maxFrameDuration_;\n> \tcamera_metadata_enum_android_info_supported_hardware_level hwLevel_;\n> \tstd::set capabilities_;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7662C3243\n\tfor ;\n\tWed, 6 Oct 2021 01:43:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3111C691B7;\n\tWed, 6 Oct 2021 03:43:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7D7A602DC\n\tfor ;\n\tWed, 6 Oct 2021 03:43:34 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3699D581;\n\tWed, 6 Oct 2021 03:43:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RtGNXT6F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633484614;\n\tbh=LNvYR8L2RsNE2TsEYQneJ703iUoYFy9EFmipJTjD+ME=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RtGNXT6F2W+HzVCXgp4aIkpMYaVH8BoZq+o6FsDWndfA2LD+BKLW8P05Tz2H430in\n\t5QmZAfwYZwUotNAiyN6gry80QrS0N1UqvZniTfGALmFuTKyOq+ctOZh3b9D0N66Q/w\n\tD5gkCNNK0US/+ysd8maoLQ2Wpy6oicyfv1oys1fg=","Date":"Wed, 6 Oct 2021 04:43:26 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210907194107.803730-1-jacopo@jmondi.org>\n\t<20210907194107.803730-11-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210907194107.803730-11-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 10/17] android: capabilities:\n\tCollect absolute max frame durations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]