{"id":13741,"url":"https://patchwork.libcamera.org/api/patches/13741/?format=json","web_url":"https://patchwork.libcamera.org/patch/13741/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210907194107.803730-11-jacopo@jmondi.org>","date":"2021-09-07T19:41:00","name":"[libcamera-devel,v2,10/17] android: capabilities: Collect absolute max frame durations","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0a70295f4e4a2977503e36d24750921da154e151","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13741/mbox/","series":[{"id":2492,"url":"https://patchwork.libcamera.org/api/series/2492/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2492","date":"2021-09-07T19:40:50","name":"IPU3 control info update and HAL frame durations","version":2,"mbox":"https://patchwork.libcamera.org/series/2492/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13741/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13741/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45635BDB1D\n\tfor ;\n\tTue, 7 Sep 2021 19:40:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E147C69172;\n\tTue, 7 Sep 2021 21:40:38 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBF1F60251\n\tfor ;\n\tTue, 7 Sep 2021 21:40:36 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2707D240002;\n\tTue, 7 Sep 2021 19:40:35 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 7 Sep 2021 21:41:00 +0200","Message-Id":"<20210907194107.803730-11-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210907194107.803730-1-jacopo@jmondi.org>","References":"<20210907194107.803730-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 10/17] android: capabilities: Collect\n\tabsolute max frame durations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"While building the list of supported stream configurations also collect\nthe absolute max frame durations to be used to populate the sensor\nmaximum frame duration.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Paul Elder \nReviewed-by: Umang Jain \n---\n src/android/camera_capabilities.cpp | 9 ++++++---\n src/android/camera_capabilities.h | 1 +\n 2 files changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 526127176678..c6791b9d6238 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -385,6 +385,7 @@ int CameraCapabilities::initialize(std::shared_ptr camera,\n \torientation_ = orientation;\n \tfacing_ = facing;\n \trawStreamAvailable_ = false;\n+\tmaxFrameDuration_ = 0;\n \n \t/* Acquire the camera and initialize available stream configurations. */\n \tint ret = camera_->acquire();\n@@ -659,6 +660,9 @@ int CameraCapabilities::initializeStreamConfigurations()\n \t\t\t\t});\n \t\t\t\tmaxJpegSize = std::max(maxJpegSize, res);\n \t\t\t}\n+\n+\t\t\tmaxFrameDuration_ = std::max(maxFrameDuration_,\n+\t\t\t\t\t\t maxFrameDuration);\n \t\t}\n \n \t\t/*\n@@ -1134,9 +1138,8 @@ int CameraCapabilities::initializeStaticMetadata()\n \tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n \t\t\t\t timestampSource);\n \n-\tif (maxFrameDurationNsec > 0)\n-\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n-\t\t\t\t\t maxFrameDurationNsec);\n+\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n+\t\t\t\t maxFrameDuration_);\n \n \t/* Statistics static metadata. */\n \tuint8_t faceDetectMode = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;\ndiff --git a/src/android/camera_capabilities.h b/src/android/camera_capabilities.h\nindex 6e55ddab445e..2cf97ae80095 100644\n--- a/src/android/camera_capabilities.h\n+++ b/src/android/camera_capabilities.h\n@@ -71,6 +71,7 @@ private:\n \tint facing_;\n \tint orientation_;\n \tbool rawStreamAvailable_;\n+\tint64_t maxFrameDuration_;\n \tcamera_metadata_enum_android_info_supported_hardware_level hwLevel_;\n \tstd::set capabilities_;\n \n","prefixes":["libcamera-devel","v2","10/17"]}