{"id":1374,"url":"https://patchwork.libcamera.org/api/patches/1374/?format=json","web_url":"https://patchwork.libcamera.org/patch/1374/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190606205654.9311-3-kieran.bingham@ideasonboard.com>","date":"2019-06-06T20:56:51","name":"[libcamera-devel,RFC,2/5] libcamera: request: add a control set","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5da3bd3077a91e4d74d4dfcc2563f31ae4602f8c","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1374/mbox/","series":[{"id":340,"url":"https://patchwork.libcamera.org/api/series/340/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=340","date":"2019-06-06T20:56:49","name":"Libcamera Controls","version":1,"mbox":"https://patchwork.libcamera.org/series/340/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1374/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1374/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 817C860BB7\n\tfor ;\n\tThu, 6 Jun 2019 22:56:58 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BEBCD82;\n\tThu, 6 Jun 2019 22:56:58 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559854618;\n\tbh=EOPTi+o2XngfHcaFeZdHNGmoqgxaV6QGfoDCX9Y0Lkc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FySkFZKi7Z4SL9NiryNeBSWqOscp7iUYZviOf/2PNDC9UazSIGnr8eu+Sn0v+I8BZ\n\t3jVOJq+n14p79UD762/ck+MXg7NcqhSMRx6afD18F12+2eQpW0vXS1VrWZQLha6Yki\n\tULjKZtsyq3iVxcxgeHpL5n6Iei0OX1mla/0xrU6Y=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Thu, 6 Jun 2019 21:56:51 +0100","Message-Id":"<20190606205654.9311-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190606205654.9311-1-kieran.bingham@ideasonboard.com>","References":"<20190606205654.9311-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 2/5] libcamera: request: add a control\n\tset","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 06 Jun 2019 20:56:58 -0000"},"content":"Provide a set to contain all controls applicable to the request.\nThe set contains all controls whether they are write, read, or write-read controls.\n\nSigned-off-by: Kieran Bingham \n---\n include/libcamera/request.h | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 58de6f00a554..5fae0d5fc838 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -10,6 +10,7 @@\n #include \n #include \n \n+#include \n #include \n \n namespace libcamera {\n@@ -36,6 +37,8 @@ public:\n \tint setBuffers(const std::map &streamMap);\n \tBuffer *findBuffer(Stream *stream) const;\n \n+\tstd::set &controls() { return controls_; };\n+\n \tStatus status() const { return status_; }\n \n \tbool hasPendingBuffers() const { return !pending_.empty(); }\n@@ -52,6 +55,7 @@ private:\n \tCamera *camera_;\n \tstd::map bufferMap_;\n \tstd::unordered_set pending_;\n+\tstd::set controls_;\n \n \tStatus status_;\n };\n","prefixes":["libcamera-devel","RFC","2/5"]}