[{"id":193,"web_url":"https://patchwork.libcamera.org/comment/193/","msgid":"<20190103212042.GE22790@bigcity.dyn.berto.se>","date":"2019-01-03T21:20:42","subject":"Re: [libcamera-devel] [PATCH 3/9] libcamera: device_enumerator: Fix\n\tindentation","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-01-03 03:31:04 +0200, Laurent Pinchart wrote:\n> Signed-off-by: Laurent Pinchart \n\nI did not diffed to make sure it's only indentation changes, I do \nhowever trust you :-)\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/pipeline_handler.h | 22 +++++++++++-----------\n> 1 file changed, 11 insertions(+), 11 deletions(-)\n> \n> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\n> index d70056a165fd..00568c7052c0 100644\n> --- a/src/libcamera/include/pipeline_handler.h\n> +++ b/src/libcamera/include/pipeline_handler.h\n> @@ -45,17 +45,17 @@ private:\n> };\n> \n> #define REGISTER_PIPELINE_HANDLER(handler) \\\n> -\tclass handler##Factory : public PipelineHandlerFactory { \\\n> -\tpublic: \\\n> -\t\thandler##Factory() \\\n> -\t\t{ \\\n> -\t\t\tPipelineHandlerFactory::registerType(#handler, this); \\\n> -\t\t} \\\n> -\t\tvirtual PipelineHandler *create() { \\\n> -\t\t\treturn new handler(); \\\n> -\t\t} \\\n> -\t}; \\\n> -\tstatic handler##Factory global_##handler##Factory;\n> +class handler##Factory : public PipelineHandlerFactory { \\\n> +public: \\\n> +\thandler##Factory() \\\n> +\t{ \\\n> +\t\tPipelineHandlerFactory::registerType(#handler, this); \\\n> +\t} \\\n> +\tvirtual PipelineHandler *create() { \\\n> +\t\treturn new handler(); \\\n> +\t} \\\n> +}; \\\n> +static handler##Factory global_##handler##Factory;\n> \n> } /* namespace libcamera */\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A42B060B21\n\tfor ;\n\tThu, 3 Jan 2019 22:20:44 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id v15-v6so30862663ljh.13\n\tfor ;\n\tThu, 03 Jan 2019 13:20:44 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tq2sm11454881lfa.63.2019.01.03.13.20.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 03 Jan 2019 13:20:43 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=RNu7DDJgRJuLcSSghnVZ5FxTHclagq3MgcHPWHnslTg=;\n\tb=HcazWya2V2bRWmVypwI7II03Y6b7hcBLUPFmZCXMl+yPrRcAcVJo76oNTFnFFTyZI0\n\tkCDYZS0nonh53cwPigVESBiSR5XuBKIH0DrBwKc1yJ4lwbsoYLBaKubULDwgz8HdZJvm\n\tnLkWHl6MUjiYjlOxQTAY2E5bsZ6mOj80gDC0FRUPBi0LhZfbs2Zh6EW67Yn98YcBjmCv\n\tkPG/q7TILm5kY8TlK3zPETtdTjFx4oTiwiid7TsTvJSepSq4CSOSn5p1hFnSi8Lj8yGC\n\tUSPgBiATL0YL8BeuxGI0N3XlvCl2jXGvTDaaucvY1qifc5p27zaA+G/S1Rh49vE1FLCV\n\t6VNg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=RNu7DDJgRJuLcSSghnVZ5FxTHclagq3MgcHPWHnslTg=;\n\tb=qLW6Mk93auxvMohVt8ali3t35XvwcRiS5P3nWrHemY+vFbExC7G0li5Zu4PpCTBUSW\n\tuVJSq4DHxAK+aeAIL4ulQe6iiwSkG6mlEahBJwpnOTCBe+P+y8OneRtRrhVt5FnaY9TR\n\t13P6filr6kluJfxaaO+2/56xtlZ4jhh34LfhkWi+9OPgbZljAJxm0u+7TKR65huFSN49\n\tEZVZqOCV3vOk7Rng/4K9uZLfHUHXYNH5f8yFAGSHBxTB7BsWwKXQaqDagc9tCfJBadY/\n\tQ5qsbD4QW+jyd88sPAxiRgixAfzivp/LfS2uk29P4lZqEFOvS7KF0iCAs+iaLPATj/YD\n\tvrLA==","X-Gm-Message-State":"AA+aEWZ+3rJaRs3TkRBE4vV62CPHJzqGn33I/GhEFHaFWMJ51kD4V8ie\n\t6G3NlFAk+5EVEVPnn0UVouHbKgetAPQ=","X-Google-Smtp-Source":"ALg8bN66X1/3fyfWAi53LBGbOwCMUKnLNrhBveKSQmQqZlvjfELLUmM+I20D9Tk8mXxhaJvbP0KNog==","X-Received":"by 2002:a2e:197:: with SMTP id\n\tf23-v6mr27751733lji.144.1546550443812; \n\tThu, 03 Jan 2019 13:20:43 -0800 (PST)","Date":"Thu, 3 Jan 2019 22:20:42 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190103212042.GE22790@bigcity.dyn.berto.se>","References":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>\n\t<20190103013110.6849-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190103013110.6849-3-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 3/9] libcamera: device_enumerator: Fix\n\tindentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Jan 2019 21:20:45 -0000"}}]