[{"id":19480,"web_url":"https://patchwork.libcamera.org/comment/19480/","msgid":"<1969948b-9eda-b95e-f135-1a6ecef35291@ideasonboard.com>","date":"2021-09-06T23:20:50","subject":"Re: [libcamera-devel] [PATCH v1 2/5] qcam: format_converter: Add\n\tconfigurable stride support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 07/09/2021 00:04, Laurent Pinchart wrote:\n> Make the stride configurable to support convertion of images with\n> padding at the end of lines.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/format_converter.cpp | 19 ++++++++++---------\n> src/qcam/format_converter.h | 4 +++-\n> src/qcam/viewfinder_qt.cpp | 5 ++---\n> 3 files changed, 15 insertions(+), 13 deletions(-)\n> \n> diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp\n> index 673ad33e141d..7f7ddb2dc77b 100644\n> --- a/src/qcam/format_converter.cpp\n> +++ b/src/qcam/format_converter.cpp\n> @@ -30,7 +30,7 @@\n> #endif\n> \n> int FormatConverter::configure(const libcamera::PixelFormat &format,\n> -\t\t\t const QSize &size)\n> +\t\t\t const QSize &size, unsigned int stride)\n> {\n> \tswitch (format) {\n> \tcase libcamera::formats::NV12:\n> @@ -121,22 +121,22 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,\n> \t\tbreak;\n> \n> \tcase libcamera::formats::VYUY:\n> -\t\tformatFamily_ = YUV;\n> +\t\tformatFamily_ = YUVPacked;\n\nGiven the title of the next patch, I think these may have got squashed\ninto the wrong commit?\n\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88E57BE175\n\tfor ;\n\tMon, 6 Sep 2021 23:20:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CCBFA6916A;\n\tTue, 7 Sep 2021 01:20:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E78360253\n\tfor ;\n\tTue, 7 Sep 2021 01:20:54 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7571B891;\n\tTue, 7 Sep 2021 01:20:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Odo7g/1g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630970453;\n\tbh=kDQcwNmLLV1R0Fm1D1ANfQaHm7wS5nhswVb3m0H6lqM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Odo7g/1gIn1sCNQulhP0+IJtmQHHBvuSbrz1xS+CfUM3R1AYwARewS/+94z6xYIQV\n\t5f446i+Pf0WhkiVVCkpG0v1VpsrRrDrJAkvvbtVfEVugBWSw9/APAaK9XC5VLFbJGa\n\tf1YOM7mxYPjEzydBfsE5pxmv8wOyIOeMtSfczxGM=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210906230436.17106-1-laurent.pinchart@ideasonboard.com>\n\t<20210906230436.17106-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<1969948b-9eda-b95e-f135-1a6ecef35291@ideasonboard.com>","Date":"Tue, 7 Sep 2021 00:20:50 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210906230436.17106-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v1 2/5] qcam: format_converter: Add\n\tconfigurable stride support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]