[{"id":19506,"web_url":"https://patchwork.libcamera.org/comment/19506/","msgid":"<94a94b37-0337-6bd4-c4d3-bcc16794b330@ideasonboard.com>","date":"2021-09-07T11:43:43","subject":"Re: [libcamera-devel] [PATCH v3 24/30] cam: drm: Set per-plane\n\toffsets when creating DRM frame buffer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 06/09/2021 23:56, Laurent Pinchart wrote:\n> Now that libcamera supports per-plane offsets, pass the values to\n> drmModeAddFB2().\n\nAny further implications from this?\nWill there be a specific effect? or does it just mean that DRM can\nallocate buffers for more of our formats?\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Jean-Michel Hautbois \n> ---\n> src/cam/drm.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/cam/drm.cpp b/src/cam/drm.cpp\n> index ac47b8bd3287..d5a75d039fd8 100644\n> --- a/src/cam/drm.cpp\n> +++ b/src/cam/drm.cpp\n> @@ -623,7 +623,7 @@ std::unique_ptr Device::createFrameBuffer(\n> \t\tfb->planes_.push_back({ handle });\n> \n> \t\thandles[i] = handle;\n> -\t\toffsets[i] = 0; /* TODO */\n> +\t\toffsets[i] = plane.offset;\n> \t\t++i;\n> \t}\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E96CDBE175\n\tfor ;\n\tTue, 7 Sep 2021 11:43:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A07B96916C;\n\tTue, 7 Sep 2021 13:43:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40A4060251\n\tfor ;\n\tTue, 7 Sep 2021 13:43:46 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1EC5317;\n\tTue, 7 Sep 2021 13:43:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CVtnsBqA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631015025;\n\tbh=t9TnH9zZ8V/nhgd2sFEPemdCo1LN/Z96icJhkVU4Nx8=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=CVtnsBqAvqqtfzZUaGosviJhYZMuwRIvDqKv4wGR+1FgbJyZ6yvedcAS1NOpT04NE\n\tUdgrymyXPn1L3S1buqrdC1nZSWUY+U2ggEMveS422vqY7xTgcpG5Rn1r5vjr+jnG4Q\n\tRWDj9EXD6vS3LdpaLtcEZCwi9gH0JZZ2M7Jf7Ijs=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>\n\t<20210906225636.14683-24-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<94a94b37-0337-6bd4-c4d3-bcc16794b330@ideasonboard.com>","Date":"Tue, 7 Sep 2021 12:43:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210906225636.14683-24-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 24/30] cam: drm: Set per-plane\n\toffsets when creating DRM frame buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19519,"web_url":"https://patchwork.libcamera.org/comment/19519/","msgid":"","date":"2021-09-07T14:47:31","subject":"Re: [libcamera-devel] [PATCH v3 24/30] cam: drm: Set per-plane\n\toffsets when creating DRM frame buffer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Sep 07, 2021 at 12:43:43PM +0100, Kieran Bingham wrote:\n> On 06/09/2021 23:56, Laurent Pinchart wrote:\n> > Now that libcamera supports per-plane offsets, pass the values to\n> > drmModeAddFB2().\n> \n> Any further implications from this?\n> Will there be a specific effect? or does it just mean that DRM can\n> allocate buffers for more of our formats?\n\nThere's no particular implication other than the fact that the KMS sink\nin cam is now fixed for multi-planar formats :-) Without the offset it\nwouldn't render NV12 correctly when planes are stored in the same\ndmabuf.\n\nWe still allocate buffers using the FrameBufferAllocator even when using\nthe KMS sink, so this isn't related to allocation.\n\n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > Reviewed-by: Jean-Michel Hautbois \n> > ---\n> > src/cam/drm.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/cam/drm.cpp b/src/cam/drm.cpp\n> > index ac47b8bd3287..d5a75d039fd8 100644\n> > --- a/src/cam/drm.cpp\n> > +++ b/src/cam/drm.cpp\n> > @@ -623,7 +623,7 @@ std::unique_ptr Device::createFrameBuffer(\n> > \t\tfb->planes_.push_back({ handle });\n> > \n> > \t\thandles[i] = handle;\n> > -\t\toffsets[i] = 0; /* TODO */\n> > +\t\toffsets[i] = plane.offset;\n> > \t\t++i;\n> > \t}\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14F9EBE175\n\tfor ;\n\tTue, 7 Sep 2021 14:47:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E0F460252;\n\tTue, 7 Sep 2021 16:47:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E20CD60251\n\tfor ;\n\tTue, 7 Sep 2021 16:47:50 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F14A24F;\n\tTue, 7 Sep 2021 16:47:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t79KWlUO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631026070;\n\tbh=ydo5uo4jGaPEZg8x4QxmKhMBGW2423+kGBTLFDhi9EY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=t79KWlUOZUOZ17aFXm39pBM3BP5m6HxNhhVcFc2cdWD7fpnd86wgrTLinydccF2Ry\n\tZE3ijeC+CUjLuaHUZU6KebpXo4gn7/zdGK+atxdf5ac9DjoPcejKcGsOn4EikW46wK\n\tOdCTps/iSvCqfkQ/77u1amXydu1Kec/msC5IppPw=","Date":"Tue, 7 Sep 2021 17:47:31 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>\n\t<20210906225636.14683-24-laurent.pinchart@ideasonboard.com>\n\t<94a94b37-0337-6bd4-c4d3-bcc16794b330@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<94a94b37-0337-6bd4-c4d3-bcc16794b330@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 24/30] cam: drm: Set per-plane\n\toffsets when creating DRM frame buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19522,"web_url":"https://patchwork.libcamera.org/comment/19522/","msgid":"","date":"2021-09-07T15:45:10","subject":"Re: [libcamera-devel] [PATCH v3 24/30] cam: drm: Set per-plane\n\toffsets when creating DRM frame buffer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 07/09/2021 15:47, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Tue, Sep 07, 2021 at 12:43:43PM +0100, Kieran Bingham wrote:\n>> On 06/09/2021 23:56, Laurent Pinchart wrote:\n>>> Now that libcamera supports per-plane offsets, pass the values to\n>>> drmModeAddFB2().\n>>\n>> Any further implications from this?\n>> Will there be a specific effect? or does it just mean that DRM can\n>> allocate buffers for more of our formats?\n> \n> There's no particular implication other than the fact that the KMS sink\n> in cam is now fixed for multi-planar formats :-) Without the offset it\n> wouldn't render NV12 correctly when planes are stored in the same\n> dmabuf.\n\nPerhaps you could add that to the commit message;\n\n\"The KMS sink in cam is now capable of rendering multi-planar formats.\"\n\n> We still allocate buffers using the FrameBufferAllocator even when using\n> the KMS sink, so this isn't related to allocation.\n> \n>> Reviewed-by: Kieran Bingham \n>>\n>>> Signed-off-by: Laurent Pinchart \n>>> Reviewed-by: Jean-Michel Hautbois \n>>> ---\n>>> src/cam/drm.cpp | 2 +-\n>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/cam/drm.cpp b/src/cam/drm.cpp\n>>> index ac47b8bd3287..d5a75d039fd8 100644\n>>> --- a/src/cam/drm.cpp\n>>> +++ b/src/cam/drm.cpp\n>>> @@ -623,7 +623,7 @@ std::unique_ptr Device::createFrameBuffer(\n>>> \t\tfb->planes_.push_back({ handle });\n>>> \n>>> \t\thandles[i] = handle;\n>>> -\t\toffsets[i] = 0; /* TODO */\n>>> +\t\toffsets[i] = plane.offset;\n>>> \t\t++i;\n>>> \t}\n>>> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77315BE175\n\tfor ;\n\tTue, 7 Sep 2021 15:45:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 423DB6916D;\n\tTue, 7 Sep 2021 17:45:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FE1760251\n\tfor ;\n\tTue, 7 Sep 2021 17:45:13 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B0CF24F;\n\tTue, 7 Sep 2021 17:45:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZjvgKe4r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631029513;\n\tbh=FeZcjO/Lp2lsjL3lO0D1fCNe45yZ1PD7SonO4tXuEUM=;\n\th=From:Subject:To:Cc:References:Date:In-Reply-To:From;\n\tb=ZjvgKe4rBXuWS29lr10tMrk6Z2Z6rPML4hq6A+DNTFPRleqiDtycLfvPRpHg+iwiC\n\tWXa5cpqKsfT6/fKc5ECnYFyXgqo+bcTEolOHAEeLjnzGFeNuVM/2du20wDaRw59Nf3\n\td/USGpIpTKtLFQr6cdM0SJpv0pn8BDxMEI49/bUg=","From":"Kieran Bingham ","To":"Laurent Pinchart ","References":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>\n\t<20210906225636.14683-24-laurent.pinchart@ideasonboard.com>\n\t<94a94b37-0337-6bd4-c4d3-bcc16794b330@ideasonboard.com>\n\t","Message-ID":"","Date":"Tue, 7 Sep 2021 16:45:10 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 24/30] cam: drm: Set per-plane\n\toffsets when creating DRM frame buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19523,"web_url":"https://patchwork.libcamera.org/comment/19523/","msgid":"","date":"2021-09-07T15:49:07","subject":"Re: [libcamera-devel] [PATCH v3 24/30] cam: drm: Set per-plane\n\toffsets when creating DRM frame buffer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Sep 07, 2021 at 04:45:10PM +0100, Kieran Bingham wrote:\n> On 07/09/2021 15:47, Laurent Pinchart wrote:\n> > On Tue, Sep 07, 2021 at 12:43:43PM +0100, Kieran Bingham wrote:\n> >> On 06/09/2021 23:56, Laurent Pinchart wrote:\n> >>> Now that libcamera supports per-plane offsets, pass the values to\n> >>> drmModeAddFB2().\n> >>\n> >> Any further implications from this?\n> >> Will there be a specific effect? or does it just mean that DRM can\n> >> allocate buffers for more of our formats?\n> > \n> > There's no particular implication other than the fact that the KMS sink\n> > in cam is now fixed for multi-planar formats :-) Without the offset it\n> > wouldn't render NV12 correctly when planes are stored in the same\n> > dmabuf.\n> \n> Perhaps you could add that to the commit message;\n> \n> \"The KMS sink in cam is now capable of rendering multi-planar formats.\"\n\nDone.\n\n> > We still allocate buffers using the FrameBufferAllocator even when using\n> > the KMS sink, so this isn't related to allocation.\n> > \n> >> Reviewed-by: Kieran Bingham \n> >>\n> >>> Signed-off-by: Laurent Pinchart \n> >>> Reviewed-by: Jean-Michel Hautbois \n> >>> ---\n> >>> src/cam/drm.cpp | 2 +-\n> >>> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>>\n> >>> diff --git a/src/cam/drm.cpp b/src/cam/drm.cpp\n> >>> index ac47b8bd3287..d5a75d039fd8 100644\n> >>> --- a/src/cam/drm.cpp\n> >>> +++ b/src/cam/drm.cpp\n> >>> @@ -623,7 +623,7 @@ std::unique_ptr Device::createFrameBuffer(\n> >>> \t\tfb->planes_.push_back({ handle });\n> >>> \n> >>> \t\thandles[i] = handle;\n> >>> -\t\toffsets[i] = 0; /* TODO */\n> >>> +\t\toffsets[i] = plane.offset;\n> >>> \t\t++i;\n> >>> \t}\n> >>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7EF1BDC71\n\tfor ;\n\tTue, 7 Sep 2021 15:49:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 06AE46916C;\n\tTue, 7 Sep 2021 17:49:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F01D60251\n\tfor ;\n\tTue, 7 Sep 2021 17:49:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC9FB24F;\n\tTue, 7 Sep 2021 17:49:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ihQu6+zI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631029766;\n\tbh=awkHRh3ag/7r4hux1jPVVRKMb1SuRHCxT2B2Y7MDN8w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ihQu6+zIUiyEfWRxWSYM3AYYzHjz78MyZliE8f7TeIapHz6v4IVt0KwpL85taA5EN\n\ttE0LezbDe8kVnNPdaNYMIYIFPAJ3DbVudOoRNvjFaQ3nmmKmCH4Ij4odQlnz+IpTm6\n\tHxdEO03/R+i0fHlr5k5pB/FLyL8sZsQoz9DhP5tY=","Date":"Tue, 7 Sep 2021 18:49:07 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>\n\t<20210906225636.14683-24-laurent.pinchart@ideasonboard.com>\n\t<94a94b37-0337-6bd4-c4d3-bcc16794b330@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v3 24/30] cam: drm: Set per-plane\n\toffsets when creating DRM frame buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]