{"id":13684,"url":"https://patchwork.libcamera.org/api/patches/13684/?format=json","web_url":"https://patchwork.libcamera.org/patch/13684/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210906225636.14683-19-laurent.pinchart@ideasonboard.com>","date":"2021-09-06T22:56:25","name":"[libcamera-devel,v3,19/30] android: jpeg: Use stride instead of image width for line address","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4c7adbbd495c7ae51d1cd6faae1bcc53d536458a","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13684/mbox/","series":[{"id":2482,"url":"https://patchwork.libcamera.org/api/series/2482/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2482","date":"2021-09-06T22:54:20","name":"libcamera: Handle fallout of FrameBuffer offset support","version":3,"mbox":"https://patchwork.libcamera.org/series/2482/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13684/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13684/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D1ECBE175\n\tfor ;\n\tMon, 6 Sep 2021 22:57:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF9C369173;\n\tTue, 7 Sep 2021 00:57:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A694569172\n\tfor ;\n\tTue, 7 Sep 2021 00:57:06 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2EBE2993;\n\tTue, 7 Sep 2021 00:57:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FmSXmhvi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630969026;\n\tbh=o5n0xDiA7QFYxvIj9O7llgm2HJtAZLE5xgDJcgsnrl4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FmSXmhviy2gI6QOpi3ze3CEVEZh4Wv2xzTReQtNkJnmBb8dU5UZr54s/g31BBqUju\n\tS2f8T1iJhuDTDiniBwjWTVbjcv0GmZEthaQJkm3UVJ0vLWCEITBmIqou4fo72ZSVX9\n\t3Fzk+PGoUKm+G+7YbTXOAs4UTrUqvpyMAirnKepE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 7 Sep 2021 01:56:25 +0300","Message-Id":"<20210906225636.14683-19-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>","References":"<20210906225420.13275-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 19/30] android: jpeg: Use stride\n\tinstead of image width for line address","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When calculating the luma line address, the image width is used instead\nof the stride. Without padding at the end of the line the the values\nshould be identical, but this is conceptually incorrect in any case. Fix\nit.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\nindex b8b01e20a001..807a0949a8fc 100644\n--- a/src/android/jpeg/encoder_libjpeg.cpp\n+++ b/src/android/jpeg/encoder_libjpeg.cpp\n@@ -152,7 +152,7 @@ void EncoderLibJpeg::compressNV(Span frame)\n \tfor (unsigned int y = 0; y < compress_.image_height; y++) {\n \t\tunsigned char *dst = &tmprowbuf[0];\n \n-\t\tconst unsigned char *src_y = src + y * compress_.image_width;\n+\t\tconst unsigned char *src_y = src + y * y_stride;\n \t\tconst unsigned char *src_cb = src_c + (y / vertSubSample) * c_stride + cb_pos;\n \t\tconst unsigned char *src_cr = src_c + (y / vertSubSample) * c_stride + cr_pos;\n \n","prefixes":["libcamera-devel","v3","19/30"]}