[{"id":1779,"web_url":"https://patchwork.libcamera.org/comment/1779/","msgid":"<20190606094410.GD12825@pendragon.ideasonboard.com>","date":"2019-06-06T09:44:10","subject":"Re: [libcamera-devel] [RFC PATCH 04/10] libcamera: ipa_interface:\n\tadd init for shims","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jun 05, 2019 at 06:18:11PM -0400, Paul Elder wrote:\n> Add a function to IPAInterface for shims to use to initialize the IPA\n> module that it will wrap around.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> ---\n>  include/libcamera/ipa/ipa_interface.h | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 2c5eb1f..fd779d2 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -15,6 +15,7 @@ public:\n>  \tvirtual ~IPAInterface() {}\n>  \n>  \tvirtual int init() = 0;\n> +\tvirtual int init(const char *path) { return 0; };\n\nCould there be a way to have a single init function ? Thinking out loud,\nhow about passing the path to the factory function, so that the shim can\nalready load the module it wraps at create time ?\n\n>  };\n>  \n>  } /* namespace libcamera */","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2A7367B71\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  6 Jun 2019 11:44:24 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a02:a03f:44f0:8500:ca05:8177:199c:fed4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D21033B;\n\tThu,  6 Jun 2019 11:44:24 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559814264;\n\tbh=bv+43EOzbYXgMx1BU1ThK9jvGfVFa/6aqEfa4KWWRKw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NEOXRlaG8QBep6IpgyVuL11+LaaTCsdCMFQQIxYzPB5OeXg2FQi5fJKnbW1DT3bug\n\tnhUgbKDokpWeCi53mWsIIBNCQdxVZ2vh1C2fr+XyURxSLlV4EqTtcyy5i2ebSrObGZ\n\tU9k1lF+alIAZZSk7LXZdGDDP5IlDQbShg5lwq+Eo=","Date":"Thu, 6 Jun 2019 12:44:10 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190606094410.GD12825@pendragon.ideasonboard.com>","References":"<20190605221817.966-1-paul.elder@ideasonboard.com>\n\t<20190605221817.966-5-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190605221817.966-5-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC PATCH 04/10] libcamera: ipa_interface:\n\tadd init for shims","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 06 Jun 2019 09:44:25 -0000"}}]