[{"id":1777,"web_url":"https://patchwork.libcamera.org/comment/1777/","msgid":"<20190606093858.GB12825@pendragon.ideasonboard.com>","date":"2019-06-06T09:38:58","subject":"Re: [libcamera-devel] [RFC PATCH 02/10] libcamera: ipa_module: add\n\tpath getter","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jun 05, 2019 at 06:18:09PM -0400, Paul Elder wrote:\n> Add a method to IPAModule to get the path of the IPA module shared\n> object that the IPAModule was constructed from.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/include/ipa_module.h | 1 +\n> src/libcamera/ipa_module.cpp | 13 +++++++++++++\n> 2 files changed, 14 insertions(+)\n> \n> diff --git a/src/libcamera/include/ipa_module.h b/src/libcamera/include/ipa_module.h\n> index fec4237..f6904fa 100644\n> --- a/src/libcamera/include/ipa_module.h\n> +++ b/src/libcamera/include/ipa_module.h\n> @@ -26,6 +26,7 @@ public:\n> \tbool isValid() const;\n> \n> \tconst struct IPAModuleInfo &info() const;\n> +\tconst char *path() const;\n\nYou can return a const std::string & as we have an std::string\ninternally already.\n\n> \n> \tbool load();\n> \n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 2663b9e..e1d4b27 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -321,6 +321,19 @@ const struct IPAModuleInfo &IPAModule::info() const\n> \treturn info_;\n> }\n> \n> +/**\n> + * \\brief Retrieve the IPA module path\n> + *\n> + * The IPA module path is the file name and path of the IPA module shared\n> + * object from which the IPA module was created.\n> + *\n> + * \\return the IPA module path\n\ns/the/The/\n\nWith these small issues fixed,\n\nReviewed-by: Laurent Pinchart \n\n> + */\n> +const char *IPAModule::path() const\n> +{\n> +\treturn libPath_.c_str();\n> +}\n> +\n> /**\n> * \\brief Load the IPA implementation factory from the shared object\n> *","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7472D67B57\n\tfor ;\n\tThu, 6 Jun 2019 11:39:12 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a02:a03f:44f0:8500:ca05:8177:199c:fed4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0948E33B;\n\tThu, 6 Jun 2019 11:39:12 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559813952;\n\tbh=AJJsoaV3wrVHSkXkkNHh3m8cT9pbhcEzH+o2HvH8OhI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kCu31bo5ZEmTwqJPYy7Tkjx0qxQbBmriVcs7dIDQd+j5MGLwFk4VR6feZk+ln3V3w\n\t8uhXuITWfAcPKOFoRAsjOBRNFUOl/a03rrxYQYcXFHhRtOcMZuuVc86xSb0GCvYoQx\n\tz6ACXK8DMp0rA9ox1GgesVufy5p9Eksat2H5nvc0=","Date":"Thu, 6 Jun 2019 12:38:58 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190606093858.GB12825@pendragon.ideasonboard.com>","References":"<20190605221817.966-1-paul.elder@ideasonboard.com>\n\t<20190605221817.966-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190605221817.966-3-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC PATCH 02/10] libcamera: ipa_module: add\n\tpath getter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 06 Jun 2019 09:39:12 -0000"}}]