[{"id":19414,"web_url":"https://patchwork.libcamera.org/comment/19414/","msgid":"","date":"2021-09-06T09:32:45","subject":"Re: [libcamera-devel] [PATCH v2 24/27] qcam: Print bytesused for\n\tall planes","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 06/09/2021 04:00, Laurent Pinchart wrote:\n> Fix the debug message that prints frame metadata to print the number of\n> bytes used for each plane, not just the first one.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/main_window.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index ac853e360aea..0a00b1001570 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -20,6 +20,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -754,9 +755,13 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n> \tfps = lastBufferTime_ && fps ? 1000000000.0 / fps : 0.0;\n> \tlastBufferTime_ = metadata.timestamp;\n> \n> +\tQStringList bytesused;\n> +\tfor (const FrameMetadata::Plane &plane : metadata.planes())\n> +\t\tbytesused << QString::number(plane.bytesused);\n> +\n> \tqDebug().noquote()\n> \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n> -\t\t<< \"bytesused:\" << metadata.planes()[0].bytesused\n> +\t\t<< \"bytesused:\" << bytesused.join(\"/\")\nI would'nt think about using join :-) thx.\nReviewed-by: Jean-Michel Hautbois \n\n> \t\t<< \"timestamp:\" << metadata.timestamp\n> \t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D477ABDC71\n\tfor ;\n\tMon, 6 Sep 2021 09:32:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D0DF6916A;\n\tMon, 6 Sep 2021 11:32:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27D4760503\n\tfor ;\n\tMon, 6 Sep 2021 11:32:49 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:eb18:8e30:9b7:f998])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D57888D7;\n\tMon, 6 Sep 2021 11:32:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BQtPFCmp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630920768;\n\tbh=QI6o2Iz0Uh0lQcum3STpsarDqwEv1BsX4Tp0au3La1s=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=BQtPFCmp3Xixno8cjvy8lC3HfXc+6e1Z4Y7rpwpJ6etGMSZNBnhz/OcKYKHNblm74\n\tgNwdRyIyjt42v2rO0sPCtZkmKxFzfpNfo2ZFovsPNnTDaRlP2iqpnHbtZZOALPCt1P\n\tNToTB87eglALECXyMZuKrFuVlrT22NsikgvzaiQA=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210906020100.14430-1-laurent.pinchart@ideasonboard.com>\n\t<20210906020100.14430-25-laurent.pinchart@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Mon, 6 Sep 2021 11:32:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<20210906020100.14430-25-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 24/27] qcam: Print bytesused for\n\tall planes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]