{"id":13625,"url":"https://patchwork.libcamera.org/api/patches/13625/?format=json","web_url":"https://patchwork.libcamera.org/patch/13625/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210906020100.14430-25-laurent.pinchart@ideasonboard.com>","date":"2021-09-06T02:00:57","name":"[libcamera-devel,v2,24/27] qcam: Print bytesused for all planes","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"be65f41f8218c94c5b2763f53cb905c480b86053","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13625/mbox/","series":[{"id":2446,"url":"https://patchwork.libcamera.org/api/series/2446/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2446","date":"2021-09-06T02:00:33","name":"libcamera: Handle fallout of FrameBuffer offset support","version":2,"mbox":"https://patchwork.libcamera.org/series/2446/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13625/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13625/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A22A9C3252\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  6 Sep 2021 02:01:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4702F69195;\n\tMon,  6 Sep 2021 04:01:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 622446917D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  6 Sep 2021 04:01:30 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF0AA317;\n\tMon,  6 Sep 2021 04:01:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XjFxP4J/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630893690;\n\tbh=EXDpKBAwzDoi0Leyasjz9PsQE6wcJa7A0xsiCgMtj0k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XjFxP4J/HfnY0LAfbeG9iWb0OwE9ZphTc2VY8L9Zc7iFjXKwimB85t4z6mJz6zO50\n\tg2BAhdy3hNw0QYx2Fy8qKKnpqgh6qTakPt7qkPPnKwlG0xENW9EVqaCUjc2hI3eOjB\n\t2ikDYd/0egybU0vOOsopxbJRzbJdv5IY1YT+edKE=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon,  6 Sep 2021 05:00:57 +0300","Message-Id":"<20210906020100.14430-25-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20210906020100.14430-1-laurent.pinchart@ideasonboard.com>","References":"<20210906020100.14430-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 24/27] qcam: Print bytesused for all\n\tplanes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Fix the debug message that prints frame metadata to print the number of\nbytes used for each plane, not just the first one.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex ac853e360aea..0a00b1001570 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -20,6 +20,7 @@\n #include <QInputDialog>\n #include <QMutexLocker>\n #include <QStandardPaths>\n+#include <QStringList>\n #include <QTimer>\n #include <QToolBar>\n #include <QToolButton>\n@@ -754,9 +755,13 @@ void MainWindow::processViewfinder(FrameBuffer *buffer)\n \tfps = lastBufferTime_ && fps ? 1000000000.0 / fps : 0.0;\n \tlastBufferTime_ = metadata.timestamp;\n \n+\tQStringList bytesused;\n+\tfor (const FrameMetadata::Plane &plane : metadata.planes())\n+\t\tbytesused << QString::number(plane.bytesused);\n+\n \tqDebug().noquote()\n \t\t<< QString(\"seq: %1\").arg(metadata.sequence, 6, 10, QLatin1Char('0'))\n-\t\t<< \"bytesused:\" << metadata.planes()[0].bytesused\n+\t\t<< \"bytesused:\" << bytesused.join(\"/\")\n \t\t<< \"timestamp:\" << metadata.timestamp\n \t\t<< \"fps:\" << Qt::fixed << qSetRealNumberPrecision(2) << fps;\n \n","prefixes":["libcamera-devel","v2","24/27"]}