[{"id":1776,"web_url":"https://patchwork.libcamera.org/comment/1776/","msgid":"<20190606093754.GA12825@pendragon.ideasonboard.com>","date":"2019-06-06T09:37:54","subject":"Re: [libcamera-devel] [RFC PATCH 01/10] libcamera: ipa_module_info:\n\tremove cplusplus guards","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jun 05, 2019 at 06:18:08PM -0400, Paul Elder wrote:\n> IPA modules must be implemented in C++, which means we no longer need\n> __cplusplus guards, so remove them.\n> \n> Signed-off-by: Paul Elder \n\nWe may reconsider this later if we find out that exposing a C++ object\nmakes preserving the ABI more difficult, but for now\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/ipa/ipa_module_info.h | 8 --------\n> 1 file changed, 8 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h\n> index 803b5d3..585f753 100644\n> --- a/include/libcamera/ipa/ipa_module_info.h\n> +++ b/include/libcamera/ipa/ipa_module_info.h\n> @@ -11,9 +11,7 @@\n> \n> #define IPA_MODULE_API_VERSION 1\n> \n> -#ifdef __cplusplus\n> namespace libcamera {\n> -#endif\n> \n> struct IPAModuleInfo {\n> \tint moduleAPIVersion;\n> @@ -22,16 +20,10 @@ struct IPAModuleInfo {\n> \tchar name[256];\n> } __attribute__((packed));\n> \n> -#ifdef __cplusplus\n> extern \"C\" {\n> -#endif\n> extern const struct IPAModuleInfo ipaModuleInfo;\n> -#ifdef __cplusplus\n> };\n> -#endif\n> \n> -#ifdef __cplusplus\n> }; /* namespace libcamera */\n> -#endif\n> \n> #endif /* __LIBCAMERA_IPA_MODULE_INFO_H__ */\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B824567B44\n\tfor ;\n\tThu, 6 Jun 2019 11:38:08 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a02:a03f:44f0:8500:ca05:8177:199c:fed4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 504F333B;\n\tThu, 6 Jun 2019 11:38:08 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559813888;\n\tbh=u+EJjdj6lolNzPj3w6ZUEZMDwa0lLqoALI5n+JKtqp0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=asfEopaJe4stvOnFh5CT2VCy7q+2NsrEmIZbUsH9ko5GjtDtlC6FdzDqEM1l0woMP\n\tHgmYClazIjGp3z7dV077oDXmjQykYHwoiv122047VWR5MkFKWXmpfiAq/5Ynin0Ysv\n\tpgvV/0KufabymTBKyRNHxPq+QNAVVlP7kFF0fXQk=","Date":"Thu, 6 Jun 2019 12:37:54 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190606093754.GA12825@pendragon.ideasonboard.com>","References":"<20190605221817.966-1-paul.elder@ideasonboard.com>\n\t<20190605221817.966-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190605221817.966-2-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC PATCH 01/10] libcamera: ipa_module_info:\n\tremove cplusplus guards","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 06 Jun 2019 09:38:09 -0000"}}]