[{"id":19390,"web_url":"https://patchwork.libcamera.org/comment/19390/","msgid":"","date":"2021-09-06T05:34:01","subject":"Re: [libcamera-devel] [PATCH v2 01/27] libcamera: base: utils: Use\n\tsize_t for index in utils::enumerate()","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 06/09/2021 04:00, Laurent Pinchart wrote:\n> The index generated by utils::enumerate() is an iteration counter, which\n> should thus be positive. Use std::size_t instead of the different_type\n> of the container.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \nReviewed-by: Jean-Michel Hautbois \n> ---\n> include/libcamera/base/utils.h | 4 ++--\n> test/utils.cpp | 10 +++++-----\n> 2 files changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 52301254c2eb..2b761436a99f 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -246,7 +246,7 @@ private:\n> \n> public:\n> \tusing difference_type = typename std::iterator_traits::difference_type;\n> -\tusing value_type = std::pair;\n> +\tusing value_type = std::pair;\n> \tusing pointer = value_type *;\n> \tusing reference = value_type &;\n> \tusing iterator_category = std::input_iterator_tag;\n> @@ -275,7 +275,7 @@ public:\n> \n> private:\n> \tBase current_;\n> -\tdifference_type pos_;\n> +\tstd::size_t pos_;\n> };\n> \n> template\n> diff --git a/test/utils.cpp b/test/utils.cpp\n> index d7f810e95e7a..d65467b5102c 100644\n> --- a/test/utils.cpp\n> +++ b/test/utils.cpp\n> @@ -77,8 +77,8 @@ protected:\n> \n> \tint testEnumerate()\n> \t{\n> -\t\tstd::vector integers{ 1, 2, 3, 4, 5 };\n> -\t\tint i = 0;\n> +\t\tstd::vector integers{ 1, 2, 3, 4, 5 };\n> +\t\tunsigned int i = 0;\n> \n> \t\tfor (auto [index, value] : utils::enumerate(integers)) {\n> \t\t\tif (index != i || value != i + 1) {\n> @@ -93,12 +93,12 @@ protected:\n> \t\t\t++i;\n> \t\t}\n> \n> -\t\tif (integers != std::vector{ 0, 1, 2, 3, 4 }) {\n> +\t\tif (integers != std::vector{ 0, 1, 2, 3, 4 }) {\n> \t\t\tcerr << \"Failed to modify container in enumerated range loop\" << endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -\t\tSpan span{ integers };\n> +\t\tSpan span{ integers };\n> \t\ti = 0;\n> \n> \t\tfor (auto [index, value] : utils::enumerate(span)) {\n> @@ -112,7 +112,7 @@ protected:\n> \t\t\t++i;\n> \t\t}\n> \n> -\t\tconst int array[] = { 0, 2, 4, 6, 8 };\n> +\t\tconst unsigned int array[] = { 0, 2, 4, 6, 8 };\n> \t\ti = 0;\n> \n> \t\tfor (auto [index, value] : utils::enumerate(array)) {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B4B8BDC71\n\tfor ;\n\tMon, 6 Sep 2021 05:34:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CE1B6916A;\n\tMon, 6 Sep 2021 07:34:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 117B56024D\n\tfor ;\n\tMon, 6 Sep 2021 07:34:04 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:eb18:8e30:9b7:f998])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9D97317;\n\tMon, 6 Sep 2021 07:34:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vkq8ERCA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630906443;\n\tbh=AqEMpEEJs0eUxyol16qH5Cyn8wxbJ/3zpp+BjTHPPvM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=vkq8ERCAeRFi6JBu3Kn1v+dLnhVmC7RtlX5+d0P+Qbp1J6zC28DIU9lXSox5IFjUv\n\ty48nxwOjNEEFos6MDcxhxp7aPN80zScaz28+LG0ET7RfvgVLw+iV9gZZpKsjDPJqHQ\n\tiowdJ80vgbxmIy/Xwk73dvvArAWYrRbnVXfHW9gI=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210906020100.14430-1-laurent.pinchart@ideasonboard.com>\n\t<20210906020100.14430-2-laurent.pinchart@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Mon, 6 Sep 2021 07:34:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.13.0","MIME-Version":"1.0","In-Reply-To":"<20210906020100.14430-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 01/27] libcamera: base: utils: Use\n\tsize_t for index in utils::enumerate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19408,"web_url":"https://patchwork.libcamera.org/comment/19408/","msgid":"<20210906090343.GS968527@pyrite.rasen.tech>","date":"2021-09-06T09:03:43","subject":"Re: [libcamera-devel] [PATCH v2 01/27] libcamera: base: utils: Use\n\tsize_t for index in utils::enumerate()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Sep 06, 2021 at 05:00:34AM +0300, Laurent Pinchart wrote:\n> The index generated by utils::enumerate() is an iteration counter, which\n> should thus be positive. Use std::size_t instead of the different_type\n\ns/different/difference/ ?\n\n> of the container.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/base/utils.h | 4 ++--\n> test/utils.cpp | 10 +++++-----\n> 2 files changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 52301254c2eb..2b761436a99f 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -246,7 +246,7 @@ private:\n> \n> public:\n> \tusing difference_type = typename std::iterator_traits::difference_type;\n> -\tusing value_type = std::pair;\n> +\tusing value_type = std::pair;\n> \tusing pointer = value_type *;\n> \tusing reference = value_type &;\n> \tusing iterator_category = std::input_iterator_tag;\n> @@ -275,7 +275,7 @@ public:\n> \n> private:\n> \tBase current_;\n> -\tdifference_type pos_;\n> +\tstd::size_t pos_;\n> };\n> \n> template\n> diff --git a/test/utils.cpp b/test/utils.cpp\n> index d7f810e95e7a..d65467b5102c 100644\n> --- a/test/utils.cpp\n> +++ b/test/utils.cpp\n> @@ -77,8 +77,8 @@ protected:\n> \n> \tint testEnumerate()\n> \t{\n> -\t\tstd::vector integers{ 1, 2, 3, 4, 5 };\n> -\t\tint i = 0;\n> +\t\tstd::vector integers{ 1, 2, 3, 4, 5 };\n> +\t\tunsigned int i = 0;\n> \n> \t\tfor (auto [index, value] : utils::enumerate(integers)) {\n> \t\t\tif (index != i || value != i + 1) {\n> @@ -93,12 +93,12 @@ protected:\n> \t\t\t++i;\n> \t\t}\n> \n> -\t\tif (integers != std::vector{ 0, 1, 2, 3, 4 }) {\n> +\t\tif (integers != std::vector{ 0, 1, 2, 3, 4 }) {\n> \t\t\tcerr << \"Failed to modify container in enumerated range loop\" << endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -\t\tSpan span{ integers };\n> +\t\tSpan span{ integers };\n> \t\ti = 0;\n> \n> \t\tfor (auto [index, value] : utils::enumerate(span)) {\n> @@ -112,7 +112,7 @@ protected:\n> \t\t\t++i;\n> \t\t}\n> \n> -\t\tconst int array[] = { 0, 2, 4, 6, 8 };\n> +\t\tconst unsigned int array[] = { 0, 2, 4, 6, 8 };\n> \t\ti = 0;\n> \n> \t\tfor (auto [index, value] : utils::enumerate(array)) {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31BA1BD87D\n\tfor ;\n\tMon, 6 Sep 2021 09:03:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 998376916A;\n\tMon, 6 Sep 2021 11:03:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C96260503\n\tfor ;\n\tMon, 6 Sep 2021 11:03:50 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C97CE317;\n\tMon, 6 Sep 2021 11:03:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b73P9ZkM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630919029;\n\tbh=+gEIli8wpueEC3wcybGuo7JYWcjY6gjdqXeQ7vhcr+8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=b73P9ZkMix1UpglmffD4uAIgTelKzYux7CA0FK4I+R537VXSXcaTUR//aKJEJXEAk\n\tYd0umPOwUrk+ZFWpiemswMQnhMEcC0N1fTjFtlkPOhGk7VWyzhr7gIpEIWWHPvoRbr\n\t7WZa8AckBitp0ka84A39ZRWIxvZtgxkuVe5+ZqmY=","Date":"Mon, 6 Sep 2021 18:03:43 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210906090343.GS968527@pyrite.rasen.tech>","References":"<20210906020100.14430-1-laurent.pinchart@ideasonboard.com>\n\t<20210906020100.14430-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210906020100.14430-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 01/27] libcamera: base: utils: Use\n\tsize_t for index in utils::enumerate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19425,"web_url":"https://patchwork.libcamera.org/comment/19425/","msgid":"","date":"2021-09-06T11:35:43","subject":"Re: [libcamera-devel] [PATCH v2 01/27] libcamera: base: utils: Use\n\tsize_t for index in utils::enumerate()","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\nOn Mon, Sep 6, 2021 at 6:03 PM wrote:\n>\n> Hi Laurent,\n>\n> On Mon, Sep 06, 2021 at 05:00:34AM +0300, Laurent Pinchart wrote:\n> > The index generated by utils::enumerate() is an iteration counter, which\n> > should thus be positive. Use std::size_t instead of the different_type\n>\n> s/different/difference/ ?\n>\n> > of the container.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > Reviewed-by: Kieran Bingham \n>\n> Reviewed-by: Paul Elder \n>\n\nReviewed-by: Hirokazu Honda \n\n> > ---\n> > include/libcamera/base/utils.h | 4 ++--\n> > test/utils.cpp | 10 +++++-----\n> > 2 files changed, 7 insertions(+), 7 deletions(-)\n> >\n> > diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> > index 52301254c2eb..2b761436a99f 100644\n> > --- a/include/libcamera/base/utils.h\n> > +++ b/include/libcamera/base/utils.h\n> > @@ -246,7 +246,7 @@ private:\n> >\n> > public:\n> > using difference_type = typename std::iterator_traits::difference_type;\n> > - using value_type = std::pair;\n> > + using value_type = std::pair;\n> > using pointer = value_type *;\n> > using reference = value_type &;\n> > using iterator_category = std::input_iterator_tag;\n> > @@ -275,7 +275,7 @@ public:\n> >\n> > private:\n> > Base current_;\n> > - difference_type pos_;\n> > + std::size_t pos_;\n> > };\n> >\n> > template\n> > diff --git a/test/utils.cpp b/test/utils.cpp\n> > index d7f810e95e7a..d65467b5102c 100644\n> > --- a/test/utils.cpp\n> > +++ b/test/utils.cpp\n> > @@ -77,8 +77,8 @@ protected:\n> >\n> > int testEnumerate()\n> > {\n> > - std::vector integers{ 1, 2, 3, 4, 5 };\n> > - int i = 0;\n> > + std::vector integers{ 1, 2, 3, 4, 5 };\n> > + unsigned int i = 0;\n> >\n> > for (auto [index, value] : utils::enumerate(integers)) {\n> > if (index != i || value != i + 1) {\n> > @@ -93,12 +93,12 @@ protected:\n> > ++i;\n> > }\n> >\n> > - if (integers != std::vector{ 0, 1, 2, 3, 4 }) {\n> > + if (integers != std::vector{ 0, 1, 2, 3, 4 }) {\n> > cerr << \"Failed to modify container in enumerated range loop\" << endl;\n> > return TestFail;\n> > }\n> >\n> > - Span span{ integers };\n> > + Span span{ integers };\n> > i = 0;\n> >\n> > for (auto [index, value] : utils::enumerate(span)) {\n> > @@ -112,7 +112,7 @@ protected:\n> > ++i;\n> > }\n> >\n> > - const int array[] = { 0, 2, 4, 6, 8 };\n> > + const unsigned int array[] = { 0, 2, 4, 6, 8 };\n> > i = 0;\n> >\n> > for (auto [index, value] : utils::enumerate(array)) {\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 875C1BDC71\n\tfor ;\n\tMon, 6 Sep 2021 11:35:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01B2969167;\n\tMon, 6 Sep 2021 13:35:56 +0200 (CEST)","from mail-ed1-x535.google.com (mail-ed1-x535.google.com\n\t[IPv6:2a00:1450:4864:20::535])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A481060137\n\tfor ;\n\tMon, 6 Sep 2021 13:35:54 +0200 (CEST)","by mail-ed1-x535.google.com with SMTP id q3so9132933edt.5\n\tfor ;\n\tMon, 06 Sep 2021 04:35:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Y1DLwc1o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=JX1JOUCObZnkYg7ZMS65sMOIQp1QMeLR6NeJFu9qPnI=;\n\tb=Y1DLwc1owPV+LFbL2Rd2YL79Vo2sK2p0wSV31DnCSDB5Xwgkrmx70ysTOSSRItJAEF\n\tnGdKeRA3nl0DtAplpw6RDPQpWX2OtieeEvyngd+4HdT0ZFYu4VLNJdwfyaAdGYhFU90E\n\t7R7QY+yxmkK5QU4v1cKHy6XfFduxFGUoN7gqY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=JX1JOUCObZnkYg7ZMS65sMOIQp1QMeLR6NeJFu9qPnI=;\n\tb=aXkXVOQmEnpwoEzhkkQLOAODBtGXMrVl1UxmyhHjFSH1qu3yW94+5iIZgynVfubhnA\n\tyXqd7hDp/uiCoOJbITKnNBLeQlijVkKYHeR3p6tvfdt1vOzJh8DrjA/6HW6TVe5EcuOa\n\tK2/78V2nvI7pzJx0Z8fNFRezrbW3OXk+zvO8V7IDFoYpzOHokf8eBpxcvdaA1vn8nYC+\n\t8m1NCjyv8SEykhIo7dwWPOaMRNEEzp4LGySJYg4NhPTI+Hca/rwLTE+VgngJvSATPzz1\n\tOQk3Sqv8zVafTwrqeOM9QF+zv8PN140BZjkEcrl0roAPVGZoxYlGYFjDgXAph/Yj62tw\n\tBIVA==","X-Gm-Message-State":"AOAM530U4Im08joyRZVQtQWrKpl0ygKZXl4hCGTr1aOcyXuEk1KFt0tZ\n\tOijmgBoUrsy95PsCat1xZ4j/9pUzM0nt2yircnLSoWOHFM0=","X-Google-Smtp-Source":"ABdhPJw/1h8U9F1OpC9cqemFPZRodMVzRmDV+Vfzyni+DWYdq7tSfoXlxq/1Mbb917XSF9Cu/HiGCkZ8llyRG0ikJ4A=","X-Received":"by 2002:aa7:d617:: with SMTP id\n\tc23mr13249069edr.206.1630928154199; \n\tMon, 06 Sep 2021 04:35:54 -0700 (PDT)","MIME-Version":"1.0","References":"<20210906020100.14430-1-laurent.pinchart@ideasonboard.com>\n\t<20210906020100.14430-2-laurent.pinchart@ideasonboard.com>\n\t<20210906090343.GS968527@pyrite.rasen.tech>","In-Reply-To":"<20210906090343.GS968527@pyrite.rasen.tech>","From":"Hirokazu Honda ","Date":"Mon, 6 Sep 2021 20:35:43 +0900","Message-ID":"","To":"Paul Elder ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 01/27] libcamera: base: utils: Use\n\tsize_t for index in utils::enumerate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]