[{"id":1773,"web_url":"https://patchwork.libcamera.org/comment/1773/","msgid":"<20190605161622.GQ32191@localhost.localdomain>","date":"2019-06-05T16:16:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: Use dependency instead of\n\tlink_args to link against libdl","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn Wed, Jun 05, 2019 at 06:40:47PM +0300, Laurent Pinchart wrote:\n> Instead of specifying the link arguments directly, which may be\n> compiler-specific, use a dependency object provided by find_library().\n> \n> Signed-off-by: Laurent Pinchart \n\nLooks good to me.\n\nReviewed-by: Paul Elder \nTested-by: Paul Elder \n\n> ---\n> src/libcamera/meson.build | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 0889b0d31f36..1ca1083cf5c7 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -63,12 +63,16 @@ if libudev.found()\n> ])\n> endif\n> \n> +libcamera_deps = [\n> + cc.find_library('dl'),\n> + libudev,\n> +]\n> +\n> libcamera = shared_library('camera',\n> libcamera_sources,\n> install : true,\n> include_directories : includes,\n> - dependencies : libudev,\n> - link_args : '-ldl')\n> + dependencies : libcamera_deps)\n> \n> libcamera_dep = declare_dependency(sources : [libcamera_api, libcamera_h],\n> include_directories : libcamera_includes,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2EF22664E3\n\tfor ;\n\tWed, 5 Jun 2019 18:16:30 +0200 (CEST)","from localhost.localdomain (unknown [96.44.9.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C8FF84;\n\tWed, 5 Jun 2019 18:16:29 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559751389;\n\tbh=80r70+VKs1TFxaj4staB4pI9Wp99EMONC9a5Ct3IEpk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZRT2ArdmTpuutYRBrN570CSCEQxJxOmTKHv4o43Ga6VvTjl3tgXNvvqgAjAPdfJxS\n\tTF2DiD8ND52eVmsMEF52CRV18GRaDoIKE3wIJYk18XgL1o3E05kv6uvArsS1AaeCZ0\n\tTuRiqa2VYaYAbJ6iTZRdmH0BeN91EMQFrM+2X7Mc=","Date":"Wed, 5 Jun 2019 12:16:22 -0400","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190605161622.GQ32191@localhost.localdomain>","References":"<20190605154047.12055-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190605154047.12055-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Use dependency instead of\n\tlink_args to link against libdl","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 05 Jun 2019 16:16:30 -0000"}}]