[{"id":192,"web_url":"https://patchwork.libcamera.org/comment/192/","msgid":"<20190103211743.GD22790@bigcity.dyn.berto.se>","date":"2019-01-03T21:17:43","subject":"Re: [libcamera-devel] [PATCH 2/9] libcamera: camera_manager: Sort\n\tincludes alphabetically","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-01-03 03:31:03 +0200, Laurent Pinchart wrote:\n> Alphabetically sorted includes help finding where to insert new include\n> statements, and avoiding duplicates.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/camera_manager.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n> index 43a7811b3ea2..2768a5bd2384 100644\n> --- a/include/libcamera/camera_manager.h\n> +++ b/include/libcamera/camera_manager.h\n> @@ -7,8 +7,8 @@\n> #ifndef __LIBCAMERA_CAMERA_MANAGER_H__\n> #define __LIBCAMERA_CAMERA_MANAGER_H__\n> \n> -#include \n> #include \n> +#include \n> \n> namespace libcamera {\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C11FD60B21\n\tfor ;\n\tThu, 3 Jan 2019 22:17:45 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id n18so24112347lfh.6\n\tfor ;\n\tThu, 03 Jan 2019 13:17:45 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tg15sm10749567lfb.1.2019.01.03.13.17.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 03 Jan 2019 13:17:44 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=34IiPAd6T9/Ir3NHblUJNHEZs/UjRlOlwEQ0YvExoTQ=;\n\tb=YxP0dlvTBNX6khRs4NFw5MP+rd084LnjbnYOvLapfj9zhQghI+FWA2ioLtfBjUt1RD\n\tc6Yh9Qi2/hkJycpPPpO80Wep8stUG7+/nIQEuLJ8QFNpgTGVMB/mjxcM7JEHVMn8mBRq\n\tiG8cSkQSehYXkl/yYiMu9IAH9HPnU/j6sDV0lE6t4HjEbF9DxY4MX+onM5U90ic0wxT5\n\t27zOOZUKVpkrxMI6jwyKA8jh9iDuj8Oo/zpHnMKoGageDuh/AWDOoUDH+1yn3+WH4j1c\n\tT2HFtHG5fkq3qWZ06xLZLoNhP4cf45eLe7FYWlpGMxnkDPQLbKwvaBU0bu8TSsjleROC\n\t75rg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=34IiPAd6T9/Ir3NHblUJNHEZs/UjRlOlwEQ0YvExoTQ=;\n\tb=kWIl4FxNQzvgEtBUgGSdDyRy9zaF7lin5WG3ugvCCqRtt9r1FBt+F90628B78y61Wz\n\te7qLwx6VNBpnwUkvUmx2f8SDO9M6ILNS1WbSzqqAyEmwH/HjAGi+1h0Au2gdKAO8Kthv\n\t+gYkkSKCixHjhNpcAxjWYrxZ0zIN4QICwjtQYmy7JT1GALar/8dApLgvaeQSa/3naRbU\n\tRSEZuAecNRJUkNp9EQ7Wf97xK9Se5RyUrHdXBRsqLE8Kla2uEgAM1+sgOxcjxpNI5Kw3\n\twPFYufPisCgRkkKGtmyBqtdrGBRux30VboYEPMAXOioqNpQdmbxsvr7vOc2JJbWNaqRU\n\t1WFw==","X-Gm-Message-State":"AJcUukeHtHYQlWfESVNvL/1DmxgTsjAXt9oQ9W9HuZ2t4F9TR0rn+pEb\n\t40NKL3LoklBeE3GpS3cZ+TcxRA==","X-Google-Smtp-Source":"ALg8bN407kwVuyef84otzNMD8EL7bxl83vUkWSFtLhSNCeQpvVbaIe9cjrQxPcF0OaTOKkqajdGM4g==","X-Received":"by 2002:ac2:53bc:: with SMTP id j28mr2148863lfh.86.1546550264672;\n\tThu, 03 Jan 2019 13:17:44 -0800 (PST)","Date":"Thu, 3 Jan 2019 22:17:43 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190103211743.GD22790@bigcity.dyn.berto.se>","References":"<20190103013110.6849-1-laurent.pinchart@ideasonboard.com>\n\t<20190103013110.6849-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190103013110.6849-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/9] libcamera: camera_manager: Sort\n\tincludes alphabetically","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Jan 2019 21:17:46 -0000"}}]