{"id":13597,"url":"https://patchwork.libcamera.org/api/patches/13597/?format=json","web_url":"https://patchwork.libcamera.org/patch/13597/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210902042303.2254-2-laurent.pinchart@ideasonboard.com>","date":"2021-09-02T04:22:52","name":"[libcamera-devel,RFC,v1,01/12] libcamera: base: utils: Use size_t for index in utils::enumerate()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8e5367cf2401e36d1b49328e421213534e9732e2","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/13597/mbox/","series":[{"id":2435,"url":"https://patchwork.libcamera.org/api/series/2435/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2435","date":"2021-09-02T04:22:51","name":"libcamera: Handle fallout of FrameBuffer offset support","version":1,"mbox":"https://patchwork.libcamera.org/series/2435/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/13597/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/13597/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C0C9BDC71\n\tfor ;\n\tThu, 2 Sep 2021 04:23:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E2A169175;\n\tThu, 2 Sep 2021 06:23:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9047560503\n\tfor ;\n\tThu, 2 Sep 2021 06:23:23 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2818C532;\n\tThu, 2 Sep 2021 06:23:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YZICMoc8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630556603;\n\tbh=EGsuCz46CfqF9csFzUwa9z0WWFrn+8UXa9jBXTTFsZo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YZICMoc8mrNzQSWPbA00PmHymUy6ibz14pN0rVyiYRd7jL+n4YpjhmCCLSSdB5wCX\n\t8qJgGzYWBSaHW4PrB2/0iknPjd8nDYq4Cge8CsqMxple3y3nhlD0MbW5aTGLtRvLGf\n\t99Af1vX/R5KlmmlxtTfdUqE24tWL3LJRzIu1HFcc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 2 Sep 2021 07:22:52 +0300","Message-Id":"<20210902042303.2254-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20210902042303.2254-1-laurent.pinchart@ideasonboard.com>","References":"<20210902042303.2254-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v1 01/12] libcamera: base: utils: Use\n\tsize_t for index in utils::enumerate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The index generated by utils::enumerate() is an iteration counter, which\nshould thus be positive. Use std::size_t instead of the different_type\nof the container.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/base/utils.h | 4 ++--\n test/utils.cpp | 10 +++++-----\n 2 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex 52301254c2eb..2b761436a99f 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -246,7 +246,7 @@ private:\n \n public:\n \tusing difference_type = typename std::iterator_traits::difference_type;\n-\tusing value_type = std::pair;\n+\tusing value_type = std::pair;\n \tusing pointer = value_type *;\n \tusing reference = value_type &;\n \tusing iterator_category = std::input_iterator_tag;\n@@ -275,7 +275,7 @@ public:\n \n private:\n \tBase current_;\n-\tdifference_type pos_;\n+\tstd::size_t pos_;\n };\n \n template\ndiff --git a/test/utils.cpp b/test/utils.cpp\nindex d7f810e95e7a..d65467b5102c 100644\n--- a/test/utils.cpp\n+++ b/test/utils.cpp\n@@ -77,8 +77,8 @@ protected:\n \n \tint testEnumerate()\n \t{\n-\t\tstd::vector integers{ 1, 2, 3, 4, 5 };\n-\t\tint i = 0;\n+\t\tstd::vector integers{ 1, 2, 3, 4, 5 };\n+\t\tunsigned int i = 0;\n \n \t\tfor (auto [index, value] : utils::enumerate(integers)) {\n \t\t\tif (index != i || value != i + 1) {\n@@ -93,12 +93,12 @@ protected:\n \t\t\t++i;\n \t\t}\n \n-\t\tif (integers != std::vector{ 0, 1, 2, 3, 4 }) {\n+\t\tif (integers != std::vector{ 0, 1, 2, 3, 4 }) {\n \t\t\tcerr << \"Failed to modify container in enumerated range loop\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n \n-\t\tSpan span{ integers };\n+\t\tSpan span{ integers };\n \t\ti = 0;\n \n \t\tfor (auto [index, value] : utils::enumerate(span)) {\n@@ -112,7 +112,7 @@ protected:\n \t\t\t++i;\n \t\t}\n \n-\t\tconst int array[] = { 0, 2, 4, 6, 8 };\n+\t\tconst unsigned int array[] = { 0, 2, 4, 6, 8 };\n \t\ti = 0;\n \n \t\tfor (auto [index, value] : utils::enumerate(array)) {\n","prefixes":["libcamera-devel","RFC","v1","01/12"]}