[{"id":1772,"web_url":"https://patchwork.libcamera.org/comment/1772/","msgid":"<20190605133616.GD4784@pendragon.ideasonboard.com>","date":"2019-06-05T13:36:16","subject":"Re: [libcamera-devel] [PATCH v3 10/10] libcamera: pipeline: vimc:\n\tadd dummy IPA","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Tue, Jun 04, 2019 at 08:53:16PM -0400, Paul Elder wrote:\n> Make the vimc pipeline handler get the dummy IPA, to show how an IPA can\n> be acquired by a pipeline handler.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v3:\n> - save IPA to VIMC pipeline data\n> - no IPA is non-fatal warning\n> \n> Changes in v2:\n> - save IPA to pipeline data\n> - no IPA is fatal error\n> \n> src/libcamera/pipeline/vimc.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index 0e4eede..ad4577a 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -9,10 +9,13 @@\n> #include \n> \n> #include \n> +#include \n> +#include \n> #include \n> #include \n> \n> #include \"device_enumerator.h\"\n> +#include \"ipa_manager.h\"\n> #include \"log.h\"\n> #include \"media_device.h\"\n> #include \"pipeline_handler.h\"\n> @@ -77,6 +80,8 @@ private:\n> \t\treturn static_cast(\n> \t\t\tPipelineHandler::cameraData(camera));\n> \t}\n> +\n> +\tstd::unique_ptr ipa_;\n> };\n> \n> VimcCameraConfiguration::VimcCameraConfiguration()\n> @@ -248,6 +253,12 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> \tif (!media)\n> \t\treturn false;\n> \n> +\tipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n> +\tif (ipa_ == nullptr)\n> +\t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n> +\telse\n> +\t\tipa_->init();\n> +\n> \tstd::unique_ptr data = utils::make_unique(this);\n> \n> \t/* Locate and open the capture video node. */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62C0865FB4\n\tfor ;\n\tWed, 5 Jun 2019 15:36:34 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-19-33-nat.elisa-mobile.fi\n\t[85.76.19.33])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 29D0A84;\n\tWed, 5 Jun 2019 15:36:32 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1559741794;\n\tbh=2ehD5SDTH70qbECdGkXHsm/hEcpODspqB9lJj3KLd4c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uQm5ACNCX8CYO/YeLcc79lnca1th5eB4Mj9k/w8ZZHVZ6RStLIfPjqfi0hOf+uAUf\n\t7oQL6R/YGQ1uoZihLQGrD6bmZqlarTrrEFXjLcVRYkNV8/IBmIc9wpWwtJN8Np+nUo\n\tCXFTvv9ncYgBRsFWXc/sPcTAmqz1jWincu/FBhkQ=","Date":"Wed, 5 Jun 2019 16:36:16 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190605133616.GD4784@pendragon.ideasonboard.com>","References":"<20190605005316.4835-1-paul.elder@ideasonboard.com>\n\t<20190605005316.4835-11-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190605005316.4835-11-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 10/10] libcamera: pipeline: vimc:\n\tadd dummy IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 05 Jun 2019 13:36:34 -0000"}}]