[{"id":19206,"web_url":"https://patchwork.libcamera.org/comment/19206/","msgid":"<1b0136b1-06cc-e3f2-ef30-e3cb394d4f9c@ideasonboard.com>","date":"2021-08-31T09:19:50","subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: histogram: Fix typo","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 31/08/2021 10:18, Laurent Pinchart wrote:\n> \"weighted\", derived from the verb \"to weight\", comes from Middle English\n> weight, weiȝte, weght, wight, from Old English wiht, ġewiht, from\n> Proto-Germanic *wihtiz, from Proto-Indo-European *weǵʰ-. In none of\n> those does the t come before the h.\n\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/histogram.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp\n> index fb1eb2a2f0b1..4d94571f903a 100644\n> --- a/src/ipa/libipa/histogram.cpp\n> +++ b/src/ipa/libipa/histogram.cpp\n> @@ -139,7 +139,7 @@ double Histogram::interQuantileMean(double lowQuantile, double highQuantile) con\n> \t\tdouble freq = (cumulative_[bin + 1] - cumulative_[bin])\n> \t\t\t* (std::min(p_next, highPoint) - lowPoint);\n> \n> -\t\t/* Accumulate weigthed bin */\n> +\t\t/* Accumulate weighted bin */\n> \t\tsumBinFreq += bin * freq;\n> \t\t/* Accumulate weights */\n> \t\tcumulFreq += freq;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43272BDC71\n\tfor ;\n\tTue, 31 Aug 2021 09:19:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0ED7A6916A;\n\tTue, 31 Aug 2021 11:19:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D49760288\n\tfor ;\n\tTue, 31 Aug 2021 11:19:54 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A49D03D7;\n\tTue, 31 Aug 2021 11:19:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FZ1Vf9yo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630401594;\n\tbh=gsAzGF1zJobJND9LzGEdQ8V42Td4xY0o51IEWQYYDh8=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=FZ1Vf9yox8MB9K0Qt1mIiex82F/RMxhb37JVsLjqYl54stGSL2RRdp8uC4NVcQyvB\n\taFukMNUGgnonI7D/CpZ9athVv0HjAsrIwEPXvAxAFW7Qy5TrKyPYEBYsDh0uHslehM\n\t/OCinmuMkqkMQkx8wdeQFaqGnst3f7l814Lw4A5Q=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210831091800.22682-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Message-ID":"<1b0136b1-06cc-e3f2-ef30-e3cb394d4f9c@ideasonboard.com>","Date":"Tue, 31 Aug 2021 10:19:50 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<20210831091800.22682-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: histogram: Fix typo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19209,"web_url":"https://patchwork.libcamera.org/comment/19209/","msgid":"<1a6071db-4385-d20f-954e-8f742ac83dcd@ideasonboard.com>","date":"2021-08-31T09:34:51","subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: histogram: Fix typo","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 31/08/2021 11:19, Kieran Bingham wrote:\n> On 31/08/2021 10:18, Laurent Pinchart wrote:\n>> \"weighted\", derived from the verb \"to weight\", comes from Middle English\n>> weight, weiȝte, weght, wight, from Old English wiht, ġewiht, from\n>> Proto-Germanic *wihtiz, from Proto-Indo-European *weǵʰ-. In none of\n>> those does the t come before the h.\n> \n> \n> Reviewed-by: Kieran Bingham \nReviewed-by: Jean-Michel Hautbois \n> \n> \n>> Signed-off-by: Laurent Pinchart \n>> ---\n>> src/ipa/libipa/histogram.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp\n>> index fb1eb2a2f0b1..4d94571f903a 100644\n>> --- a/src/ipa/libipa/histogram.cpp\n>> +++ b/src/ipa/libipa/histogram.cpp\n>> @@ -139,7 +139,7 @@ double Histogram::interQuantileMean(double lowQuantile, double highQuantile) con\n>> \t\tdouble freq = (cumulative_[bin + 1] - cumulative_[bin])\n>> \t\t\t* (std::min(p_next, highPoint) - lowPoint);\n>> \n>> -\t\t/* Accumulate weigthed bin */\n>> +\t\t/* Accumulate weighted bin */\n>> \t\tsumBinFreq += bin * freq;\n>> \t\t/* Accumulate weights */\n>> \t\tcumulFreq += freq;\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5709DBD87D\n\tfor ;\n\tTue, 31 Aug 2021 09:34:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13D8D6916F;\n\tTue, 31 Aug 2021 11:34:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71A626916B\n\tfor ;\n\tTue, 31 Aug 2021 11:34:54 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:b904:a32:6762:6e37])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 218C73D7;\n\tTue, 31 Aug 2021 11:34:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L+EWSmF/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630402494;\n\tbh=AEgHAFEkJRJInH62tHJ4jdVZIg8jcDdCwryCWGC9Xxw=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=L+EWSmF/OIrHFH3FD8FA5RgO8f6Ub7IaCbHPTcaRALcSauYcXy21iJmaz8CeRb4In\n\tFrn4XTsW1EalvdpSt61ndrm2h9t/jYJNZhtFzN4hqfskDXOOqmU5TXnAr7tCh084xs\n\tNbL/9oxox8m/vjWQmur2lBj5gg/52OHZ4yjMVWk8=","To":"Kieran Bingham ,\n\tLaurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210831091800.22682-1-laurent.pinchart@ideasonboard.com>\n\t<1b0136b1-06cc-e3f2-ef30-e3cb394d4f9c@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"<1a6071db-4385-d20f-954e-8f742ac83dcd@ideasonboard.com>","Date":"Tue, 31 Aug 2021 11:34:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"<1b0136b1-06cc-e3f2-ef30-e3cb394d4f9c@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] ipa: libipa: histogram: Fix typo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]