[{"id":19184,"web_url":"https://patchwork.libcamera.org/comment/19184/","msgid":"","date":"2021-08-30T19:21:06","subject":"Re: [libcamera-devel] [PATCH] android: generic_camera_buffer: Fix\n\tbufferLength_ initialization","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent,\n\nOn Tue, Aug 31, 2021 at 4:01 AM Laurent Pinchart\n wrote:\n>\n> The bufferLength_ member variabled is checked to have a positive value\n> before being used, to catch usage before the variable is set. The\n> variable is initialized to zero at construction time, which renders the\n> checks useless.\n>\n> Fix this by initializing the variable to -1 at construction time.\n>\n> Fixes: c5e2ed7806be (\"android: camera_buffer: Map buffer in the first plane() call\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Hirokazu Honda \n> ---\n> I've accidentally applied v3 of \"android: camera_buffer: Map buffer in\n> the first plane() call\" before Hiro mentioned a v4 was needed. Sorry\n> about that.\n> ---\n> src/android/mm/generic_camera_buffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp\n> index a41ae2c96023..22efc4d4b13a 100644\n> --- a/src/android/mm/generic_camera_buffer.cpp\n> +++ b/src/android/mm/generic_camera_buffer.cpp\n> @@ -60,7 +60,7 @@ CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer,\n> buffer_handle_t camera3Buffer,\n> libcamera::PixelFormat pixelFormat,\n> const libcamera::Size &size, int flags)\n> - : fd_(-1), flags_(flags), bufferLength_(0), mapped_(false)\n> + : fd_(-1), flags_(flags), bufferLength_(-1), mapped_(false)\n> {\n> error_ = 0;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FDB3BDC71\n\tfor ;\n\tMon, 30 Aug 2021 19:21:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE9916916A;\n\tMon, 30 Aug 2021 21:21:18 +0200 (CEST)","from mail-ej1-x631.google.com (mail-ej1-x631.google.com\n\t[IPv6:2a00:1450:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E63D60258\n\tfor ;\n\tMon, 30 Aug 2021 21:21:17 +0200 (CEST)","by mail-ej1-x631.google.com with SMTP id i21so33496240ejd.2\n\tfor ;\n\tMon, 30 Aug 2021 12:21:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"aDGBIApY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=8eNBdBDYYLI2zYjelQHuD0/YPJm9QWZG/4Gc3ySYbEs=;\n\tb=aDGBIApYecnSlYJa8sDjpTqag22MDku0HeAWJjAjq2Zn3EoYZzyyiMAqaQijN/Q/Bf\n\tGtLQzFT3nxxD4UGQMkpptfZ2ui5tuA3cMcNHF3k8Ab8ZKhbMBqR3wNB/najDIOPPom0I\n\t0QwT4OlAVkrF4s/e1TzDlliNW2xSPYiD5VmPg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=8eNBdBDYYLI2zYjelQHuD0/YPJm9QWZG/4Gc3ySYbEs=;\n\tb=Ssbh73ixrTI7YCyT5iinkti3h1era5On5O7ZfBw3lskaiSdhhSlXEq6bH3r0rb3F70\n\tkXtNvu4iYTbfJHdLJei6LAG2mVsASSBt5tt9MKpFozA1tG2MdEqcLdHEQJtBlEdzimRf\n\tgv8H94t896fOJR1Nsti/iK0Z567ZdCf6hT1cUfl1c3d6D6Ovd+2JEKgfzP4A0t9VuqK9\n\t3QnglnnkvJ3Flkqn3woxmsj5yVuFVSTUND+RFWRqOH4IB2/x6CbgcTxyrAtPBr9olkeG\n\tzwVIWpA8fWh/XQ68Y/e69MWIlOOXKqocwFyI9LDAQ/sdXbQB+Wmy83qcJlMjR+lyDrFN\n\to/Lw==","X-Gm-Message-State":"AOAM530lHb715Rry5KtykfXjxDZfOIPT9N/jlYjjp6gbmXBwdohEXKpb\n\t+UhxUOUJHut38ZvQjdDLzvOKEE5UJgpF7GFJvGr3dA==","X-Google-Smtp-Source":"ABdhPJzSi9Tm145U3sJnTchm/tzQyz+OHNeE7k3Urubc63NNpSaqWJeeZdQInqlODSuhiXxijqT/OfqyE4kQ8s3VW8g=","X-Received":"by 2002:a17:906:249a:: with SMTP id\n\te26mr14261319ejb.221.1630351277123; \n\tMon, 30 Aug 2021 12:21:17 -0700 (PDT)","MIME-Version":"1.0","References":"<20210830190133.27155-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210830190133.27155-1-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Tue, 31 Aug 2021 04:21:06 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] android: generic_camera_buffer: Fix\n\tbufferLength_ initialization","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19212,"web_url":"https://patchwork.libcamera.org/comment/19212/","msgid":"<20210831100905.lw2yyujlg4by63gz@uno.localdomain>","date":"2021-08-31T10:09:05","subject":"Re: [libcamera-devel] [PATCH] android: generic_camera_buffer: Fix\n\tbufferLength_ initialization","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Aug 30, 2021 at 10:01:33PM +0300, Laurent Pinchart wrote:\n> The bufferLength_ member variabled is checked to have a positive value\n> before being used, to catch usage before the variable is set. The\n> variable is initialized to zero at construction time, which renders the\n> checks useless.\n>\n> Fix this by initializing the variable to -1 at construction time.\n>\n> Fixes: c5e2ed7806be (\"android: camera_buffer: Map buffer in the first plane() call\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> I've accidentally applied v3 of \"android: camera_buffer: Map buffer in\n> the first plane() call\" before Hiro mentioned a v4 was needed. Sorry\n> about that.\n> ---\n> src/android/mm/generic_camera_buffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp\n> index a41ae2c96023..22efc4d4b13a 100644\n> --- a/src/android/mm/generic_camera_buffer.cpp\n> +++ b/src/android/mm/generic_camera_buffer.cpp\n> @@ -60,7 +60,7 @@ CameraBuffer::Private::Private([[maybe_unused]] CameraBuffer *cameraBuffer,\n> \t\t\t buffer_handle_t camera3Buffer,\n> \t\t\t libcamera::PixelFormat pixelFormat,\n> \t\t\t const libcamera::Size &size, int flags)\n> -\t: fd_(-1), flags_(flags), bufferLength_(0), mapped_(false)\n> +\t: fd_(-1), flags_(flags), bufferLength_(-1), mapped_(false)\n> {\n> \terror_ = 0;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E3E6BD87D\n\tfor ;\n\tTue, 31 Aug 2021 10:08:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F7F06916A;\n\tTue, 31 Aug 2021 12:08:17 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60BF868890\n\tfor ;\n\tTue, 31 Aug 2021 12:08:16 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 97C431BF20E;\n\tTue, 31 Aug 2021 10:08:15 +0000 (UTC)"],"Date":"Tue, 31 Aug 2021 12:09:05 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210831100905.lw2yyujlg4by63gz@uno.localdomain>","References":"<20210830190133.27155-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210830190133.27155-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: generic_camera_buffer: Fix\n\tbufferLength_ initialization","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]