[{"id":19244,"web_url":"https://patchwork.libcamera.org/comment/19244/","msgid":"<20210901072651.GT968527@pyrite.rasen.tech>","date":"2021-09-01T07:26:51","subject":"Re: [libcamera-devel] [PATCH 11/16] android: capabilities: Print\n\toutput stream list","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Aug 27, 2021 at 02:07:52PM +0200, Jacopo Mondi wrote:\n> Add a debug statement to print out the list of collected output stream\n\ns/stream/streams/\n\n> and their characteristics.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_capabilities.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index c1ce63018aa8..484242d0ad81 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1277,6 +1277,13 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> \t\tavailableStreamConfigurations.push_back(\n> \t\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT);\n> +\n> +\t\tLOG(HAL, Debug)\n> +\t\t\t<< \"Output Stream:\" << utils::hex(entry.androidFormat)\n> +\t\t\t<< \"(\" << entry.resolution.width << \"x\"\n\nWould s/:/: / and s/(/ (/ look better?\n\n\nReviewed-by: Paul Elder \n\n> +\t\t\t<< entry.resolution.height << \")[\"\n> +\t\t\t<< entry.minFrameDurationNsec << \"]\"\n> +\t\t\t<< \"@\" << fps;\n> \t}\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> \t\t\t\t availableStreamConfigurations);\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02842BD87D\n\tfor ;\n\tWed, 1 Sep 2021 07:27:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7349A6916A;\n\tWed, 1 Sep 2021 09:27:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4453560253\n\tfor ;\n\tWed, 1 Sep 2021 09:27:00 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BBA4A3D7;\n\tWed, 1 Sep 2021 09:26:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O13fE3up\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630481219;\n\tbh=M03nbF+qpa+PzG+Q0RDO2ECvQC47Rw5AbQKvvIsDoME=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=O13fE3up3eUIjg2hpPROMrUdNAyU9NIc54qKRulaiotw4oz32KLzOkcwBZfEF58N8\n\tXVI+Hg6N5Uavd+D1wQK3TL6gaASlAcH5xz1DhLk58wX0wZNaS+0CKrhwR8MqSOtlmr\n\twWhS0qOp2RYRfQ1+4ZxvJmn10noRjtglWvvyj/GQ=","Date":"Wed, 1 Sep 2021 16:26:51 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210901072651.GT968527@pyrite.rasen.tech>","References":"<20210827120757.110615-1-jacopo@jmondi.org>\n\t<20210827120757.110615-12-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210827120757.110615-12-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 11/16] android: capabilities: Print\n\toutput stream list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19257,"web_url":"https://patchwork.libcamera.org/comment/19257/","msgid":"<35a26b33-ad20-d608-4e8b-a55672bfe5ac@ideasonboard.com>","date":"2021-09-01T08:55:10","subject":"Re: [libcamera-devel] [PATCH 11/16] android: capabilities: Print\n\toutput stream list","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 8/27/21 5:37 PM, Jacopo Mondi wrote:\n> Add a debug statement to print out the list of collected output stream\n> and their characteristics.\n>\n> Signed-off-by: Jacopo Mondi \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/android/camera_capabilities.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index c1ce63018aa8..484242d0ad81 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1277,6 +1277,13 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> \t\tavailableStreamConfigurations.push_back(\n> \t\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT);\n> +\n> +\t\tLOG(HAL, Debug)\n> +\t\t\t<< \"Output Stream:\" << utils::hex(entry.androidFormat)\n> +\t\t\t<< \"(\" << entry.resolution.width << \"x\"\n> +\t\t\t<< entry.resolution.height << \")[\"\n> +\t\t\t<< entry.minFrameDurationNsec << \"]\"\n> +\t\t\t<< \"@\" << fps;\n> \t}\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> \t\t\t\t availableStreamConfigurations);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44E6EBD87D\n\tfor ;\n\tWed, 1 Sep 2021 08:55:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01AFF6916A;\n\tWed, 1 Sep 2021 10:55:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4517C60253\n\tfor ;\n\tWed, 1 Sep 2021 10:55:14 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70C8F3D7;\n\tWed, 1 Sep 2021 10:55:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CBtzUQgi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630486514;\n\tbh=2QUAXyeZ984Fu3rE8okq78KnLbjnJFN0p5ypTLBAuOw=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=CBtzUQgiEnl72Ghoqg2hGkhiSkStyY3UPXnv3t5BS8EPeoH3zxMxVPQAZxaFhEZrN\n\tIS4ZhCbf1d2jZpg79ce8twzol09MjgMPL77LYncuQsaopeI3VqCOiu8Rj/V/SdOIa6\n\tU/hb/wWRaKg+TRbozD/lMLUtk16VBF/pDx9RFlA0=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210827120757.110615-1-jacopo@jmondi.org>\n\t<20210827120757.110615-12-jacopo@jmondi.org>","From":"Umang Jain ","Message-ID":"<35a26b33-ad20-d608-4e8b-a55672bfe5ac@ideasonboard.com>","Date":"Wed, 1 Sep 2021 14:25:10 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210827120757.110615-12-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 11/16] android: capabilities: Print\n\toutput stream list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]