[{"id":19248,"web_url":"https://patchwork.libcamera.org/comment/19248/","msgid":"","date":"2021-09-01T07:57:19","subject":"Re: [libcamera-devel] [PATCH 08/16] android: capabilties: Correctly\n\tpopulate STALL durations","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo\n\nOn 8/27/21 5:37 PM, Jacopo Mondi wrote:\n> We currently only record 2560x1920@30FPS as stalling frame duration.\n\n\ns/only record/hardcode/\n\n(just a suggestion, puts things in accurate perspective)\n\n>\n> This is of course not correct, and all the required information to\n> properly populate the ANDROID_SCALER_AVAILABLE_STALL_DURATIONS static\n> metadata are available from initializeStaticMetadata().\n>\n> Use the collected stalling durations and sizes to properly popoulate the\n> static property.\n>\n> Signed-off-by: Jacopo Mondi \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/android/camera_capabilities.cpp | 19 +++++++++++++------\n> 1 file changed, 13 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 061e65241806..23a9a3fbec50 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1263,12 +1263,6 @@ int CameraCapabilities::initializeStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> \t\t\t\t availableStreamConfigurations);\n> \n> -\tstd::vector availableStallDurations = {\n> -\t\tANDROID_SCALER_AVAILABLE_FORMATS_BLOB, 2560, 1920, 33333333,\n> -\t};\n> -\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n> -\t\t\t\t availableStallDurations);\n> -\n> \tstd::vector minFrameDurations;\n> \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> @@ -1280,6 +1274,19 @@ int CameraCapabilities::initializeStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n> \t\t\t\t minFrameDurations);\n> \n> +\tstd::vector availableStallDurations;\n> +\tfor (const auto &entry : streamConfigurations_) {\n> +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB)\n> +\t\t\tcontinue;\n> +\n> +\t\tavailableStallDurations.push_back(entry.androidFormat);\n> +\t\tavailableStallDurations.push_back(entry.resolution.width);\n> +\t\tavailableStallDurations.push_back(entry.resolution.height);\n> +\t\tavailableStallDurations.push_back(entry.minFrameDurationNsec);\n> +\t}\n> +\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n> +\t\t\t\t availableStallDurations);\n> +\n> \tuint8_t croppingType = ANDROID_SCALER_CROPPING_TYPE_CENTER_ONLY;\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_CROPPING_TYPE, croppingType);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 396DDBDC71\n\tfor ;\n\tWed, 1 Sep 2021 07:57:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C7F660255;\n\tWed, 1 Sep 2021 09:57:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8BB860253\n\tfor ;\n\tWed, 1 Sep 2021 09:57:23 +0200 (CEST)","from [192.168.1.104] (unknown [103.251.226.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 012473D7;\n\tWed, 1 Sep 2021 09:57:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bFDuJY59\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630483043;\n\tbh=xeypfv//b+aP6l2uAw+c4N8sX0Hct4vDFgb+yWSHaVM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bFDuJY59twu1wIjsiHWv4bWkS5A5dw64Fi1mR6y3PAPQiFgaNB5jikxyaHgdECaer\n\tTyR7N+KeRNl0lGgCuehZ+AfYQgp9OmaASF7Ryn493k5YRyLmKFxroKTTm6++t71UCc\n\tMgI6I8iew9/Lh+8DlXniF3ipG3gdcYOCoa9fjdkk=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210827120757.110615-1-jacopo@jmondi.org>\n\t<20210827120757.110615-9-jacopo@jmondi.org>","From":"Umang Jain ","Message-ID":"","Date":"Wed, 1 Sep 2021 13:27:19 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20210827120757.110615-9-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 08/16] android: capabilties: Correctly\n\tpopulate STALL durations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19249,"web_url":"https://patchwork.libcamera.org/comment/19249/","msgid":"<20210901081445.GU968527@pyrite.rasen.tech>","date":"2021-09-01T08:14:45","subject":"Re: [libcamera-devel] [PATCH 08/16] android: capabilties: Correctly\n\tpopulate STALL durations","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Aug 27, 2021 at 02:07:49PM +0200, Jacopo Mondi wrote:\n> We currently only record 2560x1920@30FPS as stalling frame duration.\n> \n> This is of course not correct, and all the required information to\n> properly populate the ANDROID_SCALER_AVAILABLE_STALL_DURATIONS static\n> metadata are available from initializeStaticMetadata().\n> \n> Use the collected stalling durations and sizes to properly popoulate the\n> static property.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_capabilities.cpp | 19 +++++++++++++------\n> 1 file changed, 13 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 061e65241806..23a9a3fbec50 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1263,12 +1263,6 @@ int CameraCapabilities::initializeStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> \t\t\t\t availableStreamConfigurations);\n> \n> -\tstd::vector availableStallDurations = {\n> -\t\tANDROID_SCALER_AVAILABLE_FORMATS_BLOB, 2560, 1920, 33333333,\n> -\t};\n> -\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n> -\t\t\t\t availableStallDurations);\n> -\n> \tstd::vector minFrameDurations;\n> \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> @@ -1280,6 +1274,19 @@ int CameraCapabilities::initializeStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n> \t\t\t\t minFrameDurations);\n> \n> +\tstd::vector availableStallDurations;\n> +\tfor (const auto &entry : streamConfigurations_) {\n> +\t\tif (entry.androidFormat != HAL_PIXEL_FORMAT_BLOB)\n> +\t\t\tcontinue;\n> +\n> +\t\tavailableStallDurations.push_back(entry.androidFormat);\n> +\t\tavailableStallDurations.push_back(entry.resolution.width);\n> +\t\tavailableStallDurations.push_back(entry.resolution.height);\n> +\t\tavailableStallDurations.push_back(entry.minFrameDurationNsec);\n> +\t}\n> +\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n> +\t\t\t\t availableStallDurations);\n> +\n> \tuint8_t croppingType = ANDROID_SCALER_CROPPING_TYPE_CENTER_ONLY;\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_CROPPING_TYPE, croppingType);\n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 050DCBDC71\n\tfor ;\n\tWed, 1 Sep 2021 08:14:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6AC8F6916A;\n\tWed, 1 Sep 2021 10:14:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C289660253\n\tfor ;\n\tWed, 1 Sep 2021 10:14:53 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D1DB3D7;\n\tWed, 1 Sep 2021 10:14:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h3wtPVQn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630484093;\n\tbh=cVU4yFeAJo/RE7sNgaDzTIBhokOW7JY7SOepenubcxE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=h3wtPVQnxsLzXf/XNMdmn6v1PykwOF1BiT2VeJs4yHuEXUdLnOIJ6G5ZL1OmH8ZEI\n\t+qyyvYmIvI+wRUrDHzLULmvsWdJdm07aaN/+2lG4SXSeD4iutap9LigAR99bAtQvPs\n\tFZXuOZmnExI0fJVilCEqU4Fhi8naTZFhZ2AoGfrI=","Date":"Wed, 1 Sep 2021 17:14:45 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210901081445.GU968527@pyrite.rasen.tech>","References":"<20210827120757.110615-1-jacopo@jmondi.org>\n\t<20210827120757.110615-9-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20210827120757.110615-9-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 08/16] android: capabilties: Correctly\n\tpopulate STALL durations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]