[{"id":19138,"web_url":"https://patchwork.libcamera.org/comment/19138/","msgid":"","date":"2021-08-27T11:38:04","subject":"Re: [libcamera-devel] [PATCH] clang-format: Remove unsupported\n\toption","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Aug 27, 2021 at 12:01:09PM +0100, Kieran Bingham wrote:\n> The CaseSensitive option requires clang-format 12 which is not widely\n> available.\n> \n> Remove the option, to fix clang-format uses until a solution which\n> supports clang-format version specific configurations can be merged.\n\nOut of curiosity, have you run into blocking issue when trying to\nimplementing this through a symlink, or is that still the plan ?\n\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> .clang-format | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/.clang-format b/.clang-format\n> index ff60b928affc..5b8857dae924 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -77,7 +77,6 @@ IncludeCategories:\n> # Qt includes (match before C++ standard library)\n> - Regex: ''\n> Priority: 9\n> - CaseSensitive: true\n> # Headers in <> with an extension. (+system libraries)\n> - Regex: '<([A-Za-z0-9\\-_])+\\.h>'\n> Priority: 2","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22693BD87D\n\tfor ;\n\tFri, 27 Aug 2021 11:38:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E01986891F;\n\tFri, 27 Aug 2021 13:38:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F7A860256\n\tfor ;\n\tFri, 27 Aug 2021 13:38:17 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 19F025A1;\n\tFri, 27 Aug 2021 13:38:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SvedVOyX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630064297;\n\tbh=iPujebEudELh8UiJhkNmjvAEcNfrQnKlwX100pFA7jk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SvedVOyX8Mhmh9gQDJYYPuIyRG9RSwxY8DZcsETxdcaTQM6y/jqFZz6HHUPj4Eymg\n\toJdd0v2Jt58XyTiBYejtRqcipLVK2Y62d7NmOWp4E7X0X5Mcnf7yM5CbqcZFKdwcEv\n\ttC2Y32tNIbatg/09Ism7o6Hed2c6XCJ+BkHa5E0s=","Date":"Fri, 27 Aug 2021 14:38:04 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210827110109.381221-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210827110109.381221-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Remove unsupported\n\toption","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":19143,"web_url":"https://patchwork.libcamera.org/comment/19143/","msgid":"","date":"2021-08-27T12:13:08","subject":"Re: [libcamera-devel] [PATCH] clang-format: Remove unsupported\n\toption","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 27/08/2021 12:38, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Aug 27, 2021 at 12:01:09PM +0100, Kieran Bingham wrote:\n>> The CaseSensitive option requires clang-format 12 which is not widely\n>> available.\n>>\n>> Remove the option, to fix clang-format uses until a solution which\n>> supports clang-format version specific configurations can be merged.\n> \n> Out of curiosity, have you run into blocking issue when trying to\n> implementing this through a symlink, or is that still the plan ?\n\nI have a 'working' implementation. I'm not sure I like it though.\n\nAnd also, it seemed I still haven't posted it, and given the impending\nweekend, I wanted to send this patch so it can be integrated rapidly.\n\nThe symlink implementation may take more time to review, which may add\nfurther delay causing discomfort to any users with clang-format < 12.\n\n> \n>> Signed-off-by: Kieran Bingham \n> \n> Reviewed-by: Laurent Pinchart \n> \n>> ---\n>> .clang-format | 1 -\n>> 1 file changed, 1 deletion(-)\n>>\n>> diff --git a/.clang-format b/.clang-format\n>> index ff60b928affc..5b8857dae924 100644\n>> --- a/.clang-format\n>> +++ b/.clang-format\n>> @@ -77,7 +77,6 @@ IncludeCategories:\n>> # Qt includes (match before C++ standard library)\n>> - Regex: ''\n>> Priority: 9\n>> - CaseSensitive: true\n>> # Headers in <> with an extension. (+system libraries)\n>> - Regex: '<([A-Za-z0-9\\-_])+\\.h>'\n>> Priority: 2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E5D5BD87C\n\tfor ;\n\tFri, 27 Aug 2021 12:13:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 887936891F;\n\tFri, 27 Aug 2021 14:13:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7E9460256\n\tfor ;\n\tFri, 27 Aug 2021 14:13:11 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 618FF499;\n\tFri, 27 Aug 2021 14:13:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PqsP3t4t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630066391;\n\tbh=H+v2xmlyFDGS1lXG5CU1KYPFJZM7uDFYFu+xePGiQqY=;\n\th=From:Subject:To:Cc:References:Date:In-Reply-To:From;\n\tb=PqsP3t4tJybYEjXYzFGY4zXsnZAOVHEYmqvZNricwrzwkp/z8htZ2N0eCV0vow5oP\n\tceyMdxeHDmLBIAaef0u5q+PDbmt5+NUY2bmKqazch2bBW25WkPsjpNkO/IaqGjbc0h\n\tVorAd8+sAvDgOW5emtrlfLE1EL2jxvXijDovijKs=","From":"Kieran Bingham ","To":"Laurent Pinchart ","References":"<20210827110109.381221-1-kieran.bingham@ideasonboard.com>\n\t","Message-ID":"","Date":"Fri, 27 Aug 2021 13:13:08 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.11.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Remove unsupported\n\toption","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]