[{"id":19135,"web_url":"https://patchwork.libcamera.org/comment/19135/","msgid":"","date":"2021-08-27T10:58:43","subject":"Re: [libcamera-devel] [PATCH 2/2] Documentation: Explicitly enable\n\tDot","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Aug 27, 2021 at 11:33:34AM +0100, Kieran Bingham wrote:\n> The dot package is identified as a required package for the Documentation, and\n> already marked as a required dependency with meson.\n> \n> If meson can not find 'dot', then the documentation will not be built,\n> so we can explicitly enable it in our Doxyfile.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Documentation/Doxyfile.in | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\n> index 49355bf6a9ff..24ccf0c066ee 100644\n> --- a/Documentation/Doxyfile.in\n> +++ b/Documentation/Doxyfile.in\n> @@ -2130,7 +2130,7 @@ HIDE_UNDOC_RELATIONS = YES\n> # set to NO\n> # The default value is: NO.\n> \n> -HAVE_DOT = NO\n> +HAVE_DOT = YES\n> \n> # The DOT_NUM_THREADS specifies the number of dot invocations doxygen is allowed\n> # to run in parallel. When set to 0 doxygen will base this on the number of","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF979BD87C\n\tfor ;\n\tFri, 27 Aug 2021 10:58:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 285376891F;\n\tFri, 27 Aug 2021 12:58:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F1EF60256\n\tfor ;\n\tFri, 27 Aug 2021 12:58:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B92FB5A1;\n\tFri, 27 Aug 2021 12:58:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SHE0Fwd7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630061936;\n\tbh=y96LW5nRC7DVlM7KComdqPw/ZpAHz/A8lBvkjOaVTDo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SHE0Fwd7kI+SjnVhjOOS55/I/T5KtOyKOYj4Cn1LD1z50zaOI+uHEBA2uYH6CA8Dv\n\tQhTajY1eN+YWI6r9MptxE89fTLaokX7W7cXyM8YB3yQxeb1MaB3oZLl/QwvC6nRgvs\n\tWZIUj1U1Oc71J43lefkFjHFbSYmWRDrlYm3ntuDw=","Date":"Fri, 27 Aug 2021 13:58:43 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210827103334.350416-1-kieran.bingham@ideasonboard.com>\n\t<20210827103334.350416-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20210827103334.350416-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] Documentation: Explicitly enable\n\tDot","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]